Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get parsed statistics #22

Open
IlgamGabdullin opened this issue May 27, 2024 · 5 comments
Open

Get parsed statistics #22

IlgamGabdullin opened this issue May 27, 2024 · 5 comments

Comments

@IlgamGabdullin
Copy link
Contributor

IlgamGabdullin commented May 27, 2024

Hi! I've noticed that the library does rtc stats parsing to calculate mos and possible issues, but does not share the parsed rtc stats. Do you have plans on adding the ability to get parsed rtc stats? I see it as new callback in constructor onStatsParsed: (stats: WebRTCStatsParsed)

@evgmel
Copy link
Collaborator

evgmel commented Jun 3, 2024

Hi @IlgamGabdullin ! Thanks for the question. Yes, we have such plans, but I cannot say for sure when exactly it'll be implemented. You can contribute by opening a pull request with the suggested feature. Our community will review the PR when it's ready 👍

@IlgamGabdullin
Copy link
Contributor Author

@evgmel, hi! thanks for the response!

We have also encountered some cases, when we do not need issues detecting , we need only mos calculating and parsed rtc stats. As a solution to meet the cases - we could make a new configuration property that is a list of ssrc's (ignoreIssueDetectingSSRCList), for which we do not call detectIssues method (similar to ignoreSSRCList, but only for ignoring issues detecting). Would it be a good solution or we should consider another one?

@evgmel
Copy link
Collaborator

evgmel commented Jul 19, 2024

@IlgamGabdullin Hi! Did you try to pass an empty array of detectors as one of WebRTCIssueDetector class argument props? By default it's undefined and in this case the default set of detectors are assigned. But if you pass an empty array instead of undefined/not specifying, you won't get any issues detected.
Would that work for you?

@IlgamGabdullin
Copy link
Contributor Author

IlgamGabdullin commented Jul 21, 2024

@evgmel Hi! thanks for the response. If we pass an empty array it indeed does not detect any issues for any peer connection. In our case we would like to detect issues for several connections (but not for every one of them). The case: we have group calls up to 25 participants and detecting issues for every pc is cpu consuming process (especially on mobile devices)

@evgmel
Copy link
Collaborator

evgmel commented Jul 22, 2024

@IlgamGabdullin In this case you can open a PR with the proposed solution, our community members will review it when the code is ready 🤝

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants