**2020.3.14-dev (202003140)**

- `acc -s v`: fixed "voltage unit not shown"
- `cooldownCurrent=(file raw_current charge_seconds pause_seconds)`, cooldown_current (ccr): dedicated and independent cooldown settings for quick charging
- General optimizations
- Updated documentation

Author: VR-25

README.md

@@ -48,14 +48,13 @@ By choosing to use/misuse ACC, you agree to do so at your own risk!
 ACC is an Android software mainly intended for [extending battery service life](https://batteryuniversity.com/learn/article/how_to_prolong_lithium_based_batteries).
 In a nutshell, this is achieved through limiting charging current, temperature and voltage.
 Any root solution is supported. A recent stable Magisk version is recommended.
-If you're reading this from Magisk Manager > Downloads, tap here to open the documentation.
-Once there, if you're lazy, jump to the quick start section.
 
 
 
 ---
 ## PREREQUISITES
 
+- [Must Read: How to Prolong Lithium Ion Batteries Lifespan](https://batteryuniversity.com/index.php/learn/article/how_to_prolong_lithium_based_batteries/)
 - Android or Android based OS
 - Any root solution (e.g., [Magisk](https://github.com/topjohnwu/Magisk/))
 - [Busybox*](https://github.com/search?o=desc&q=busybox+android&s=updated&type=Repositories/) (only if not rooted with Magisk)
@@ -67,39 +66,44 @@ Once there, if you're lazy, jump to the quick start section.
 That's a fallback path. ACC sets permissions (rwx------) as needed.
 Precedence: Magisk busybox > system busybox > /data/adb/busybox
 
-\*\* The Magisk module [ccbins](https://github.com/Magisk-Modules-Repo/ccbins/) by [Zackptg5](https://github.com/Zackptg5/) installs `curl`.
+\*\* The Magisk module [Cross Compiled Binaries](https://github.com/Magisk-Modules-Repo/ccbins/) installs `curl`.
 
 
 
 ---
 ## QUICK START GUIDE
 
+0. All commands/actions require root.
+Don't use `su -c`, `sudo`, `tsudo` or similar. On Android, these are not as reliable as the plain old `su`.
 
 1. Unless Magisk is not installed, always install/upgrade from Magisk Manager or ACC front-end (e.g. AccA).
 Apps such as EX/Franco Kernel Managers are also good options.
 There are yet two more ways of upgrading: `acc -u` (online) and `acc -F` (zip flasher).
 Rebooting after installation/removal is unnecessary.
 
-2. [Optional] run `su -c acc pause_capacity resume_capacity` (default `75 70`) or use a front-end app to change settings.
+2.  [Optional] run `acc` (wizard). That's the only command you need to remember.
 
-3. If you come across an issue, refer to the `TROUBLESHOOTING`, `TIPS` and `FAQ` sections below.
-Read as much as you can, before asking the developer or opening an issue on GitHub.
+3. [Optional] run `acc pause_capacity resume_capacity` (default `75 70`) to set the battery levels at which charging should pause and resume, respectively.
+
+4. If you come across an issue, refer to the `TROUBLESHOOTING`, `TIPS` and `FAQ` sections below.
+Read as much as you can before asking the developer or opening issues on GitHub.
 Oftentimes, solutions will be right before your eyes.
 
 
 ### Notes
 
 - ACC cannot be installed/upgraded from recovery (e.g., TWRP).
 
-- Step `2` is optional, because there are default settings.
+- Steps `2` and `3` are optional because there are default settings.
 For details, refer to the `DEFAULT CONFIGURATION` section below.
+Users are encouraged to try step `2` - to familiarize themselves with the menu.
 
 - Settings can be overwhelming. Start with what you understand.
 The default configuration has you covered.
 Don't ever feel like you have to configure everything. You probably shouldn't anyway - unless you really know what you're doing.
 
 - Uninstall: depending on the installed variant (e.g., app back-end or Magisk module), you can use Magisk Manager (app), [Magisk Manager for Recovery Mode (utility)](https://github.com/VR-25/mm/), or clear the front-end app's data.
-Two universal methods are: `su -c acc --uninstall` and `/sdcard/acc-uninstaller.zip` (flashable uninstaller).
+Two universal methods are: `acc --uninstall` and `/sdcard/acc-uninstaller.zip` (flashable uninstaller).
 
 
 
@@ -176,7 +180,7 @@ Apps such as EX/Franco Kernel Managers are also good options.
 There are yet two more ways of upgrading: `acc -u` (online) and `acc -F` (zip flasher).
 
 Uninstall: depending on the installed variant (e.g., app back-end or Magisk module), you can use Magisk Manager (app), [Magisk Manager for Recovery Mode (utility)](https://github.com/VR-25/mm/), or clear the front-end app's data.
-Two universal methods are: `su -c acc --uninstall` and `/sdcard/acc-uninstaller.zip` (flashable uninstaller).
+Two universal methods are: `acc --uninstall` and `/sdcard/acc-uninstaller.zip` (flashable uninstaller).
 
 
 ### Notes
@@ -197,9 +201,10 @@ Additionally, `$installDir/acc/acc-init.sh` must be executed on boot to initiali
 ```
 #DC#
 
-configVerCode=202003110
+configVerCode=202003140
 capacity=(-1 60 70 75 +0 false)
 temperature=(70 80 90)
+cooldownCurrent=()
 cooldownRatio=()
 resetBattStats=(false false)
 loopDelay=(10 15)
@@ -224,6 +229,8 @@ dynPowerSaving=0
 
 # temperature=(cooldown_temp max_temp max_temp_pause)
 
+# cooldownCurrent=(file raw_current charge_seconds pause_seconds)
+
 # cooldownRatio=(cooldown_charge cooldown_pause)
 
 # resetBattStats=(reset_batt_stats_on_pause reset_batt_stats_on_unplug)
@@ -270,6 +277,8 @@ dynPowerSaving=0
 # mt max_temp
 # mtp max_temp_pause
 
+# ccr cooldown_current
+
 # cch cooldown_charge
 # cp cooldown_pause
 
@@ -318,6 +327,9 @@ dynPowerSaving=0
 # acc /data/acc-night-config.txt -s c 500
 # accd /data/acc-night-config.txt
 
+# acc -s "ccr=battery/current_now 1450000 100 20"
+# acc -s "cooldown_current=battery/current_now 1450000 100 20"
+
 
 # FINE, BUT WHAT DOES EACH OF THESE VARIABLES ACTUALLY MEAN?
 
@@ -367,6 +379,9 @@ dynPowerSaving=0
 # When not set, the cycle is disabled.
 # Note that cooldown_capacity and cooldown_temp can be disabled individually by assigning them values that would never be reached under normal circumstances.
 
+# cooldown_current #
+# Dedicated and independent cooldown settings for quick charging
+
 # reset_batt_stats_on_pause (rbsp) #
 # Reset battery stats after pausing charging.
 
@@ -901,6 +916,12 @@ It's a software (Android/kernel) issue. Use the `capacity_offset` or `capacity_s
 ---
 ## LATEST CHANGES
 
+**2020.3.14-dev (202003140)**
+- `acc -s v`: fixed "voltage unit not shown"
+- `cooldownCurrent=(file raw_current charge_seconds pause_seconds)`, cooldown_current (ccr): dedicated and independent cooldown settings for quick charging
+- General optimizations
+- Updated documentation
+
 **2020.3.11-dev (202003110)**
 - Fixed capacity_sync issues
 

TODO.txt

@@ -1,19 +1,3 @@
-Hangs and reboots
-  Samsung GT-I9082
-  Android 4.2.2
-  Busybox: v1.28.3-Stericson installed in /system/xbin
-  Root: SuperSU
-
-spreadtrum
-flare s5
-
 cooldown
-   cooldownCapacity=(capacity charge/pause)
-   cooldownCurrent=(current charge/pause)
-   cooldownTemp=(temp charge/pause)
-
-capacity_sync inconsistencies
-  incorrect battery status
-  dumpsys
-
-auto-shutdown not happening
+  cooldownTemp=(min_temp charge_seconds pause_seconds max_temp max_temp_pause)
+  cooldownCapacity=(capacity charge_seconds pause_seconds)

acc/accd.sh

@@ -47,8 +47,9 @@ is_charging() {
     applyOnUnplug=true
 
     # forceChargingStatusFullAt100
-    if ! $forcedChargingStatusFullAt100 && [[ ${forceChargingStatusFullAt100:-x} == [0-9]* ]] \
-      && [ $(cat $batt/capacity) -gt 99 ]
+    if ! $forcedChargingStatusFullAt100 \
+      && [ -n "${forceChargingStatusFullAt100-}" ] \
+      && [ $(( $(cat $batt/capacity) ${capacity[4]} )) -gt 99 ]
     then
       dumpsys battery set level 100 \
         && dumpsys battery set status $forceChargingStatusFullAt100 \
@@ -93,10 +94,7 @@ is_charging() {
       # while unplugged, this keeps accd asleep most of the time to save resources
       # detecting plugged/unplugged states is possible (with acpi -a), but not universally
       if [ "$dynPowerSaving" != 0 ] && grep -iq dis $batt/status; then
-        if [ $secondsUnplugged == 0 ]; then
-          [ $(( ${capacity[3]} - ${capacity[2]} )) -gt 4 ] \
-            && hibernate=true || hibernate=false
-        fi
+        [ $secondsUnplugged == 0 ] && hibernate=true || hibernate=false
         secondsUnplugged=$(( secondsUnplugged + ${loopDelay[1]} ))
         ! $hibernate || sleep $secondsUnplugged
         [ $secondsUnplugged -lt $dynPowerSaving ] || secondsUnplugged=0
@@ -112,7 +110,7 @@ is_charging() {
     $cooldown || {
       if $isCharging; then
         dumpsys battery set ac 1 \
-         && dumpsys battery set status $chgStatusCode || :
+          && dumpsys battery set status $chgStatusCode || :
       else
         dumpsys battery unplug \
           && dumpsys battery set status $dischgStatusCode || :
@@ -131,44 +129,52 @@ is_charging() {
 disable_charging() {
   if is_charging; then
     if [ -f "${chargingSwitch[0]-}" ]; then
-      if chmod +w ${chargingSwitch[0]} && echo "${chargingSwitch[2]//::/ }" > ${chargingSwitch[0]}; then
+      if chmod +w ${chargingSwitch[0]} \
+        && echo "${chargingSwitch[2]//::/ }" > ${chargingSwitch[0]}
+      then
         # secondary switch
         if [ -f "${chargingSwitch[3]-}" ]; then
-          chmod +w ${chargingSwitch[3]} && echo "${chargingSwitch[5]//::/ }" > ${chargingSwitch[3]} \
+          chmod +w ${chargingSwitch[3]} \
+            && echo "${chargingSwitch[5]//::/ }" > ${chargingSwitch[3]} \
             || /sbin/acca $config --set charging_switch= > /dev/null
         fi
         sleep $switchDelay
       else
         /sbin/acca $config --set charging_switch= > /dev/null
       fi
     else
-      [[ ${chargingSwitch[0]:-x} != */* ]] || /sbin/acca $config --set charging_switch= > /dev/null
+      [[ ${chargingSwitch[0]:-x} != */* ]] \
+        || /sbin/acca $config --set charging_switch= > /dev/null
       ! $prioritizeBattIdleMode || cycle_switches off not
       ! is_charging || cycle_switches off
     fi
     if is_charging; then
-      [[ ${chargingSwitch[0]:-x} != */* ]] || /sbin/acca $config --set charging_switch= > /dev/null
+      [[ ${chargingSwitch[0]:-x} != */* ]] \
+        || /sbin/acca $config --set charging_switch= > /dev/null
       echo "(!) Failed to disable charging"
       exit 7
+    else
+      # if maxTemp is reached, keep charging paused for ${temperature[2]} seconds more
+      ! [ $(cat $batt/temp 2>/dev/null || cat $batt/batt_temp) -ge $(( ${temperature[1]} * 10 )) ] \
+        || sleep ${temperature[2]}
     fi
   fi
-  # if maxTemp is reached, pause charging regardless of cooldownRatio
-  ! is_charging && [ $(( $(cat $batt/temp 2>/dev/null \
-    || cat $batt/batt_temp) / 10 )) -ge ${temperature[1]} ] \
-    && sleep ${temperature[2]} || :
 }
 
 
 enable_charging() {
   if ! is_charging; then
-    if ! $ghostCharging || { $ghostCharging && [[ "$(acpi -a)" == *on-line* ]]; }; then
+    if ! $ghostCharging \
+      || { $ghostCharging && [[ "$(acpi -a)" == *on-line* ]]; }
+    then
       if [ -f "${chargingSwitch[0]-}" ]; then
         if chmod +w ${chargingSwitch[0]} \
           && echo "${chargingSwitch[1]//::/ }" > ${chargingSwitch[0]}
         then
           # secondary switch
           if [ -f "${chargingSwitch[3]-}" ]; then
-            chmod +w ${chargingSwitch[3]} && echo "${chargingSwitch[4]//::/ }" > ${chargingSwitch[3]} \
+            chmod +w ${chargingSwitch[3]} \
+              && echo "${chargingSwitch[4]//::/ }" > ${chargingSwitch[3]} \
               || /sbin/acca $config --set charging_switch= > /dev/null
           fi
           sleep $switchDelay
@@ -181,7 +187,9 @@ enable_charging() {
         cycle_switches on
       fi
       # detect and block ghost charging
-      if ! $ghostCharging && ! grep -Eiq 'dis|not' $batt/status && [[ "$(acpi -a)" != *on-line* ]]; then
+      if ! $ghostCharging && ! grep -Eiq 'dis|not' $batt/status \
+        && [[ "$(acpi -a)" != *on-line* ]]
+      then
         disable_charging
         ghostCharging=true
         touch $TMPDIR/.ghost-charging
@@ -199,14 +207,12 @@ ctrl_charging() {
 
     if is_charging; then
 
-      sleep ${loopDelay[0]}
-
       # clear "rebooted on pause" flag
-    [ $(( $(cat $batt/capacity) ${capacity[4]} )) -gt ${capacity[2]} ] \
-      || rm ${config%/*}/.rebootedOnPause 2>/dev/null || :
+      [ $(( $(cat $batt/capacity) ${capacity[4]} )) -gt ${capacity[2]} ] \
+        || rm ${config%/*}/.rebootedOnPause 2>/dev/null || :
 
       # disable charging under <conditions>
-      if [ $(( $(cat $batt/temp 2>/dev/null || cat $batt/batt_temp) / 10 )) -ge ${temperature[1]} ] \
+      if [ $(cat $batt/temp 2>/dev/null || cat $batt/batt_temp) -ge $(( ${temperature[1]} * 10 )) ] \
         || [ $(( $(cat $batt/capacity) ${capacity[4]} )) -ge ${capacity[3]} ]
       then
         if [ ! -f ${config%/*}/.rebootedOnPause ]; then
@@ -241,27 +247,31 @@ ctrl_charging() {
 
       if [ ! -f ${config%/*}/.rebootedOnPause ]; then
         # cooldown
-        while [ -n "${cooldownRatio[0]:-}" ] && [ $(( ${capacity[3]} - ${capacity[2]} )) -gt 2 ] \
-          && is_charging && [ $(( $(cat $batt/capacity) ${capacity[4]} )) -lt ${capacity[3]} ] \
-          && [ $(( $(cat $batt/temp 2>/dev/null || cat $batt/batt_temp) / 10 )) -lt ${temperature[1]} ]
+        while [ -n "${cooldownRatio[0]-}" -o -n "${cooldownCurrent[0]-}" ] && is_charging \
+          && [ $(( $(cat $batt/capacity) ${capacity[4]} )) -lt ${capacity[3]} ]
         do
-          cooldown=true
-          if [ $(( $(cat $batt/temp 2>/dev/null || cat $batt/batt_temp) / 10 )) -ge ${temperature[0]} ] \
-            || [ $(( $(cat $batt/capacity) ${capacity[4]} )) -ge ${capacity[1]} ]
+          if [ $(cat $batt/temp 2>/dev/null || cat $batt/batt_temp) -ge $(( ${temperature[0]} * 10 )) ] \
+            || [ $(( $(cat $batt/capacity) ${capacity[4]} )) -ge ${capacity[1]} ] \
+            || [ $(cat ${cooldownCurrent[0]:-cooldownCurrent} 2>/dev/null || echo 0) -ge ${cooldownCurrent[1]:-1} ]
           then
+            cooldown=true
             dumpsys battery set status $chgStatusCode || : # to block unwanted display wakeups
             disable_charging
-            sleep ${cooldownRatio[1]:-1}
+            [ $(cat ${cooldownCurrent[0]:-cooldownCurrent} 2>/dev/null || echo 0) -ge ${cooldownCurrent[1]:-1} ] \
+              && sleep ${cooldownCurrent[3]:-1} \
+              || sleep ${cooldownRatio[1]:-1}
             enable_charging
-            ${capacity[5]} || dumpsys battery reset || :
+            ${capacity[5]} || dumpsys battery reset || : # ${capacity[5]} == capacity_sync
+            ! [ $(cat ${cooldownCurrent[0]:-cooldownCurrent} 2>/dev/null || echo 0) -ge ${cooldownCurrent[1]:-1} ] \
+              || cooldownRatio[0]=${cooldownCurrent[2]-}
             count=0
             while ! grep -Eiq 'dis|not' $batt/status \
               && [ $count -lt ${cooldownRatio[0]:-1} ]
             do
               sleep ${loopDelay[0]}
               [ $(( $(cat $batt/capacity) ${capacity[4]} )) -lt ${capacity[3]} ] \
-                && [ $(( $(cat $batt/temp 2>/dev/null || cat $batt/batt_temp) / 10 )) -lt ${temperature[1]} ] \
-                && count=$(( count + ${loopDelay[0]} )) || break
+                && count=$(( count + ${loopDelay[0]} )) \
+                || break
             done
           else
             break
@@ -270,23 +280,26 @@ ctrl_charging() {
         cooldown=false
       fi
 
-    else
+      sleep ${loopDelay[0]}
 
-      sleep ${loopDelay[1]}
+    else
 
       # enable charging under <conditions>
       if [ $(( $(cat $batt/capacity) ${capacity[4]} )) -le ${capacity[2]} ] \
-        && [ $(( $(cat $batt/temp 2>/dev/null || cat $batt/batt_temp) / 10 )) -lt ${temperature[1]} ]
+        && [ $(cat $batt/temp 2>/dev/null || cat $batt/batt_temp) -lt $(( ${temperature[1]} * 10 )) ]
       then
         enable_charging
       fi
 
-      # auto-shutdown if battery is not charging and capacity is less than <shutdownCapacity>
+      # auto-shutdown if battery is not charging and capacity is less than <shutdown_capacity>
       if ! is_charging && [ $(( $(cat $batt/capacity) ${capacity[4]} )) -le ${capacity[0]} ]; then
         sleep ${loopDelay[1]}
         is_charging \
           || am start -n android/com.android.internal.app.ShutdownActivity 2>/dev/null || reboot -p || :
       fi
+
+      sleep ${loopDelay[1]}
+
     fi
   done
 }
@@ -312,7 +325,9 @@ modPath=/sbin/.acc/acc
 export TMPDIR=${modPath%/*}
 forcedChargingStatusFullAt100=false
 config=/data/adb/acc-data/config.txt
-[ -f $TMPDIR/.ghost-charging ] && ghostCharging=true || ghostCharging=false
+
+[ -f $TMPDIR/.ghost-charging ] \
+  && ghostCharging=true || ghostCharging=false
 
 
 . $modPath/setup-busybox.sh