Skip to content

Commit fe22a52

Browse files
committed
Passing new test
1 parent 18719ae commit fe22a52

File tree

2 files changed

+35
-23
lines changed

2 files changed

+35
-23
lines changed

src/vws/vws.py

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,11 @@
1717

1818
from vws._result_codes import raise_for_result_code
1919
from vws.exceptions import TargetProcessingTimeout
20-
from vws.reports import DatabaseSummaryReport, TargetSummaryReport, TargetStatuses
20+
from vws.reports import (
21+
DatabaseSummaryReport,
22+
TargetStatuses,
23+
TargetSummaryReport,
24+
)
2125

2226

2327
def _target_api_request(

tests/test_vws.py

Lines changed: 30 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -3,18 +3,24 @@
33
"""
44

55
import base64
6+
import datetime
67
import io
78
import random
89
import uuid
910
from typing import Optional
1011

1112
import pytest
13+
from freezegun import freeze_time
1214
from mock_vws import MockVWS
1315
from mock_vws.database import VuforiaDatabase
1416

1517
from vws import VWS, CloudRecoService
1618
from vws.exceptions import TargetProcessingTimeout
17-
from vws.reports import DatabaseSummaryReport
19+
from vws.reports import (
20+
DatabaseSummaryReport,
21+
TargetStatuses,
22+
TargetSummaryReport,
23+
)
1824

1925

2026
class TestAddTarget:
@@ -184,29 +190,31 @@ def test_get_target_summary_report(
184190
"""
185191
Details of a target are returned by ``get_target_summary_report``.
186192
"""
187-
target_id = vws_client.add_target(
188-
name='x',
189-
width=1,
190-
image=high_quality_image,
191-
active_flag=True,
192-
application_metadata=None,
193-
)
193+
date = '2018-04-25'
194+
target_name = uuid.uuid4().hex
195+
with freeze_time(date):
196+
target_id = vws_client.add_target(
197+
name=target_name,
198+
width=1,
199+
image=high_quality_image,
200+
active_flag=True,
201+
application_metadata=None,
202+
)
194203

195204
result = vws_client.get_target_summary_report(target_id=target_id)
196-
expected_keys = {
197-
'status',
198-
'result_code',
199-
'transaction_id',
200-
'database_name',
201-
'target_name',
202-
'upload_date',
203-
'active_flag',
204-
'tracking_rating',
205-
'total_recos',
206-
'current_month_recos',
207-
'previous_month_recos',
208-
}
209-
assert set(result.keys()) == expected_keys
205+
206+
expected_report = TargetSummaryReport(
207+
status=TargetStatuses.SUCCESS,
208+
database_name=result.database_name,
209+
target_name=target_name,
210+
upload_date=datetime.date(2018, 4, 25),
211+
active_flag=True,
212+
tracking_rating=result.tracking_rating,
213+
total_recos=0,
214+
current_month_recos=0,
215+
previous_month_recos=0
216+
)
217+
assert result == expected_report
210218

211219

212220
class TestGetDatabaseSummaryReport:

0 commit comments

Comments
 (0)