You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The release from v3.17.0 to v3.17.4 contains a significant number of GOOD commits (87) with clear functional value, including bug fixes, refactors, and documentation improvements. However, the presence of 27 SLOP commits (slop ratio ~23%) and several administrative noise commits (e.g., CLA signatures) suggests a mixed release. While the GOOD commits are substantial, the slop and noise indicate a need for selective merging to exclude non-value-added changes. No critical breaking changes or dependency conflicts were identified that would necessitate skipping or holding for human review, but careful review of the GOOD batch for hidden slop is advised.
Batch classification
Verdict
Count
Branch
🟢 GOOD
87
sync/upstream/v3.17.4-good
🟡 NEEDS_REVIEW
2
sync/upstream/v3.17.4-needs-review
🔴 SLOP
27
sync/upstream/v3.17.4-slop
🟢 Good batch
Classified as real value. Candidate for merge.
ad85e438fix: include user/project agents in task(subagent_type) resolution -- Adds meaningful functionality with clear user value and new test cases covering various scenarios.
2266f28ffix: correct merge order so project agents override user agents -- The commit fixes a specific behavior issue (merge order of project vs user agents) with clear functional impact, backed by a new test case.
64408823fix: actually swap merge order so project is added before user -- The commit fixes a specific behavior issue (merge order of project vs user agents) with clear functional impact, backed by a new test case.
5441c848refactor: use spyOn instead of vi.mock for agent loader mocks -- The commit replaces vi.mock with spyOn for agent loader mocks, which is a clear refactor with maintenance benefits as it aligns with the idiomatic approach for bun:test as suggested in a PR review.
b0b19f30fix(grep): handle Windows drive-letter paths and CRLF in parseOutput -- Fixes concrete behavior issues on Windows with clear functional impact, addressing both path handling and line ending problems.
e9b6bba1refactor(agent-display): centralize name normalization resolution -- Adds new test cases for name normalization and refactors the logic to centralize resolution, improving maintainability and functionality with clear user value.
f95e7a6crefactor(openclaw): reuse shared gateway url validation -- The commit refactors the code to reuse a shared gateway URL validation function, reducing duplication and improving maintainability with clear value.
40411f32docs(agents): add AGENTS.md documentation for prometheus, hephaestus, sisyphus variants, and builtin-skills -- Added substantial documentation for multiple agents and built-in skills with clear structure and purpose.
21822ba2test(openclaw): cover shared gateway url validation -- Adds meaningful test coverage for gateway URL validation scenarios, including HTTPS, local HTTP, and invalid URLs, with clear expected outcomes.
a2ae3de3refactor(openclaw): extract gateway url validator -- Extracts a reusable gateway URL validation function, reducing code duplication and improving maintainability with clear functional benefit.
69f1c9aefix(doctor): add timeouts to subprocess spawns to prevent exit code 137 -- Adds timeouts to subprocess spawns to prevent hanging processes and SIGKILL (exit code 137), introducing a spawnWithTimeout utility and overall doctor command timeout with clear functional benefit.
314e1a5efix(telemetry): enable GeoIP resolution for PostHog events -- Explicitly enables GeoIP resolution for PostHog events by setting disableGeoip to false, adding clear functional value for geographic analytics.
d21ed3f7fix(doctor): add timeouts to subprocess spawns to prevent exit code 137 -- Adds timeouts to prevent subprocess hangs and SIGKILL (exit code 137), introducing a spawnWithTimeout utility and overall doctor command timeout with clear functional benefit.
565d3ffafix(ci): build darwin binaries on macOS runners to restore code signing -- The commit fixes a concrete CI issue by routing darwin platforms to macOS runners for native compilation and adds an explicit ad-hoc codesign step to restore code signing, directly addressing a functional problem (macOS Gatekeeper rejection).
71b5ab67fix(ci): replace breaking codesign step with signature verification -- The commit replaces a breaking codesign step in CI with a signature verification, addressing a concrete functional issue (invalid signature format) by leveraging the native macOS build's valid ad-hoc signature.
16e7fa5bfix(ci): ad-hoc sign darwin binaries with plain codesign -- The commit fixes a concrete CI issue by explicitly signing Darwin binaries with 'codesign --sign -' to address a functional problem (lack of ad-hoc signing on GitHub macOS runners).
470ed8b1fix(ci): remove existing signature before ad-hoc signing darwin binary -- The commit fixes a concrete CI issue by removing an existing malformed signature before applying a fresh ad-hoc signature to Darwin binaries, directly addressing a functional problem.
2d65896brefactor(shared): simplify normalize SDK null guards -- Simplifies null checks in normalizeSDKResponse from multiple conditions to a single '== null' check, improving readability without changing behavior.
79a475d6refactor(background-agent): simplify loop detector null guard -- Simplifies null checks in a function without changing behavior, improving readability.
50df6f0dtest(claude-code-plugin-loader): cover plugin path nullish resolution -- Adds meaningful test coverage for plugin path resolution, including nullish input handling.
668bc8e8refactor(config-manager): simplify config parsing guards -- Simplifies redundant conditional logic in config parsing without changing behavior and adds meaningful test coverage for config file parsing scenarios.
a0d5131erefactor(plugin): remove dead chat params code -- Removes dead code (unused 'variant' variable and related logic) in chat-params.ts, simplifying the buildChatParamsInput function without affecting functionality.
4de02094test(background-agent): lock nullish loop detector behavior -- Adds meaningful test coverage for nullish input handling in loop detector behavior, ensuring consistent handling of null and undefined inputs.
141798efrefactor(background-agent): standardize loop detector null guards -- Simplifies null checks in two functions without changing behavior, improving readability and consistency.
c750781bfix(shared): avoid false-positive skill path resolution on npm scoped packages ([Bug]: Why my command run with error path? code-yeongyu/oh-my-openagent#2857) -- Fixes a concrete behavior issue by adjusting a regex to exclude npm scoped package references, preventing false positives in skill path resolution, with a clear test case added.
3d2eb6e4fix(config): preserve explicit git_master overrides during merge -- Adds explicit tests and logic to preserve user git_master config overrides, addressing a concrete behavior issue with clear test coverage.
dac0c99efeat: add Vercel AI Gateway as a provider -- Adds Vercel AI Gateway as a recognized provider with clear integration across multiple files and test updates, providing real user value.
aac17135test: add vercel provider transform tests -- Adds multiple meaningful tests for Vercel provider transformations with clear expected outputs, covering various model types and edge cases.
6f72ec75test: add integration tests for Vercel AI Gateway model resolution -- Adds integration tests for Vercel AI Gateway model resolution with clear test cases and snapshot updates, providing meaningful test coverage for a real scenario.
542dc890fix(provider): use gateway-specific model IDs for vercel transform -- Fixes model ID transformation for Vercel AI Gateway by removing '-preview' suffix, aligning with gateway's requirements, and updates tests accordingly.
34e334eafeat(provider): add vercel to all gateway-supported fallback entries -- Adds vercel to all gateway-supported fallback entries with clear user value and meaningful test updates.
effae16crefactor(provider): replace per-model string replacements with generic regex -- Replaced multiple per-model string replacements with a generic regex, simplifying the code and making it more maintainable and scalable for new models.
680d05a2Prometheus: keep planner primary-only -- The commit changes Prometheus's mode from 'all' to 'primary' across multiple test files and the config builder, aligning with the stated goal of keeping the planner primary-only, which is a clear and defensible behavior change.
e3b5c2befix: address review feedback for Vercel AI Gateway PR -- Adds Vercel AI Gateway integration with CLI option, priority adjustment, and test updates, providing clear user value and functionality.
01a1b141fix(delegate-task): reject primary agents in task subagent resolution -- The commit introduces a clear behavior change by rejecting primary agents in task subagent resolution, with multiple new functions and logic updates that directly address the issue.
3673b962docs(readme-ru): add telemetry and legal section translation -- Added meaningful Russian translations for telemetry and legal sections in README.ru.md with clear user value and links to relevant policies.
23d0a0dcdocs(readme-zh-cn): add telemetry and legal section translation -- Added meaningful Chinese translations for telemetry and legal sections in README.zh-cn.md with clear user value and links to relevant policies.
0ece66e3docs(readme-ja): add telemetry and legal section translation -- Added meaningful Japanese translations for telemetry and legal sections in README.ja.md with clear user value and links to relevant policies.
12ed9501docs(readme-ko): add telemetry and legal section translation -- Added meaningful Korean translations for telemetry and legal sections in README.ko.md with clear user value and links to relevant policies.
c91db2ebdocs(cli): add --vercel-ai-gateway flag documentation -- Added documentation for a new CLI flag with clear description and default value, providing user value.
e223ab20docs(configuration): add sisyphus-junior to agent list -- Added a new agent 'sisyphus-junior' to the documented list of available agents in the configuration guide, providing clear user value by informing users of an additional option.
9342e55bdocs(installation): replace npx with bunx and update provider flags -- Updated installation docs to reflect 'bunx' instead of 'npx' and added new provider flags with clear explanations.
05e54444docs(overview): update model-role claims and complete category list -- The commit updates the documentation to include a complete and expanded category list for model roles, providing clearer information for users on how tasks are routed to specific models based on intent.
7c94ee45docs(agent-model-matching): sync fallback chains with current source -- Updated fallback chains in documentation to match current source of truth in src/shared/model-requirements.ts, providing accurate and necessary information for users.
bbbd1bd0docs(orchestration): update diagram model names and category tables -- The commit updates documentation with new, specific, and informative content (e.g., model fallback chains, category tables) that clearly enhances user understanding and utility.
4ce1dde3CLI: isolate provider model id transforms from shared mocks -- Added meaningful tests for model ID transformations across multiple providers with clear expected outputs.
1b36194bfix(cli): treat missing session status as idle in run completion -- Added test case for treating missing session status as idle, ensuring pollForCompletion handles this edge case correctly.
b5250555fix(telemetry): guard PostHog init failures -- Adds meaningful test coverage for PostHog init failure scenarios, ensuring no-throw behavior for clients.
62c60ae9fix: numeric skill names, ultrawork missing run_in_background, ZWSP agent lookups -- The commit fixes concrete bugs and improves functionality, such as coercing numeric skill names to strings, adding a required parameter to task examples, and stripping ZWSP from agent names for accurate lookups.
76c5356atest(agent-config): add regression tests for agent merge priority order -- Adds meaningful regression tests for agent merge priority order with clear test cases and expected outcomes.
da91c535fix(call-omo-agent): address cubic review findings and add requirement-based tests -- The commit fixes concrete issues, adds requirement-based tests, and improves functionality with clear value.
1e85a88dfix(agent-restrictions): restore EXPLORATION_AGENT_DENYLIST as default fallback for unknown agents -- Restores a default fallback for unknown agents, fixing a functional gap in agent restrictions.
fd28f7e6feat(agents): add agent_definitions schema, eager path resolution, and JSON agent loader -- Adds agent_definitions schema, eager path resolution, and JSON agent loader with clear functional value and comprehensive test suite.
5755a90cfeat(agents): add agent definitions file loader and opencode.json reader -- Adds agent definitions loader with comprehensive test coverage and clear functional value
39bda91bfeat(agents): wire agent_definitions and opencode.json agents into precedence chain -- The commit integrates agent_definitions and opencode.json agents into the precedence chain with clear functional value, adding new capabilities, detailed logging, and filtering logic, backed by 7 new integration tests.
3d0fb22cfix(call-omo-agent): adapt dev's model override tests to use createMockCtx factory -- The commit fixes a concrete compatibility issue by adapting tests to use a new factory function, ensuring test validity after a code change.
42445f51fix(agents): address cubic review findings on agent loader -- Fixes concrete issues in agent loading, including case-insensitive file extension handling, correct path resolution, and precedence logic, with clear functional improvements and new tests.
cf4b2315fix(agents): replace 'in' with Object.hasOwn() for prototype-safe property checks -- Replaced 'in' with Object.hasOwn() for prototype-safe property checks in opencode-config-agents-reader.ts to avoid skipping valid agent names that match inherited properties.
4c77045cfix(agents): use null-prototype accumulator to prevent proto pollution -- The commit fixes a concrete security issue by using a null-prototype accumulator to prevent proto pollution, with a clear explanation and targeted code change.
ab11f2ebfix(tests): replace mock.module with spyOn to prevent test pollution -- Replaced mock.module() with spyOn() to prevent test state pollution, ensuring downstream tests run cleanly.
47aa3025fix(cli): use getAgentRuntimeName for agent resolution in run command -- The commit fixes a concrete behavior issue by using getAgentRuntimeName for agent resolution in the run command, with clear functional improvements and updated tests.
0764526afix(posthog): disable exception autocapture to stay within free tier -- Disables exception autocapture to stay within PostHog's free tier limit, preserving manual capture for critical errors.
a1842f2dfeat(tool-metadata): add shared metadata contract and bridge -- Adds a shared metadata contract and bridge with meaningful tests covering various scenarios, including round-trip persistence, casing insensitivity, and edge cases like missing or blank call IDs.
80d3339cfeat(background-agent): add wait-for-task-session helper -- Adds a waitForTaskSessionID helper with meaningful tests covering immediate resolution, polling, abort signals, and timeouts, providing clear functional value for task session management.
4da30057fix(plugin): harden metadata recovery and extraction -- The commit introduces meaningful functionality to extract session IDs from metadata, including legacy aliases, with clear tests and functional improvements across multiple hooks.
c6a407c4refactor(tools): migrate producers to shared metadata bridge -- The commit migrates producers to a shared metadata bridge, replacing storeToolMetadata with publishToolMetadata across multiple files, indicating a meaningful refactor with clear architectural benefit.
Branch: sync/upstream/v3.17.4-good (local only; not on origin)
⚠️ 6 commit(s) failed to cherry-pick and are NOT in the draft PR.
🚫 Push to origin was rejected. GITHUB_TOKEN cannot create or modify files under .github/workflows/. The batch branch exists only in the workflow runner and was discarded. To merge this batch, run the analyzer with a PAT that has the workflow scope, or cherry-pick locally.
📝 4 commit(s) touch .github/workflows/ and require elevated permissions to sync: 565d3ff, 71b5ab6, 16e7fa5, 470ed8b
🟡 Review batch
Ambiguous. Human should review before merging.
cd8352c1refactor(claude-code-mcp-loader): simplify env expansion null guard -- Classification failed: No object generated: response did not match schema.
569addd3docs(provider): add comments to vercel transform logic -- Classification failed: No object generated: response did not match schema.
Branch: sync/upstream/v3.17.4-needs-review (on origin)
⚠️ 1 commit(s) failed to cherry-pick and are NOT in the draft PR.
🔴 Slop batch
Classified as AI slop or pointless churn. Do not merge as-is; rewrite intent if salvageable.
1e2e0019refactor(create-tools): keep result type internal -- The commit changes the visibility of CreateToolsResult from export to internal without any clear functional or architectural benefit, indicating minor visibility churn.
9d89bbb0refactor(commands): keep builtin command options internal -- Changes the visibility of LoadBuiltinCommandsOptions from export to internal without clear functional or architectural benefit, indicating minor visibility churn.
0c5cd3a1chore(agents): update all AGENTS.md generation dates to 2026-04-11 -- The commit updates generation dates in multiple AGENTS.md files without adding new functionality or value beyond metadata churn.
6713b30crefactor(hooks): drop no-op directory injector callbacks -- Removed no-op callbacks without adding new functionality or improving existing code structure in a meaningful way.
21cad26cdocs(config): remove redundant schema default comments -- Removed redundant schema default comments, which is a minor documentation change with no functional impact or added clarity.
678011c7docs(contributing): update tool/hook counts and version references -- The commit updates counts and version references in the documentation without adding new information or functionality.
cfd152addocs(features): update agent count and verify category list -- Added two new agents with overly verbose, generic descriptions lacking concrete examples or clear user value beyond buzzwords.
0cb0a6c0docs(contributing): update tool/hook counts and version references -- Updated counts and version references in docs without adding new information or functionality.
9aeb87c2chore: bump version to 3.17.3 -- The commit only updates the version number in package.json, which is administrative noise with no code or product value.
fe091ef2chore: bump version to 3.17.4 -- The commit only updates the version number in package.json, which is administrative noise with no code or product value.
c9350c67release: v3.17.4 -- The commit only updates version numbers in multiple package.json files, which is administrative noise with no code or product value.
Branch: sync/upstream/v3.17.4-slop (on origin)
Slop verifier second-pass notes
1e2e001 CONFIRMED_SLOP (behavior delta: none): The commit changes the visibility of CreateToolsResult from export to internal without any clear functional or architectural benefit. This is classified as minor visibility churn, which is a documented slop pattern. There's no concrete behavior delta, and the commit message lacks justification for the change. A senior engineer would likely question the value of this change without further context.
9d89bbb CONFIRMED_SLOP (behavior delta: none): The commit changes the visibility of LoadBuiltinCommandsOptions from export to internal without clear functional or architectural benefit, indicating minor visibility churn. There's no concrete behavior delta, and the commit message lacks justification for the change. A senior engineer would likely question the value of this refactor without additional context or future plans. The first-pass verdict correctly identifies this as minor_visibility_churn with no apparent value addition.
0c5cd3a CONFIRMED_SLOP (behavior delta: none): The commit updates generation dates in multiple AGENTS.md files without adding new functionality or value beyond metadata churn. This aligns with documented slop patterns for date updates and metadata-only doc edits. There is no concrete behavior delta, and the changes do not introduce new functionality or improve existing code in a measurable way.
e654cfb CONFIRMED_SLOP (behavior delta: none): The commit only adds a CLA signature to cla.json, which is administrative noise with no code or product value. The first-pass reason correctly identifies it as cla_admin, a category excluded from being demoted to GOOD by the verification bias. There is no concrete behavior delta, and the change does not introduce any new functionality or improvements to the codebase.
6713b30 CONFIRMED_SLOP (behavior delta: none): The commit removes no-op callbacks without adding new functionality or improving existing code structure in a meaningful way. The changes are purely refactor_churn with no concrete behavior delta, no new abstractions with multiple callers, and the commit message accurately reflects the removal but lacks measurable value. A senior engineer would likely question the necessity of this change without additional context or future plans.
21cad26 CONFIRMED_SLOP (behavior delta: none): The commit removes redundant schema default comments, which is a minor documentation change with no functional impact or added clarity. The first-pass reason correctly identifies this as docs_churn with high confidence. No concrete behavior delta exists, and the change does not strengthen or weaken any invariants. The commit message accurately reflects the change but does not provide measurable value beyond churn.
6a0d515 CONFIRMED_SLOP (behavior delta: none): The commit only adds a CLA signature to cla.json, which is administrative noise with no code or product value. This aligns with the 'cla_admin' category, which is explicitly non-mergable as per the verification bias rules.
5b33cd2 CONFIRMED_SLOP (behavior delta: none): The commit only adds a CLA signature to cla.json, which is administrative noise with no code or product value. This aligns with the 'cla_admin' slop signal and does not provide any concrete behavior delta or value to the codebase.
c6deb6d CONFIRMED_SLOP (behavior delta: none): The commit only adds a CLA signature to cla.json, which is administrative noise with no code or product value. The change does not affect any runtime behavior, user-visible output, or invariants. It aligns with the 'cla_admin' category, which is explicitly non-GOOD by the verification bias rules.
42df1c3 CONFIRMED_SLOP (behavior delta: none): The commit adds only a CLA signature to cla.json, which is administrative noise without code or product value. The first-pass reason correctly identifies it as cla_admin, a category excluded from being demoted to GOOD by the verification bias. No behavior delta exists as it doesn't alter runtime code or user-visible output.
84f980c CONFIRMED_SLOP (behavior delta: none): The commit only adds a CLA signature to cla.json, which is administrative noise with no code or product value. This aligns with the 'cla_admin' slop signal and does not provide any concrete behavior delta or value to the codebase.
678011c CONFIRMED_SLOP (behavior delta: none): The commit updates counts and version references in documentation without adding new functionality or substantial information. These changes are classified as metadata-only doc edits, which are considered SLOP. No concrete behavior delta exists as the updates do not alter runtime code paths or user-visible outputs. The commit message accurately reflects the changes but lacks measurable value beyond maintaining accuracy of counts and versions.
cfd152a CONFIRMED_SLOP (behavior delta: none): The commit adds two new agents with overly verbose, generic descriptions lacking concrete examples or clear user value beyond buzzwords. The commit message uses vague improvement language without measurable delta, and the changes expand existing docs without new facts. No concrete behavior delta is introduced, and the additions do not demonstrate clear growth paths or measurable benefits.
0cb0a6c CONFIRMED_SLOP (behavior delta: none): The commit updates counts and version references in documentation without adding new information or functionality. These changes are classified as metadata churn, which is considered SLOP under the given rubric. No concrete behavior delta exists, and the update does not introduce new value beyond bookkeeping.
3419bbc CONFIRMED_SLOP (behavior delta: none): The commit only adds a CLA signature to cla.json, which is administrative noise with no code or product value. This matches the 'cla_admin' category, which is explicitly excluded from being demoted to GOOD. No behavior delta exists as it's purely administrative.
1bb59c3 CONFIRMED_SLOP (behavior delta: none): The commit is a release version bump with no code changes, only updating version numbers in multiple package.json files. This matches the 'release_version_bump' slop pattern, and according to the verification bias, such commits should not be demoted to GOOD. There is no concrete behavior delta, and the change is purely administrative.
571cf1f CONFIRMED_SLOP (behavior delta: none): The commit only adds a CLA signature to cla.json, which is administrative noise with no code or product value. This aligns with the 'cla_admin' category, which is explicitly non-GOOD by the verification bias rules.
f98f7ec CONFIRMED_SLOP (behavior delta: none): The commit adds a CLA signature to cla.json, which is purely administrative and does not introduce any code or product value. This aligns with the 'cla_admin' slop signal, and there's no concrete behavior delta or value addition.
d97c067 CONFIRMED_SLOP (behavior delta: none): The commit only adds a CLA signature to cla.json, which is administrative noise with no code or product value. This aligns with the 'cla_admin' category, which is explicitly non-mergable as per the verification bias rules.
eaf5ff2 CONFIRMED_SLOP (behavior delta: none): The commit only adds a CLA signature to cla.json, which is administrative noise with no code or product value. The first-pass reason correctly identifies this as cla_admin, a category excluded from being demoted to GOOD by the verification bias. There is no concrete behavior delta, and the change does not introduce any new functionality or fix an issue.
f8f7ac1 CONFIRMED_SLOP (behavior delta: none): The commit only adds a CLA signature to cla.json, which is administrative noise with no code or product value. This matches the documented slop pattern for cla_admin. There is no concrete behavior delta, and the change does not strengthen or weaken any invariant. A senior engineer would likely not defend this as a valuable change in a code review focused on merge value.
54a94d4 CONFIRMED_SLOP (behavior delta: none): The commit only adds a CLA signature to cla.json, which is administrative noise with no code or product value. This aligns with the 'cla_admin' slop signal and does not provide any concrete behavior delta or value to the project's functionality.
81a03fa CONFIRMED_SLOP (behavior delta: none): The commit only adds a CLA signature to cla.json, which is administrative noise with no code or product value. This aligns with the 'cla_admin' slop signal and does not provide any concrete behavior delta, abstraction value, or measurable improvement. The commit message accurately reflects the change but does not justify merge value under the fork's rubric.
9aeb87c CONFIRMED_SLOP (behavior delta: none): The commit only updates the version number in package.json, which is classified as release_version_bump, a category explicitly marked as SLOP by the guidelines. There is no code change, behavior delta, or product value added beyond administrative metadata update. The first-pass verdict correctly identifies this as SLOP with high confidence.
80e73f5 CONFIRMED_SLOP (behavior delta: none): The commit only adds a CLA signature to cla.json, which is administrative noise with no code or product value. The change does not affect any runtime behavior, user-visible output, or invariants. It falls under 'cla_admin', a category excluded from being demoted to GOOD by the verification bias. No concrete benefit or behavior delta exists to justify demotion.
fe091ef CONFIRMED_SLOP (behavior delta: none): The commit only updates the version number in package.json, which is classified as release_version_bump, a documented slop pattern. There is no concrete behavior delta, no new functionality, and the change is purely administrative. The first-pass verdict correctly identifies this as administrative noise with no merge value for the fork.
c9350c6 CONFIRMED_SLOP (behavior delta: none): The commit only updates version numbers in multiple package.json files, which is administrative noise with no code or product value. This matches the 'release_version_bump' category, which is explicitly non-GOOD by the provided rubric.
Fork-sync impact assessment
Breaking changes
(none detected)
Dependency changes
(none)
Architecture drift
(none)
Hidden concerns
Verify refactors for hidden churn (e.g., multiple small AGENTS.md updates)
Review CLA signature commits for necessity in merge
Action items before merging
Manually review GOOD refactor commits for subtle issues
Confirm no dependency version conflicts with fork's setup
Test key functional fixes (e.g., Windows path handling, doctor command timeouts)
Generated by upstream-analyzer workflow. This issue is advisory: no merges or publishes happen automatically. Phase 1: draft PRs only. The prompt lives in .github/prompts/ and is editable without touching workflow code.
🟡 Upstream cost-benefit: v3.17.0 → v3.17.4
Upstream:
code-yeongyu/oh-my-openagentRecommendation:
CHERRY_PICK(confidence: medium)Slop ratio: 23%
The release from v3.17.0 to v3.17.4 contains a significant number of GOOD commits (87) with clear functional value, including bug fixes, refactors, and documentation improvements. However, the presence of 27 SLOP commits (slop ratio ~23%) and several administrative noise commits (e.g., CLA signatures) suggests a mixed release. While the GOOD commits are substantial, the slop and noise indicate a need for selective merging to exclude non-value-added changes. No critical breaking changes or dependency conflicts were identified that would necessitate skipping or holding for human review, but careful review of the GOOD batch for hidden slop is advised.
Batch classification
sync/upstream/v3.17.4-goodsync/upstream/v3.17.4-needs-reviewsync/upstream/v3.17.4-slop🟢 Good batch
Classified as real value. Candidate for merge.
ad85e438fix: include user/project agents in task(subagent_type) resolution -- Adds meaningful functionality with clear user value and new test cases covering various scenarios.2266f28ffix: correct merge order so project agents override user agents -- The commit fixes a specific behavior issue (merge order of project vs user agents) with clear functional impact, backed by a new test case.64408823fix: actually swap merge order so project is added before user -- The commit fixes a specific behavior issue (merge order of project vs user agents) with clear functional impact, backed by a new test case.5441c848refactor: use spyOn instead of vi.mock for agent loader mocks -- The commit replacesvi.mockwithspyOnfor agent loader mocks, which is a clear refactor with maintenance benefits as it aligns with the idiomatic approach forbun:testas suggested in a PR review.b0b19f30fix(grep): handle Windows drive-letter paths and CRLF in parseOutput -- Fixes concrete behavior issues on Windows with clear functional impact, addressing both path handling and line ending problems.e9b6bba1refactor(agent-display): centralize name normalization resolution -- Adds new test cases for name normalization and refactors the logic to centralize resolution, improving maintainability and functionality with clear user value.f95e7a6crefactor(openclaw): reuse shared gateway url validation -- The commit refactors the code to reuse a shared gateway URL validation function, reducing duplication and improving maintainability with clear value.40411f32docs(agents): add AGENTS.md documentation for prometheus, hephaestus, sisyphus variants, and builtin-skills -- Added substantial documentation for multiple agents and built-in skills with clear structure and purpose.21822ba2test(openclaw): cover shared gateway url validation -- Adds meaningful test coverage for gateway URL validation scenarios, including HTTPS, local HTTP, and invalid URLs, with clear expected outcomes.a2ae3de3refactor(openclaw): extract gateway url validator -- Extracts a reusable gateway URL validation function, reducing code duplication and improving maintainability with clear functional benefit.69f1c9aefix(doctor): add timeouts to subprocess spawns to prevent exit code 137 -- Adds timeouts to subprocess spawns to prevent hanging processes and SIGKILL (exit code 137), introducing a spawnWithTimeout utility and overall doctor command timeout with clear functional benefit.314e1a5efix(telemetry): enable GeoIP resolution for PostHog events -- Explicitly enables GeoIP resolution for PostHog events by setting disableGeoip to false, adding clear functional value for geographic analytics.d21ed3f7fix(doctor): add timeouts to subprocess spawns to prevent exit code 137 -- Adds timeouts to prevent subprocess hangs and SIGKILL (exit code 137), introducing a spawnWithTimeout utility and overall doctor command timeout with clear functional benefit.565d3ffafix(ci): build darwin binaries on macOS runners to restore code signing -- The commit fixes a concrete CI issue by routing darwin platforms to macOS runners for native compilation and adds an explicit ad-hoc codesign step to restore code signing, directly addressing a functional problem (macOS Gatekeeper rejection).71b5ab67fix(ci): replace breaking codesign step with signature verification -- The commit replaces a breaking codesign step in CI with a signature verification, addressing a concrete functional issue (invalid signature format) by leveraging the native macOS build's valid ad-hoc signature.16e7fa5bfix(ci): ad-hoc sign darwin binaries with plain codesign -- The commit fixes a concrete CI issue by explicitly signing Darwin binaries with 'codesign --sign -' to address a functional problem (lack of ad-hoc signing on GitHub macOS runners).470ed8b1fix(ci): remove existing signature before ad-hoc signing darwin binary -- The commit fixes a concrete CI issue by removing an existing malformed signature before applying a fresh ad-hoc signature to Darwin binaries, directly addressing a functional problem.2d65896brefactor(shared): simplify normalize SDK null guards -- Simplifies null checks in normalizeSDKResponse from multiple conditions to a single '== null' check, improving readability without changing behavior.79a475d6refactor(background-agent): simplify loop detector null guard -- Simplifies null checks in a function without changing behavior, improving readability.50df6f0dtest(claude-code-plugin-loader): cover plugin path nullish resolution -- Adds meaningful test coverage for plugin path resolution, including nullish input handling.668bc8e8refactor(config-manager): simplify config parsing guards -- Simplifies redundant conditional logic in config parsing without changing behavior and adds meaningful test coverage for config file parsing scenarios.a0d5131erefactor(plugin): remove dead chat params code -- Removes dead code (unused 'variant' variable and related logic) in chat-params.ts, simplifying the buildChatParamsInput function without affecting functionality.4de02094test(background-agent): lock nullish loop detector behavior -- Adds meaningful test coverage for nullish input handling in loop detector behavior, ensuring consistent handling of null and undefined inputs.141798efrefactor(background-agent): standardize loop detector null guards -- Simplifies null checks in two functions without changing behavior, improving readability and consistency.e71c34acfix(migration): return true when canonical config write succeeds regardless of archive status ([Bug]: v3.15.1 still inconsistently loads/migrates plugin config after rename code-yeongyu/oh-my-openagent#3133) -- Fixes a concrete behavior issue where migration incorrectly returned false when the canonical config write succeeded, despite archive failure.7accb53cfix(shared): handle Windows rename-over-existing in write-file-atomically ([Bug]: Using oh-my-opencode via bunx causes a new oh-my-openagent.json.bak.* backup file to be created on every OpenCode startup, even when no config changes were made. code-yeongyu/oh-my-openagent#3222) -- Fixes a concrete behavior issue on Windows by handling rename-over-existing errors with a fallback strategy, adding meaningful test coverage for the scenario.9ef133a8fix(migration): register parenthesized legacy agent aliases in AGENT_NAME_MAP ([Bug]: Header 'x-opencode-agent-name' has invalid value: 'Atlas (Plan Executor)' code-yeongyu/oh-my-openagent#3281) -- Adds concrete mappings for legacy agent aliases and tests for migration correctness, addressing a specific compatibility issue.a6e4f211fix(shared): normalize claude model IDs for anthropic provider (transformModelForProvider missing anthropic provider — dash-format model IDs rejected by OpenCode code-yeongyu/oh-my-openagent#3290) -- Fixes a concrete behavior issue by normalizing model IDs for Anthropic API compatibility, with clear test expectation updates.4f02ace7fix(shared): guard maxOutputTokens <= 0 in model settings compatibility ([Bug]: Invalid argument for parameter maxOutputTokens: maxOutputTokens must be >= 1 code-yeongyu/oh-my-openagent#3305) -- Fixes a concrete behavior issue by adding a guard to ignore invalid maxOutputTokens metadata, preserving user-requested maxTokens with clear test coverage.c750781bfix(shared): avoid false-positive skill path resolution on npm scoped packages ([Bug]: Why my command run with error path? code-yeongyu/oh-my-openagent#2857) -- Fixes a concrete behavior issue by adjusting a regex to exclude npm scoped package references, preventing false positives in skill path resolution, with a clear test case added.d7b4bec5fix(hooks,tools): replace /plan example with prometheus delegation and rename code-review example to review-work (Error message references non-existent /plan command code-yeongyu/oh-my-openagent#2633, [Bug]: Skill tool schema uses non-existent "code-review" as example instead of actual "review-work" skill code-yeongyu/oh-my-openagent#3285, [Bug]: oh-my-openagent overrides built-in tools to bypass the permission system. code-yeongyu/oh-my-openagent#2873) -- The commit fixes a concrete behavior issue by replacing a non-existent command reference with a valid Prometheus agent reference, and renames a non-existent skill to an actual built-in skill, with clear test coverage added.7e96af5ffix(atlas): exclude node_modules from verification git diff --stat ([Feature]: Ensure gitignore is created before starting implementation code-yeongyu/oh-my-openagent#3215) -- The commit fixes a concrete behavior issue by excluding node_modules from git diff verification, improving the accuracy of the reminder templates.2d8b4a9dfix(anthropic-effort): skip effort injection for github-copilot provider ([Bug]: code-yeongyu/oh-my-openagent#3270) -- Explicit guard added to skip effort injection for github-copilot provider, preserving native Anthropic support, with clear test addition.796a646cfix(non-interactive-env): use detectShellType instead of hardcoded win32 check ([Bug]: Force PowerShell env behavior in Windows code-yeongyu/oh-my-openagent#3310, Bug: PowerShell env var syntax ($env:VAR) used in bash shell on Windows code-yeongyu/oh-my-openagent#3338) -- The commit replaces a hardcoded win32 check with detectShellType(), improving shell detection for various Windows environments (Git Bash, WSL, native PowerShell) through updated tests.64e55936fix(multimodal-looker): instruct explicit Read tool usage for PDFs (Multimodal-Looker Cannot Read PDF Files code-yeongyu/oh-my-openagent#2998) -- Explicit instruction added to ensure PDFs are loaded via the Read tool before extraction, addressing a concrete behavior gap.d8b9bf1afix(doctor): check comment-checker lazy-download cache path ([Question]: comment-checker not found code-yeongyu/oh-my-openagent#2911, [Bug] comment-checker hook does not trigger code-yeongyu/oh-my-openagent#3315) -- Fixes a concrete behavior issue by aligning the doctor's resolution order with runtime, ensuring cached binaries are recognized as installed, with clear test coverage added.3bfa3bd6fix(background-agent): pass query directory to session.get in 4 call-sites ([Bug]: resolveSubagentSpawnContext fails to find project-scoped sessions — client.session.get() missing directory parameter code-yeongyu/oh-my-openagent#2937) -- Fixes a concrete behavior issue by passing the query directory to session.get in multiple call-sites, resolving 404 errors under newer OpenCode SDK versions, with clear test coverage added.eb495793fix(event): prefer real session.idle over recent synthetic dedup ([Bug]: The model has responded normally, but there is a red alert in the input box: [TODO-DIAG] BLOCKED: no todossession.idle event code-yeongyu/oh-my-openagent#2667) -- The commit fixes a concrete behavior issue by adjusting the deduplication logic to prioritize real session.idle events over synthetic ones, with clear test case updates.aed8dbfafix(delegate-task): fetch session result before honoring abort signal ([Bug]: @explore subagent completes but parent never returns result; 3.12.3 aborts with "The operation was aborted." code-yeongyu/oh-my-openagent#2702) -- Fixes a concrete behavior issue by fetching session results before honoring abort signals, with clear test coverage added.c5c5bc36fix(delegate-task): consume fallback chain on sendSyncPrompt failure (delegate-task: No automatic retry with fallback models when subagent fails due to model error code-yeongyu/oh-my-openagent#2691) -- The commit fixes a concrete behavior issue by implementing a retry mechanism with a fallback chain for failed sendSyncPrompt calls, ensuring robustness in model fallback handling.3d2eb6e4fix(config): preserve explicit git_master overrides during merge -- Adds explicit tests and logic to preserve user git_master config overrides, addressing a concrete behavior issue with clear test coverage.dac0c99efeat: add Vercel AI Gateway as a provider -- Adds Vercel AI Gateway as a recognized provider with clear integration across multiple files and test updates, providing real user value.aac17135test: add vercel provider transform tests -- Adds multiple meaningful tests for Vercel provider transformations with clear expected outputs, covering various model types and edge cases.6f72ec75test: add integration tests for Vercel AI Gateway model resolution -- Adds integration tests for Vercel AI Gateway model resolution with clear test cases and snapshot updates, providing meaningful test coverage for a real scenario.542dc890fix(provider): use gateway-specific model IDs for vercel transform -- Fixes model ID transformation for Vercel AI Gateway by removing '-preview' suffix, aligning with gateway's requirements, and updates tests accordingly.34e334eafeat(provider): add vercel to all gateway-supported fallback entries -- Adds vercel to all gateway-supported fallback entries with clear user value and meaningful test updates.effae16crefactor(provider): replace per-model string replacements with generic regex -- Replaced multiple per-model string replacements with a generic regex, simplifying the code and making it more maintainable and scalable for new models.680d05a2Prometheus: keep planner primary-only -- The commit changes Prometheus's mode from 'all' to 'primary' across multiple test files and the config builder, aligning with the stated goal of keeping the planner primary-only, which is a clear and defensible behavior change.e3b5c2befix: address review feedback for Vercel AI Gateway PR -- Adds Vercel AI Gateway integration with CLI option, priority adjustment, and test updates, providing clear user value and functionality.01a1b141fix(delegate-task): reject primary agents in task subagent resolution -- The commit introduces a clear behavior change by rejecting primary agents in task subagent resolution, with multiple new functions and logic updates that directly address the issue.3673b962docs(readme-ru): add telemetry and legal section translation -- Added meaningful Russian translations for telemetry and legal sections in README.ru.md with clear user value and links to relevant policies.23d0a0dcdocs(readme-zh-cn): add telemetry and legal section translation -- Added meaningful Chinese translations for telemetry and legal sections in README.zh-cn.md with clear user value and links to relevant policies.0ece66e3docs(readme-ja): add telemetry and legal section translation -- Added meaningful Japanese translations for telemetry and legal sections in README.ja.md with clear user value and links to relevant policies.12ed9501docs(readme-ko): add telemetry and legal section translation -- Added meaningful Korean translations for telemetry and legal sections in README.ko.md with clear user value and links to relevant policies.c91db2ebdocs(cli): add --vercel-ai-gateway flag documentation -- Added documentation for a new CLI flag with clear description and default value, providing user value.e223ab20docs(configuration): add sisyphus-junior to agent list -- Added a new agent 'sisyphus-junior' to the documented list of available agents in the configuration guide, providing clear user value by informing users of an additional option.9342e55bdocs(installation): replace npx with bunx and update provider flags -- Updated installation docs to reflect 'bunx' instead of 'npx' and added new provider flags with clear explanations.05e54444docs(overview): update model-role claims and complete category list -- The commit updates the documentation to include a complete and expanded category list for model roles, providing clearer information for users on how tasks are routed to specific models based on intent.7c94ee45docs(agent-model-matching): sync fallback chains with current source -- Updated fallback chains in documentation to match current source of truth in src/shared/model-requirements.ts, providing accurate and necessary information for users.b57a7975docs(ollama): verify troubleshooting steps and issue links -- Updated troubleshooting steps with verified issue links and clear documentation of a workaround for a specific issue ([Bug]: Ollama integration fails - streaming NDJSON response not parsed correctly code-yeongyu/oh-my-openagent#1124), providing tangible user value.bbbd1bd0docs(orchestration): update diagram model names and category tables -- The commit updates documentation with new, specific, and informative content (e.g., model fallback chains, category tables) that clearly enhances user understanding and utility.4ce1dde3CLI: isolate provider model id transforms from shared mocks -- Added meaningful tests for model ID transformations across multiple providers with clear expected outputs.1b36194bfix(cli): treat missing session status as idle in run completion -- Added test case for treating missing session status as idle, ensuring pollForCompletion handles this edge case correctly.b5250555fix(telemetry): guard PostHog init failures -- Adds meaningful test coverage for PostHog init failure scenarios, ensuring no-throw behavior for clients.0dab3116fix: resolve 3 bugs ([Bug]: non-interactive-env hook generates PowerShell $env: syntax on Git Bash (Windows) code-yeongyu/oh-my-openagent#3366, Agent name case change breaks Todo Continuation for historical sessions code-yeongyu/oh-my-openagent#3272, [Bug]: Using oh-my-opencode via bunx causes a new oh-my-openagent.json.bak.* backup file to be created on every OpenCode startup, even when no config changes were made. code-yeongyu/oh-my-openagent#3222) -- The commit fixes three concrete bugs with clear functional improvements, including detecting Git Bash via MSYSTEM, resolving legacy agent names, and optimizing config backups.62c60ae9fix: numeric skill names, ultrawork missing run_in_background, ZWSP agent lookups -- The commit fixes concrete bugs and improves functionality, such as coercing numeric skill names to strings, adding a required parameter to task examples, and stripping ZWSP from agent names for accurate lookups.76c5356atest(agent-config): add regression tests for agent merge priority order -- Adds meaningful regression tests for agent merge priority order with clear test cases and expected outcomes.da91c535fix(call-omo-agent): address cubic review findings and add requirement-based tests -- The commit fixes concrete issues, adds requirement-based tests, and improves functionality with clear value.1e85a88dfix(agent-restrictions): restore EXPLORATION_AGENT_DENYLIST as default fallback for unknown agents -- Restores a default fallback for unknown agents, fixing a functional gap in agent restrictions.fd28f7e6feat(agents): add agent_definitions schema, eager path resolution, and JSON agent loader -- Adds agent_definitions schema, eager path resolution, and JSON agent loader with clear functional value and comprehensive test suite.5755a90cfeat(agents): add agent definitions file loader and opencode.json reader -- Adds agent definitions loader with comprehensive test coverage and clear functional value39bda91bfeat(agents): wire agent_definitions and opencode.json agents into precedence chain -- The commit integrates agent_definitions and opencode.json agents into the precedence chain with clear functional value, adding new capabilities, detailed logging, and filtering logic, backed by 7 new integration tests.3d0fb22cfix(call-omo-agent): adapt dev's model override tests to use createMockCtx factory -- The commit fixes a concrete compatibility issue by adapting tests to use a new factory function, ensuring test validity after a code change.42445f51fix(agents): address cubic review findings on agent loader -- Fixes concrete issues in agent loading, including case-insensitive file extension handling, correct path resolution, and precedence logic, with clear functional improvements and new tests.cf4b2315fix(agents): replace 'in' with Object.hasOwn() for prototype-safe property checks -- Replaced 'in' with Object.hasOwn() for prototype-safe property checks in opencode-config-agents-reader.ts to avoid skipping valid agent names that match inherited properties.4c77045cfix(agents): use null-prototype accumulator to prevent proto pollution -- The commit fixes a concrete security issue by using a null-prototype accumulator to prevent proto pollution, with a clear explanation and targeted code change.e5d3fe96fix(agents): address all PR feat(call-omo-agent): support custom agents via dynamic resolution code-yeongyu/oh-my-openagent#2299 code review findings -- The commit addresses multiple code review findings with concrete fixes, including security patches (B2), functional improvements (B1, N2, N3), and test additions (N5), all with clear value and no apparent slop.ab11f2ebfix(tests): replace mock.module with spyOn to prevent test pollution -- Replaced mock.module() with spyOn() to prevent test state pollution, ensuring downstream tests run cleanly.e1b2f97bfix: isPlanFamily regression tests, code-review -> review-work in test data (bug: isPlanFamily() substring matching false-positives Atlas/Metis/Momus display names code-yeongyu/oh-my-openagent#3312, [Bug]: Skill tool schema uses non-existent "code-review" as example instead of actual "review-work" skill code-yeongyu/oh-my-openagent#3285, transformModelForProvider missing anthropic provider — dash-format model IDs rejected by OpenCode code-yeongyu/oh-my-openagent#3290) -- The commit fixes a regression in test data by updating 'code-review' to 'review-work' in test expectations and adds new tests to prevent false positives in isPlanFamily checks.47aa3025fix(cli): use getAgentRuntimeName for agent resolution in run command -- The commit fixes a concrete behavior issue by using getAgentRuntimeName for agent resolution in the run command, with clear functional improvements and updated tests.0764526afix(posthog): disable exception autocapture to stay within free tier -- Disables exception autocapture to stay within PostHog's free tier limit, preserving manual capture for critical errors.ccb2715afix: hide native plan agent when replace_plan is true ([Bug]: Native plan agent not hidden when replace_plan is true - Sisyphus routes to it instead of Prometheus code-yeongyu/oh-my-openagent#3443) -- The commit fixes a concrete behavior issue by hiding the native plan agent when replace_plan is true, with clear functional improvements and updated tests.a1842f2dfeat(tool-metadata): add shared metadata contract and bridge -- Adds a shared metadata contract and bridge with meaningful tests covering various scenarios, including round-trip persistence, casing insensitivity, and edge cases like missing or blank call IDs.80d3339cfeat(background-agent): add wait-for-task-session helper -- Adds awaitForTaskSessionIDhelper with meaningful tests covering immediate resolution, polling, abort signals, and timeouts, providing clear functional value for task session management.4da30057fix(plugin): harden metadata recovery and extraction -- The commit introduces meaningful functionality to extract session IDs from metadata, including legacy aliases, with clear tests and functional improvements across multiple hooks.c6a407c4refactor(tools): migrate producers to shared metadata bridge -- The commit migrates producers to a shared metadata bridge, replacingstoreToolMetadatawithpublishToolMetadataacross multiple files, indicating a meaningful refactor with clear architectural benefit.7bc170fbfix: installer writes hyphenated anthropic IDs, variant=max Anthropic OAuth compat (variant: max sends output_config which breaks Claude Pro/Max OAuth authentication code-yeongyu/oh-my-openagent#3429, [Bug]: installer generates invalid Anthropic model IDs with dotted version suffixes code-yeongyu/oh-my-openagent#3459) -- The commit fixes a concrete behavior issue by replacing dots with hyphens in Anthropic model IDs to ensure compatibility with Anthropic OAuth, as evidenced by the systematic replacement across all model references in the snapshot.Branch:
sync/upstream/v3.17.4-good(local only; not on origin)🟡 Review batch
Ambiguous. Human should review before merging.
cd8352c1refactor(claude-code-mcp-loader): simplify env expansion null guard -- Classification failed: No object generated: response did not match schema.569addd3docs(provider): add comments to vercel transform logic -- Classification failed: No object generated: response did not match schema.Branch:
sync/upstream/v3.17.4-needs-review(on origin)🔴 Slop batch
Classified as AI slop or pointless churn. Do not merge as-is; rewrite intent if salvageable.
1e2e0019refactor(create-tools): keep result type internal -- The commit changes the visibility ofCreateToolsResultfromexportto internal without any clear functional or architectural benefit, indicating minor visibility churn.9d89bbb0refactor(commands): keep builtin command options internal -- Changes the visibility of LoadBuiltinCommandsOptions from export to internal without clear functional or architectural benefit, indicating minor visibility churn.0c5cd3a1chore(agents): update all AGENTS.md generation dates to 2026-04-11 -- The commit updates generation dates in multiple AGENTS.md files without adding new functionality or value beyond metadata churn.e654cfb4@ahuangsnail has signed the CLA in fix: treat zero limit.output as unknown to enable fallback to bundled… code-yeongyu/oh-my-openagent#3316 -- The commit only adds a CLA signature to cla.json, which is administrative noise with no code or product value.6713b30crefactor(hooks): drop no-op directory injector callbacks -- Removed no-op callbacks without adding new functionality or improving existing code structure in a meaningful way.21cad26cdocs(config): remove redundant schema default comments -- Removed redundant schema default comments, which is a minor documentation change with no functional impact or added clarity.6a0d515d@divlook has signed the CLA in fix: align GitHub Copilot model variants with catalog code-yeongyu/oh-my-openagent#3353 -- The commit only adds a CLA signature to cla.json, which is administrative noise with no code or product value.5b33cd22@lrq3000 has signed the CLA in docs(install): Update installation commands for humans in documentation to oh-my-openagent code-yeongyu/oh-my-openagent#3358 -- The commit only adds a CLA signature to cla.json, which is administrative noise with no code or product value.c6deb6d6@Zireael has signed the CLA in fix: detect Git Bash/WSL/MSYS2 shell on Windows (non-interactive-env hook) code-yeongyu/oh-my-openagent#3370 -- The commit only adds a CLA signature to cla.json, which is administrative noise with no code or product value.42df1c3c@FuDesign2008 has signed the CLA in fix(agent-key): restore getAgentDisplayName for HTTP-header-safe agent keys code-yeongyu/oh-my-openagent#3371 -- The commit only adds a CLA signature to cla.json, which is administrative noise with no code or product value.84f980c9@matchai has signed the CLA in feat(provider): add Vercel AI Gateway support code-yeongyu/oh-my-openagent#3376 -- The commit only adds a CLA signature to cla.json, which is administrative noise with no code or product value.678011c7docs(contributing): update tool/hook counts and version references -- The commit updates counts and version references in the documentation without adding new information or functionality.cfd152addocs(features): update agent count and verify category list -- Added two new agents with overly verbose, generic descriptions lacking concrete examples or clear user value beyond buzzwords.0cb0a6c0docs(contributing): update tool/hook counts and version references -- Updated counts and version references in docs without adding new information or functionality.3419bbc4@mauriciozaffari has signed the CLA in fix: recognize 'hit your limit' as retryable error pattern code-yeongyu/oh-my-openagent#3398 -- The commit only adds a CLA signature to cla.json, which is administrative noise with no code or product value.1bb59c3erelease: v3.17.2 -- The commit is a release version bump with no code changes, only updating version numbers in multiple package.json files.571cf1f1@kywoo26 has signed the CLA in fix(background-agent): skip unavailable fallback models code-yeongyu/oh-my-openagent#3402 -- The commit only adds a CLA signature to cla.json, which is administrative noise with no code or product value.f98f7ec7@garnetlyx has signed the CLA in feat: Task ID semantics and lifecycle integrity (#3404, #3405) code-yeongyu/oh-my-openagent#3409 -- The commit only adds a CLA signature to cla.json, which is administrative noise with no code or product value.d97c067d@lightrabbit has signed the CLA in fix(skill-mcp): pass workspace directory as cwd to stdio MCP processes code-yeongyu/oh-my-openagent#3415 -- The commit only adds a CLA signature to cla.json, which is administrative noise with no code or product value.eaf5ff21@fr1sk has signed the CLA in fix(agent-display): remove ZWSP sort prefixes that truncate agent names in terminals code-yeongyu/oh-my-openagent#3419 -- The commit only adds a CLA signature to cla.json, which is administrative noise with no code or product value.f8f7ac10@grandmaster451 has signed the CLA in fix(auto-update): use semantic version comparison instead of string e… code-yeongyu/oh-my-openagent#3420 -- The commit only adds a CLA signature to cla.json, which is administrative noise with no code or product value.54a94d41@kithawk has signed the CLA in Fix primary agent model precedence code-yeongyu/oh-my-openagent#3428 -- The commit only adds a CLA signature to cla.json, which is administrative noise with no code or product value.81a03fa9@orbisai0security has signed the CLA in fix: upgrade express-rate-limit to 8.2.2, 8.1.1, 8.0.2 (CVE-2026-30827) code-yeongyu/oh-my-openagent#3440 -- The commit only adds a CLA signature to cla.json, which is administrative noise with no code or product value.9aeb87c2chore: bump version to 3.17.3 -- The commit only updates the version number in package.json, which is administrative noise with no code or product value.80e73f57@CHLK has signed the CLA in fix(cli-run): prevent premature exit when background tasks are active code-yeongyu/oh-my-openagent#3455 -- The commit only adds a CLA signature to cla.json, which is administrative noise with no code or product value.fe091ef2chore: bump version to 3.17.4 -- The commit only updates the version number in package.json, which is administrative noise with no code or product value.c9350c67release: v3.17.4 -- The commit only updates version numbers in multiple package.json files, which is administrative noise with no code or product value.Branch:
sync/upstream/v3.17.4-slop(on origin)Slop verifier second-pass notes
1e2e001CONFIRMED_SLOP (behavior delta: none): The commit changes the visibility ofCreateToolsResultfromexportto internal without any clear functional or architectural benefit. This is classified as minor visibility churn, which is a documented slop pattern. There's no concrete behavior delta, and the commit message lacks justification for the change. A senior engineer would likely question the value of this change without further context.9d89bbbCONFIRMED_SLOP (behavior delta: none): The commit changes the visibility of LoadBuiltinCommandsOptions from export to internal without clear functional or architectural benefit, indicating minor visibility churn. There's no concrete behavior delta, and the commit message lacks justification for the change. A senior engineer would likely question the value of this refactor without additional context or future plans. The first-pass verdict correctly identifies this as minor_visibility_churn with no apparent value addition.0c5cd3aCONFIRMED_SLOP (behavior delta: none): The commit updates generation dates in multiple AGENTS.md files without adding new functionality or value beyond metadata churn. This aligns with documented slop patterns for date updates and metadata-only doc edits. There is no concrete behavior delta, and the changes do not introduce new functionality or improve existing code in a measurable way.e654cfbCONFIRMED_SLOP (behavior delta: none): The commit only adds a CLA signature to cla.json, which is administrative noise with no code or product value. The first-pass reason correctly identifies it as cla_admin, a category excluded from being demoted to GOOD by the verification bias. There is no concrete behavior delta, and the change does not introduce any new functionality or improvements to the codebase.6713b30CONFIRMED_SLOP (behavior delta: none): The commit removes no-op callbacks without adding new functionality or improving existing code structure in a meaningful way. The changes are purely refactor_churn with no concrete behavior delta, no new abstractions with multiple callers, and the commit message accurately reflects the removal but lacks measurable value. A senior engineer would likely question the necessity of this change without additional context or future plans.21cad26CONFIRMED_SLOP (behavior delta: none): The commit removes redundant schema default comments, which is a minor documentation change with no functional impact or added clarity. The first-pass reason correctly identifies this as docs_churn with high confidence. No concrete behavior delta exists, and the change does not strengthen or weaken any invariants. The commit message accurately reflects the change but does not provide measurable value beyond churn.6a0d515CONFIRMED_SLOP (behavior delta: none): The commit only adds a CLA signature to cla.json, which is administrative noise with no code or product value. This aligns with the 'cla_admin' category, which is explicitly non-mergable as per the verification bias rules.5b33cd2CONFIRMED_SLOP (behavior delta: none): The commit only adds a CLA signature to cla.json, which is administrative noise with no code or product value. This aligns with the 'cla_admin' slop signal and does not provide any concrete behavior delta or value to the codebase.c6deb6dCONFIRMED_SLOP (behavior delta: none): The commit only adds a CLA signature to cla.json, which is administrative noise with no code or product value. The change does not affect any runtime behavior, user-visible output, or invariants. It aligns with the 'cla_admin' category, which is explicitly non-GOOD by the verification bias rules.42df1c3CONFIRMED_SLOP (behavior delta: none): The commit adds only a CLA signature to cla.json, which is administrative noise without code or product value. The first-pass reason correctly identifies it as cla_admin, a category excluded from being demoted to GOOD by the verification bias. No behavior delta exists as it doesn't alter runtime code or user-visible output.84f980cCONFIRMED_SLOP (behavior delta: none): The commit only adds a CLA signature to cla.json, which is administrative noise with no code or product value. This aligns with the 'cla_admin' slop signal and does not provide any concrete behavior delta or value to the codebase.678011cCONFIRMED_SLOP (behavior delta: none): The commit updates counts and version references in documentation without adding new functionality or substantial information. These changes are classified as metadata-only doc edits, which are considered SLOP. No concrete behavior delta exists as the updates do not alter runtime code paths or user-visible outputs. The commit message accurately reflects the changes but lacks measurable value beyond maintaining accuracy of counts and versions.cfd152aCONFIRMED_SLOP (behavior delta: none): The commit adds two new agents with overly verbose, generic descriptions lacking concrete examples or clear user value beyond buzzwords. The commit message uses vague improvement language without measurable delta, and the changes expand existing docs without new facts. No concrete behavior delta is introduced, and the additions do not demonstrate clear growth paths or measurable benefits.0cb0a6cCONFIRMED_SLOP (behavior delta: none): The commit updates counts and version references in documentation without adding new information or functionality. These changes are classified as metadata churn, which is considered SLOP under the given rubric. No concrete behavior delta exists, and the update does not introduce new value beyond bookkeeping.3419bbcCONFIRMED_SLOP (behavior delta: none): The commit only adds a CLA signature to cla.json, which is administrative noise with no code or product value. This matches the 'cla_admin' category, which is explicitly excluded from being demoted to GOOD. No behavior delta exists as it's purely administrative.1bb59c3CONFIRMED_SLOP (behavior delta: none): The commit is a release version bump with no code changes, only updating version numbers in multiple package.json files. This matches the 'release_version_bump' slop pattern, and according to the verification bias, such commits should not be demoted to GOOD. There is no concrete behavior delta, and the change is purely administrative.571cf1fCONFIRMED_SLOP (behavior delta: none): The commit only adds a CLA signature to cla.json, which is administrative noise with no code or product value. This aligns with the 'cla_admin' category, which is explicitly non-GOOD by the verification bias rules.f98f7ecCONFIRMED_SLOP (behavior delta: none): The commit adds a CLA signature to cla.json, which is purely administrative and does not introduce any code or product value. This aligns with the 'cla_admin' slop signal, and there's no concrete behavior delta or value addition.d97c067CONFIRMED_SLOP (behavior delta: none): The commit only adds a CLA signature to cla.json, which is administrative noise with no code or product value. This aligns with the 'cla_admin' category, which is explicitly non-mergable as per the verification bias rules.eaf5ff2CONFIRMED_SLOP (behavior delta: none): The commit only adds a CLA signature to cla.json, which is administrative noise with no code or product value. The first-pass reason correctly identifies this as cla_admin, a category excluded from being demoted to GOOD by the verification bias. There is no concrete behavior delta, and the change does not introduce any new functionality or fix an issue.f8f7ac1CONFIRMED_SLOP (behavior delta: none): The commit only adds a CLA signature to cla.json, which is administrative noise with no code or product value. This matches the documented slop pattern for cla_admin. There is no concrete behavior delta, and the change does not strengthen or weaken any invariant. A senior engineer would likely not defend this as a valuable change in a code review focused on merge value.54a94d4CONFIRMED_SLOP (behavior delta: none): The commit only adds a CLA signature to cla.json, which is administrative noise with no code or product value. This aligns with the 'cla_admin' slop signal and does not provide any concrete behavior delta or value to the project's functionality.81a03faCONFIRMED_SLOP (behavior delta: none): The commit only adds a CLA signature to cla.json, which is administrative noise with no code or product value. This aligns with the 'cla_admin' slop signal and does not provide any concrete behavior delta, abstraction value, or measurable improvement. The commit message accurately reflects the change but does not justify merge value under the fork's rubric.9aeb87cCONFIRMED_SLOP (behavior delta: none): The commit only updates the version number in package.json, which is classified as release_version_bump, a category explicitly marked as SLOP by the guidelines. There is no code change, behavior delta, or product value added beyond administrative metadata update. The first-pass verdict correctly identifies this as SLOP with high confidence.80e73f5CONFIRMED_SLOP (behavior delta: none): The commit only adds a CLA signature to cla.json, which is administrative noise with no code or product value. The change does not affect any runtime behavior, user-visible output, or invariants. It falls under 'cla_admin', a category excluded from being demoted to GOOD by the verification bias. No concrete benefit or behavior delta exists to justify demotion.fe091efCONFIRMED_SLOP (behavior delta: none): The commit only updates the version number in package.json, which is classified as release_version_bump, a documented slop pattern. There is no concrete behavior delta, no new functionality, and the change is purely administrative. The first-pass verdict correctly identifies this as administrative noise with no merge value for the fork.c9350c6CONFIRMED_SLOP (behavior delta: none): The commit only updates version numbers in multiple package.json files, which is administrative noise with no code or product value. This matches the 'release_version_bump' category, which is explicitly non-GOOD by the provided rubric.Fork-sync impact assessment
Breaking changes
(none detected)
Dependency changes
(none)
Architecture drift
(none)
Hidden concerns
AGENTS.mdupdates)Action items before merging
GOODrefactor commits for subtle issuesGenerated by
upstream-analyzerworkflow. This issue is advisory: no merges or publishes happen automatically. Phase 1: draft PRs only. The prompt lives in.github/prompts/and is editable without touching workflow code.Classify chain:
openrouter:qwen/qwen3-coder:free → nvidia:nvidia/llama-3.3-nemotron-super-49b-v1 → github:openai/gpt-4.1-miniSlop-verify chain:
openrouter:nvidia/nemotron-3-super-120b-a12b:free → nvidia:nvidia/llama-3.3-nemotron-super-49b-v1 → github:openai/gpt-4.1Synthesis chain:
openrouter:nvidia/nemotron-3-super-120b-a12b:free → nvidia:nvidia/llama-3.3-nemotron-super-49b-v1 → github:openai/gpt-4.1