You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The release contains a significant number of GOOD commits (85) with tangible fixes, refactors, and documentation improvements, but is substantially mixed with SLOP (30) and a high overall commit count (116), indicating a moderate slop ratio (~25.9%). While there are no critical breaking changes or dependency conflicts reported, the sheer volume of changes and minor churn warrants selective pulling. Key GOOD commits address functional fixes, test additions, and meaningful refactors. SLOP commits include minor visibility changes, CLA signatures, and date churn.
Batch classification
Verdict
Count
Branch
🟢 GOOD
85
sync/upstream/v3.17.4-good
🟡 NEEDS_REVIEW
1
sync/upstream/v3.17.4-needs-review
🔴 SLOP
30
sync/upstream/v3.17.4-slop
🟢 Good batch
Classified as real value. Candidate for merge.
ad85e438fix: include user/project agents in task(subagent_type) resolution -- The commit fixes a concrete behavior issue by including user and project agents in task resolution, with clear tests covering various scenarios.
2266f28ffix: correct merge order so project agents override user agents -- The commit fixes a concrete behavior issue by ensuring project agents override user agents when names collide, with a new test covering this scenario.
64408823fix: actually swap merge order so project is added before user -- The commit fixes a concrete behavior issue by swapping the merge order of project and user agents, ensuring project agents take precedence, with a new test covering this scenario.
5441c848refactor: use spyOn instead of vi.mock for agent loader mocks -- The commit replaces vi.mock with spyOn for agent loader mocks, which is a clear refactor with a specific, mentioned benefit (being more idiomatic for bun:test) as suggested in a PR review.
b0b19f30fix(grep): handle Windows drive-letter paths and CRLF in parseOutput -- The commit fixes a concrete behavior issue by updating regex patterns to handle Windows drive-letter paths and CRLF line endings, ensuring the grep tool works correctly across platforms.
e9b6bba1refactor(agent-display): centralize name normalization resolution -- The commit centralizes name normalization for agent displays, adds tests for legacy name conversion and UI prefix stripping, and refactors the resolution logic for clarity and reuse.
f95e7a6crefactor(openclaw): reuse shared gateway url validation -- The commit refactors the code to reuse a shared gateway URL validation function, removing redundant code and improving maintainability.
40411f32docs(agents): add AGENTS.md documentation for prometheus, hephaestus, sisyphus variants, and builtin-skills -- Added substantial documentation for multiple agents and built-in skills with clear structure and purpose.
21822ba2test(openclaw): cover shared gateway url validation -- Adds meaningful test coverage for gateway URL validation scenarios, including HTTPS, local HTTP, and invalid URLs.
a2ae3de3refactor(openclaw): extract gateway url validator -- Extracted a reusable function validateGatewayUrl into a separate file, reducing code duplication and improving maintainability.
69f1c9aefix(doctor): add timeouts to subprocess spawns to prevent exit code 137 -- Adds timeouts to subprocess spawns to prevent hanging processes and SIGKILL (exit code 137), introducing a clear functional fix with direct behavioral improvement.
314e1a5efix(telemetry): enable GeoIP resolution for PostHog events -- Explicitly enables GeoIP resolution for PostHog events by setting disableGeoip to false, adding clear functional value for geographic analytics.
d21ed3f7fix(doctor): add timeouts to subprocess spawns to prevent exit code 137 -- Adds timeouts to subprocess spawns to prevent hanging processes and SIGKILL (exit code 137), introducing a clear functional fix with direct behavioral improvement.
565d3ffafix(ci): build darwin binaries on macOS runners to restore code signing -- The commit fixes a concrete CI issue by routing darwin platforms to macOS runners for native compilation and adds an explicit ad-hoc codesign step to restore code signing, directly addressing a functional problem with macOS Gatekeeper.
71b5ab67fix(ci): replace breaking codesign step with signature verification -- The commit fixes a concrete CI issue by replacing a breaking codesign step with signature verification, directly addressing a functional problem with macOS Gatekeeper.
16e7fa5bfix(ci): ad-hoc sign darwin binaries with plain codesign -- The commit fixes a concrete CI issue by explicitly signing Darwin binaries with 'codesign --sign -' to address a functional problem with macOS Gatekeeper, directly improving build reliability.
470ed8b1fix(ci): remove existing signature before ad-hoc signing darwin binary -- The commit fixes a concrete CI issue by removing an existing malformed signature before applying a fresh ad-hoc signature to Darwin binaries, directly addressing a functional problem with macOS Gatekeeper.
2d65896brefactor(shared): simplify normalize SDK null guards -- Simplified null checks in normalizeSDKResponse function from explicit null and undefined checks to a single '== null' check, improving code readability without changing functionality.
50df6f0dtest(claude-code-plugin-loader): cover plugin path nullish resolution -- Adds meaningful test coverage for plugin path resolution, including nullish input handling.
668bc8e8refactor(config-manager): simplify config parsing guards -- Simplifies redundant conditional logic in config parsing and adds meaningful test coverage for valid and invalid config scenarios.
a0d5131erefactor(plugin): remove dead chat params code -- Removes dead code (unused 'variant' parameter and related logic) in chat-params.ts, simplifying the buildChatParamsInput function.
4de02094test(background-agent): lock nullish loop detector behavior -- Adds meaningful test coverage for nullish input handling in loop detector behavior, ensuring consistent behavior for null and undefined inputs.
c750781bfix(shared): avoid false-positive skill path resolution on npm scoped packages ([Bug]: Why my command run with error path? code-yeongyu/oh-my-openagent#2857) -- Fixes a concrete behavior issue by updating the regex in the skill path resolver to exclude npm scoped package references, with a new test case verifying the correction.
3d2eb6e4fix(config): preserve explicit git_master overrides during merge -- Adds tests and logic to preserve explicit git_master overrides, addressing a concrete configuration behavior issue.
dac0c99efeat: add Vercel AI Gateway as a provider -- Adds Vercel AI Gateway as a recognized provider with clear integration across multiple files and test updates, providing real user value.
aac17135test: add vercel provider transform tests -- Adds multiple meaningful tests for Vercel provider transformations with clear expected outputs, covering various model types and edge cases.
6f72ec75test: add integration tests for Vercel AI Gateway model resolution -- Adds integration tests for Vercel AI Gateway model resolution with multiple specific scenarios, ensuring correct model usage through snapshots and explicit expectations.
542dc890fix(provider): use gateway-specific model IDs for vercel transform -- The commit fixes a concrete behavior issue by using gateway-specific model IDs for Vercel transform, with clear changes in both tests and implementation.
34e334eafeat(provider): add vercel to all gateway-supported fallback entries -- Adds vercel provider fallback entries with clear integration and test updates, providing real user value.
effae16crefactor(provider): replace per-model string replacements with generic regex -- Replaced multiple per-model string replacements with a generic regex, simplifying the code and making it more maintainable for future model additions.
680d05a2Prometheus: keep planner primary-only -- Changes Prometheus agent mode from 'all' to 'primary' across multiple tests and implementation files, aligning with the stated goal of keeping the planner primary-only, with clear behavioral impact and no unnecessary churn.
e3b5c2befix: address review feedback for Vercel AI Gateway PR -- Adds Vercel AI Gateway integration with clear CLI option, priority logic, and test updates, providing real user value.
01a1b141fix(delegate-task): reject primary agents in task subagent resolution -- The commit introduces a concrete behavior fix by rejecting primary agents in task subagent resolution, with clear changes in multiple files and no unnecessary churn.
3673b962docs(readme-ru): add telemetry and legal section translation -- Added meaningful Russian translations for telemetry and legal sections in README.ru.md, including privacy policy and terms of service links with clear user value.
23d0a0dcdocs(readme-zh-cn): add telemetry and legal section translation -- Added meaningful Chinese translations for telemetry and legal sections in README.zh-cn.md, including privacy policy and terms of service links with clear user value.
0ece66e3docs(readme-ja): add telemetry and legal section translation -- Added meaningful Japanese translations for telemetry and legal sections in README.ja.md, including privacy policy and terms of service links with clear user value.
12ed9501docs(readme-ko): add telemetry and legal section translation -- Added meaningful Korean translations for telemetry and legal sections in README.ko.md, including privacy policy and terms of service links with clear user value.
c91db2ebdocs(cli): add --vercel-ai-gateway flag documentation -- Added documentation for a new CLI flag --vercel-ai-gateway with clear description and default value, providing user value.
e223ab20docs(configuration): add sisyphus-junior to agent list -- Added a new agent 'sisyphus-junior' to the documented list of available agents in the configuration guide, providing clear user value by informing users of an additional option.
9342e55bdocs(installation): replace npx with bunx and update provider flags -- Updated installation docs to replace 'npx' with 'bunx' and added new provider flags with clear user instructions and value.
05e54444docs(overview): update model-role claims and complete category list -- The commit updates documentation to reflect accurate model mappings and categories, adding clear value for users understanding the system's configuration and capabilities.
7c94ee45docs(agent-model-matching): sync fallback chains with current source -- Updated fallback chains in documentation to match current source of truth in src/shared/model-requirements.ts, providing accurate information for users.
b57a7975docs(ollama): verify troubleshooting steps and issue links -- Updated troubleshooting steps with verified issue links and clear documentation of a workaround, providing concrete user value.
bbbd1bd0docs(orchestration): update diagram model names and category tables -- Updated documentation with clear, substantive changes including model fallback chains and category tables, enhancing user understanding and value.
4ce1dde3CLI: isolate provider model id transforms from shared mocks -- Added meaningful tests for provider model ID transformations across multiple providers with clear expected outputs.
1b36194bfix(cli): treat missing session status as idle in run completion -- Added a test case to handle missing session status as idle, ensuring the CLI doesn't hang indefinitely, and updated the logic in poll-for-completion.ts to return 'idle' when the session ID is missing from the statuses.
b5250555fix(telemetry): guard PostHog init failures -- Adds meaningful test coverage for PostHog init failure handling, ensuring no-throw behavior for clients.
62c60ae9fix: numeric skill names, ultrawork missing run_in_background, ZWSP agent lookups -- The commit fixes concrete bugs with clear functional impact, including numeric skill name handling, missing 'run_in_background' parameter, and ZWSP agent lookup issues, all providing direct user benefits.
76c5356atest(agent-config): add regression tests for agent merge priority order -- Adds meaningful regression tests for agent merge priority order with clear test cases covering various scenarios.
da91c535fix(call-omo-agent): address cubic review findings and add requirement-based tests -- The commit fixes concrete issues, adds requirement-based tests, and improves agent resolution logic with clear user benefits.
1e85a88dfix(agent-restrictions): restore EXPLORATION_AGENT_DENYLIST as default fallback for unknown agents -- Restores a default fallback for unknown agents, directly impacting agent restriction behavior with clear functional value.
fd28f7e6feat(agents): add agent_definitions schema, eager path resolution, and JSON agent loader -- Adds agent_definitions schema, eager path resolution, and JSON agent loader with clear functional value and meaningful test coverage.
5755a90cfeat(agents): add agent definitions file loader and opencode.json reader -- Adds agent definitions loader with multiple file format support, comprehensive tests, and clear functional value for loading and parsing agent configurations.
39bda91bfeat(agents): wire agent_definitions and opencode.json agents into precedence chain -- The commit integrates agent_definitions and opencode.json agents into the precedence chain with clear functional value, adding new capabilities and meaningful tests.
3d0fb22cfix(call-omo-agent): adapt dev's model override tests to use createMockCtx factory -- The commit fixes a concrete compatibility issue by adapting tests to use a new factory function, ensuring test validity after a code change.
42445f51fix(agents): address cubic review findings on agent loader -- The commit addresses specific, concrete issues with agent loading, including case-insensitive file extension handling, relative path resolution, and precedence logic, with clear functional improvements and new tests.
cf4b2315fix(agents): replace 'in' with Object.hasOwn() for prototype-safe property checks -- Replaced 'in' with Object.hasOwn() for prototype-safe property checks in opencode-config-agents-reader.ts to avoid skipping valid agent names that match inherited properties.
4c77045cfix(agents): use null-prototype accumulator to prevent proto pollution -- The commit fixes a concrete security issue by preventing proto pollution using a null-prototype accumulator, directly improving the safety of property assignments and checks in the agent loader.
ab11f2ebfix(tests): replace mock.module with spyOn to prevent test pollution -- Replaced mock.module() with spyOn() to prevent test state pollution, ensuring tests are isolated and reliable.
47aa3025fix(cli): use getAgentRuntimeName for agent resolution in run command -- The commit fixes a concrete behavior issue by replacing 'getAgentDisplayName' with 'getAgentRuntimeName' for agent resolution in the run command, ensuring correct agent naming in the CLI.
0764526afix(posthog): disable exception autocapture to stay within free tier -- Disables exception autocapture to stay within PostHog's free tier limit, preserving manual capture for critical errors.
a1842f2dfeat(tool-metadata): add shared metadata contract and bridge -- Adds a shared metadata contract and bridge with meaningful tests covering various scenarios, including round-trip persistence, casing insensitivity, and edge cases like blank or missing call IDs.
80d3339cfeat(background-agent): add wait-for-task-session helper -- Adds a functional helper waitForTaskSessionID with meaningful tests covering various scenarios, including immediate resolution, delayed resolution, abort signals, timeouts, and terminal task statuses.
4da30057fix(plugin): harden metadata recovery and extraction -- The commit introduces meaningful functionality to extract session IDs from metadata, including legacy aliases, with clear tests and functional improvements across multiple hooks.
c6a407c4refactor(tools): migrate producers to shared metadata bridge -- The commit refactors multiple files to migrate producers to a shared metadata bridge, replacing storeToolMetadata with publishToolMetadata and removing redundant resolveCallID logic, indicating a clear architectural improvement with broad impact.
Branch: sync/upstream/v3.17.4-good (local only; not on origin)
⚠️ 6 commit(s) failed to cherry-pick and are NOT in the draft PR.
🚫 Push to origin was rejected. GITHUB_TOKEN cannot create or modify files under .github/workflows/. The batch branch exists only in the workflow runner and was discarded. To merge this batch, run the analyzer with a PAT that has the workflow scope, or cherry-pick locally.
📝 4 commit(s) touch .github/workflows/ and require elevated permissions to sync: 565d3ff, 71b5ab6, 16e7fa5, 470ed8b
🟡 Review batch
Ambiguous. Human should review before merging.
569addd3docs(provider): add comments to vercel transform logic -- Classification failed: No object generated: response did not match schema.
Branch: sync/upstream/v3.17.4-needs-review (local only; not on origin)
⚠️ 1 commit(s) failed to cherry-pick and are NOT in the draft PR.
🔴 Slop batch
Classified as AI slop or pointless churn. Do not merge as-is; rewrite intent if salvageable.
1e2e0019refactor(create-tools): keep result type internal -- The commit changes the visibility of CreateToolsResult from export to internal without any clear functional or architectural benefit, indicating minor visibility churn.
9d89bbb0refactor(commands): keep builtin command options internal -- Changed LoadBuiltinCommandsOptions from export to internal without clear functional or architectural benefit, indicating minor visibility churn.
0c5cd3a1chore(agents): update all AGENTS.md generation dates to 2026-04-11 -- The commit only updates generation dates in multiple AGENTS.md files without adding any new functionality, documentation, or fixes, indicating date metadata churn.
79a475d6refactor(background-agent): simplify loop detector null guard -- The commit simplifies a null guard from explicit null and undefined checks to a single '== null' check, which is a minor visibility-only change with no clear functional or architectural benefit.
cd8352c1refactor(claude-code-mcp-loader): simplify env expansion null guard -- The commit simplifies a null guard from explicit null and undefined checks to a single '== null' check, which is a minor visibility-only change with no clear functional or architectural benefit.
6713b30crefactor(hooks): drop no-op directory injector callbacks -- Removes unused 'tool.execute.before' callback with no functional impact, classified as minor churn.
21cad26cdocs(config): remove redundant schema default comments -- Removed redundant schema default comments, which is considered docs_churn as it only updates metadata without adding new information.
141798efrefactor(background-agent): standardize loop detector null guards -- The commit replaces explicit null and undefined checks with a single '== null' check, which is a minor visibility-only change with no clear functional or architectural benefit, aligning with the 'refactor_churn' category.
678011c7docs(contributing): update tool/hook counts and version references -- The commit updates counts and version references in the contributing docs without adding new information or functionality.
cfd152addocs(features): update agent count and verify category list -- Added two new features ('review-work' and 'ai-slop-remover') with overly broad, vague descriptions lacking concrete user value or clear behavior delta.
0cb0a6c0docs(contributing): update tool/hook counts and version references -- Updated counts and version references in docs without adding new information or functionality.
1bb59c3erelease: v3.17.2 -- The commit only updates version numbers in package.json files across multiple platforms, which is administrative noise with no code or product value.
fe091ef2chore: bump version to 3.17.4 -- The commit only updates the version number in package.json with no functional changes.
c9350c67release: v3.17.4 -- The commit only updates version numbers in multiple package.json files with no functional changes, constituting date/count metadata churn.
Branch: sync/upstream/v3.17.4-slop (on origin)
Slop verifier second-pass notes
1e2e001 CONFIRMED_SLOP (behavior delta: none): The commit changes the visibility of CreateToolsResult from export to internal without any clear functional or architectural benefit, indicating minor visibility churn. There's no concrete behavior delta, and the change does not strengthen or weaken any invariant. The commit message accurately reflects the change but lacks justification for why this internalization is necessary or beneficial. A senior engineer would likely question the value of this change without further context on planned usage or dependencies that require this visibility adjustment.
9d89bbb CONFIRMED_SLOP (behavior delta: none): The commit changes the visibility of LoadBuiltinCommandsOptions from export to internal without clear functional or architectural benefit, indicating minor visibility churn. No runtime behavior changes, and the abstraction's scope remains unchanged. A senior engineer would likely question the value of this change without further context on intended future use or constraints.
0c5cd3a CONFIRMED_SLOP (behavior delta: none): The commit only updates generation dates in multiple AGENTS.md files without adding any new functionality, documentation, or fixes. This is a clear case of date metadata churn, which is classified as SLOP according to the guidelines. There is no concrete behavior delta, and the change does not provide any measurable value or improvement.
e654cfb CONFIRMED_SLOP (behavior delta: none): The commit only adds a CLA signature entry to cla.json without any code or functional changes, aligning with 'cla_admin' slop signals. No behavior delta exists as it's administrative noise. A senior engineer would not defend this as value-adding in a code review focused on merge value for this fork.
79a475d CONFIRMED_SLOP (behavior delta: none): The commit simplifies a null guard from explicit checks to '== null', which is a minor visibility change with no clear functional or architectural benefit. The first-pass correctly identified this as refactor_churn with high confidence. No concrete behavior delta exists beyond stylistic change, and no new abstractions or value are added. A senior engineer would likely question the necessity of this change without broader impact.
cd8352c CONFIRMED_SLOP (behavior delta: none): The commit simplifies a null guard from explicit checks to '== null', which is a minor visibility change with no clear functional or architectural benefit. The first-pass reason correctly identifies this as refactor_churn with no concrete value. No behavior delta exists beyond stylistic change.
6713b30 CONFIRMED_SLOP (behavior delta: none): The commit removes unused 'tool.execute.before' callbacks in two hook files, which the first-pass classified as refactor_churn with no functional impact. Upon review, the removed code had no behavior delta (voided inputs/outputs, no side effects), and the change is purely a cleanup of unused code. While removing dead code is generally positive, in this context, it lacks a concrete benefit (e.g., performance gain, readability improvement for maintained code) that would justify demoting from SLOP. The commit message accurately reflects the change but does not provide a measurable justification for the refactor. A senior engineer might defend it as minor hygiene, but without a clear value proposition, it aligns with the initial SLOP verdict.
21cad26 CONFIRMED_SLOP (behavior delta: none): The commit removes redundant schema default comments, which is classified as docs_churn. The changes do not affect runtime behavior, user-visible output, or invariants. The commit message accurately reflects the change, but it does not add new information or value beyond metadata updates. A senior engineer might question the necessity of this change as it doesn't provide clear benefits or prepare for future functionality. The first-pass verdict correctly identifies this as SLOP due to the lack of concrete value addition.
141798e CONFIRMED_SLOP (behavior delta: none): The commit replaces explicit null and undefined checks with a single '== null' check, which is a minor visibility-only change with no clear functional or architectural benefit. This aligns with 'refactor_churn' as it does not introduce new behavior, improve performance, or fix a bug. The change simplifies the code slightly but does not provide substantial value.
6a0d515 CONFIRMED_SLOP (behavior delta: none): The commit only adds a CLA signature to cla.json, which is administrative noise with no code or product value. This aligns with the 'cla_admin' slop signal and does not provide any concrete behavior delta, abstraction, or user-visible change. The first-pass verdict correctly identifies it as SLOP.
5b33cd2 CONFIRMED_SLOP (behavior delta: none): The commit adds a CLA signature to cla.json, which is purely administrative with no impact on code or product functionality. This aligns with the 'cla_admin' slop signal and does not introduce any behavior delta.
c6deb6d CONFIRMED_SLOP (behavior delta: none): The commit adds a CLA signature to cla.json, which is purely administrative and does not introduce any code or product value. This aligns with the 'cla_admin' slop signal. There is no behavior delta, and the change does not strengthen or weaken any invariants. The commit message accurately reflects the administrative update but does not justify merge value under the fork's rubric.
42df1c3 CONFIRMED_SLOP (behavior delta: none): The commit only adds a CLA signature to cla.json, which is administrative noise with no direct code or product value. This matches the 'cla_admin' category, which is explicitly non-mergable as per the verification bias rules. No behavior delta exists as it doesn't alter runtime code or user-visible output.
84f980c CONFIRMED_SLOP (behavior delta: none): The commit only adds a CLA signature to cla.json, which is administrative noise with no direct code or product value. The change does not alter any runtime behavior, user-visible output, or invariants. It fits the cla_admin category, which is excluded from being demoted to GOOD by the verification bias rules.
678011c CONFIRMED_SLOP (behavior delta: none): The commit updates counts and version references in the contributing docs without adding new information or functionality. These changes are metadata-only and do not introduce any behavioral delta, new features, or bug fixes. The first-pass verdict correctly identifies this as SLOP due to the nature of the updates being purely informational and not enhancing the project's functionality or correctness.
cfd152a CONFIRMED_SLOP (behavior delta: none): The commit adds two features with vague descriptions lacking clear user value or measurable metrics. 'review-work' and 'ai-slop-remover' do not specify how they enhance existing functionality or introduce new behavior deltas beyond generic claims. No concrete behavior delta is evident, and the descriptions rely on buzzwords without concrete examples or metrics.
0cb0a6c CONFIRMED_SLOP (behavior delta: none): The commit updates counts and version references in documentation without adding new information or functionality. The changes are purely numerical and do not introduce any new concepts, explanations, or value beyond keeping numbers current. This aligns with the first-pass reason that the update expands existing content without new facts.
3419bbc CONFIRMED_SLOP (behavior delta: none): The commit only adds a CLA signature to cla.json, which is administrative noise with no code or product value. This matches the 'cla_admin' category, which is explicitly excluded from being demoted to GOOD. No behavior delta exists as it doesn't alter runtime code or user-visible output.
1bb59c3 CONFIRMED_SLOP (behavior delta: none): The commit only updates version numbers in multiple package.json files, which is classified as release_version_bump, a type of administrative noise with no direct code or product value. There is no concrete behavior delta, and the change does not introduce new functionality, fixes, or tests. The first-pass verdict correctly identifies this as SLOP following the guidelines.
571cf1f CONFIRMED_SLOP (behavior delta: none): The commit only adds a CLA signature to cla.json, which is administrative noise with no code or product value. This matches the 'cla_admin' category, which is explicitly excluded from being demoted to GOOD. There is no behavior delta, no new functionality, and the change does not impact any runtime code path or user-visible output.
f98f7ec CONFIRMED_SLOP (behavior delta: none): The commit only adds a CLA signature to cla.json, which is administrative noise with no code or product value. The change does not affect any runtime behavior, user-visible output, or invariants. It falls under the 'cla_admin' category, which is explicitly excluded from being demoted to GOOD by the verification bias rules.
d97c067 CONFIRMED_SLOP (behavior delta: none): The commit only adds a CLA signature to cla.json, which is administrative noise with no code or product value. This matches the 'cla_admin' category, which is explicitly non-GOOD by the verification bias rules. No behavior delta exists as it doesn't alter runtime code or user-visible output.
eaf5ff2 CONFIRMED_SLOP (behavior delta: none): The commit only adds a CLA signature to cla.json, which is administrative noise with no code or product value. The change does not affect any runtime behavior, abstractions, or user-visible output. It aligns with the 'cla_admin' category, which is explicitly non-GOOD by the verification bias rules.
f8f7ac1 CONFIRMED_SLOP (behavior delta: none): The commit only adds a CLA signature to cla.json, which is administrative noise with no code or product value. The first-pass verdict correctly identifies it as cla_admin, a category excluded from being demoted to GOOD by the verification bias rules.
54a94d4 CONFIRMED_SLOP (behavior delta: none): The commit only adds a CLA signature to cla.json, which is administrative noise with no code or product value. The first-pass verdict correctly identifies this as cla_admin, a category excluded from being demoted to GOOD by the verification bias. There is no concrete behavior delta, and the change does not improve functionality or user experience in any way.
81a03fa CONFIRMED_SLOP (behavior delta: none): The commit only adds a CLA signature to cla.json, which is administrative noise with no code or product value. This aligns with the 'cla_admin' slop signal and does not provide any concrete behavior delta or value to the repository's functionality.
9aeb87c CONFIRMED_SLOP (behavior delta: none): The commit only updates the version number in package.json with no functional changes, aligning with the 'release_version_bump' slop pattern. No behavior delta exists as it's purely administrative. The first-pass verdict correctly identifies this as SLOP based on the provided guidelines.
80e73f5 CONFIRMED_SLOP (behavior delta: none): The commit adds a CLA signature to cla.json, which is purely administrative noise with no impact on code or product functionality. The first-pass verdict correctly identifies this as cla_admin, a category excluded from being demoted to GOOD by the verification bias. There is no concrete behavior delta, and the change does not introduce any new functionality or improvements.
fe091ef CONFIRMED_SLOP (behavior delta: none): The commit only updates the version number in package.json with no functional changes, aligning with the 'release_version_bump' slop pattern. No behavior delta exists as it's purely administrative. First-pass verdict is correct given the guidelines.
c9350c6 CONFIRMED_SLOP (behavior delta: none): The commit only updates version numbers in multiple package.json files with no functional changes, constituting date/count metadata churn, which is explicitly categorized as SLOP under the given rubric. No behavior delta exists as the changes are purely metadata updates. The commit message accurately reflects the change but does not justify merging value. A senior engineer would likely not defend this as valuable in a code review focused on functional or behavioral changes.
Fork-sync impact assessment
Breaking changes
(none detected)
Dependency changes
(none)
Architecture drift
(none)
Hidden concerns
High commit volume may indicate underlying complexity or instability not fully captured by classifications.
Action items before merging
Manually review the 30 SLOP commits for potential hidden value or unintended consequences.
Verify the functional impact of refactors like use spyOn instead of vi.mock and centralize name normalization.
Assess the necessity of substantial doc updates (e.g., AGENTS.md, README translations) in the context of your fork.
Generated by upstream-analyzer workflow. This issue is advisory: no merges or publishes happen automatically. Phase 1: draft PRs only. The prompt lives in .github/prompts/ and is editable without touching workflow code.
🟡 Upstream cost-benefit: v3.17.0 → v3.17.4
Upstream:
code-yeongyu/oh-my-openagentRecommendation:
CHERRY_PICK(confidence: medium)Slop ratio: 25%
The release contains a significant number of GOOD commits (85) with tangible fixes, refactors, and documentation improvements, but is substantially mixed with SLOP (30) and a high overall commit count (116), indicating a moderate slop ratio (~25.9%). While there are no critical breaking changes or dependency conflicts reported, the sheer volume of changes and minor churn warrants selective pulling. Key GOOD commits address functional fixes, test additions, and meaningful refactors. SLOP commits include minor visibility changes, CLA signatures, and date churn.
Batch classification
sync/upstream/v3.17.4-goodsync/upstream/v3.17.4-needs-reviewsync/upstream/v3.17.4-slop🟢 Good batch
Classified as real value. Candidate for merge.
ad85e438fix: include user/project agents in task(subagent_type) resolution -- The commit fixes a concrete behavior issue by including user and project agents in task resolution, with clear tests covering various scenarios.2266f28ffix: correct merge order so project agents override user agents -- The commit fixes a concrete behavior issue by ensuring project agents override user agents when names collide, with a new test covering this scenario.64408823fix: actually swap merge order so project is added before user -- The commit fixes a concrete behavior issue by swapping the merge order of project and user agents, ensuring project agents take precedence, with a new test covering this scenario.5441c848refactor: use spyOn instead of vi.mock for agent loader mocks -- The commit replacesvi.mockwithspyOnfor agent loader mocks, which is a clear refactor with a specific, mentioned benefit (being more idiomatic for bun:test) as suggested in a PR review.b0b19f30fix(grep): handle Windows drive-letter paths and CRLF in parseOutput -- The commit fixes a concrete behavior issue by updating regex patterns to handle Windows drive-letter paths and CRLF line endings, ensuring the grep tool works correctly across platforms.e9b6bba1refactor(agent-display): centralize name normalization resolution -- The commit centralizes name normalization for agent displays, adds tests for legacy name conversion and UI prefix stripping, and refactors the resolution logic for clarity and reuse.f95e7a6crefactor(openclaw): reuse shared gateway url validation -- The commit refactors the code to reuse a shared gateway URL validation function, removing redundant code and improving maintainability.40411f32docs(agents): add AGENTS.md documentation for prometheus, hephaestus, sisyphus variants, and builtin-skills -- Added substantial documentation for multiple agents and built-in skills with clear structure and purpose.21822ba2test(openclaw): cover shared gateway url validation -- Adds meaningful test coverage for gateway URL validation scenarios, including HTTPS, local HTTP, and invalid URLs.a2ae3de3refactor(openclaw): extract gateway url validator -- Extracted a reusable function validateGatewayUrl into a separate file, reducing code duplication and improving maintainability.69f1c9aefix(doctor): add timeouts to subprocess spawns to prevent exit code 137 -- Adds timeouts to subprocess spawns to prevent hanging processes and SIGKILL (exit code 137), introducing a clear functional fix with direct behavioral improvement.314e1a5efix(telemetry): enable GeoIP resolution for PostHog events -- Explicitly enables GeoIP resolution for PostHog events by setting disableGeoip to false, adding clear functional value for geographic analytics.d21ed3f7fix(doctor): add timeouts to subprocess spawns to prevent exit code 137 -- Adds timeouts to subprocess spawns to prevent hanging processes and SIGKILL (exit code 137), introducing a clear functional fix with direct behavioral improvement.565d3ffafix(ci): build darwin binaries on macOS runners to restore code signing -- The commit fixes a concrete CI issue by routing darwin platforms to macOS runners for native compilation and adds an explicit ad-hoc codesign step to restore code signing, directly addressing a functional problem with macOS Gatekeeper.71b5ab67fix(ci): replace breaking codesign step with signature verification -- The commit fixes a concrete CI issue by replacing a breaking codesign step with signature verification, directly addressing a functional problem with macOS Gatekeeper.16e7fa5bfix(ci): ad-hoc sign darwin binaries with plain codesign -- The commit fixes a concrete CI issue by explicitly signing Darwin binaries with 'codesign --sign -' to address a functional problem with macOS Gatekeeper, directly improving build reliability.470ed8b1fix(ci): remove existing signature before ad-hoc signing darwin binary -- The commit fixes a concrete CI issue by removing an existing malformed signature before applying a fresh ad-hoc signature to Darwin binaries, directly addressing a functional problem with macOS Gatekeeper.2d65896brefactor(shared): simplify normalize SDK null guards -- Simplified null checks in normalizeSDKResponse function from explicit null and undefined checks to a single '== null' check, improving code readability without changing functionality.50df6f0dtest(claude-code-plugin-loader): cover plugin path nullish resolution -- Adds meaningful test coverage for plugin path resolution, including nullish input handling.668bc8e8refactor(config-manager): simplify config parsing guards -- Simplifies redundant conditional logic in config parsing and adds meaningful test coverage for valid and invalid config scenarios.a0d5131erefactor(plugin): remove dead chat params code -- Removes dead code (unused 'variant' parameter and related logic) in chat-params.ts, simplifying the buildChatParamsInput function.4de02094test(background-agent): lock nullish loop detector behavior -- Adds meaningful test coverage for nullish input handling in loop detector behavior, ensuring consistent behavior for null and undefined inputs.e71c34acfix(migration): return true when canonical config write succeeds regardless of archive status ([Bug]: v3.15.1 still inconsistently loads/migrates plugin config after rename code-yeongyu/oh-my-openagent#3133) -- Fixes a concrete behavior issue where migration incorrectly reported failure due to secondary archive status, despite successful canonical config write.7accb53cfix(shared): handle Windows rename-over-existing in write-file-atomically ([Bug]: Using oh-my-opencode via bunx causes a new oh-my-openagent.json.bak.* backup file to be created on every OpenCode startup, even when no config changes were made. code-yeongyu/oh-my-openagent#3222) -- Fixes a concrete behavior issue on Windows by handling rename-over-existing errors with a fallback strategy, adding meaningful test coverage for atomic file writes.9ef133a8fix(migration): register parenthesized legacy agent aliases in AGENT_NAME_MAP ([Bug]: Header 'x-opencode-agent-name' has invalid value: 'Atlas (Plan Executor)' code-yeongyu/oh-my-openagent#3281) -- Adds concrete mappings for legacy agent aliases and tests for migration correctness, addressing a specific compatibility issue.a6e4f211fix(shared): normalize claude model IDs for anthropic provider (transformModelForProvider missing anthropic provider — dash-format model IDs rejected by OpenCode code-yeongyu/oh-my-openagent#3290) -- Fixes a concrete compatibility issue by normalizing model IDs for Anthropic API, with clear test expectation updates.4f02ace7fix(shared): guard maxOutputTokens <= 0 in model settings compatibility ([Bug]: Invalid argument for parameter maxOutputTokens: maxOutputTokens must be >= 1 code-yeongyu/oh-my-openagent#3305) -- Fixes a concrete behavior issue by adding a guard to ignore invalid maxOutputTokens metadata, preserving user-requested maxTokens with new test coverage.c750781bfix(shared): avoid false-positive skill path resolution on npm scoped packages ([Bug]: Why my command run with error path? code-yeongyu/oh-my-openagent#2857) -- Fixes a concrete behavior issue by updating the regex in the skill path resolver to exclude npm scoped package references, with a new test case verifying the correction.d7b4bec5fix(hooks,tools): replace /plan example with prometheus delegation and rename code-review example to review-work (Error message references non-existent /plan command code-yeongyu/oh-my-openagent#2633, [Bug]: Skill tool schema uses non-existent "code-review" as example instead of actual "review-work" skill code-yeongyu/oh-my-openagent#3285, [Bug]: oh-my-openagent overrides built-in tools to bypass the permission system. code-yeongyu/oh-my-openagent#2873) -- The commit fixes a concrete behavior issue by replacing a non-existent command reference with the correct Prometheus agent guidance and updates a skill name to match an actual built-in skill, with clear test additions.7e96af5ffix(atlas): exclude node_modules from verification git diff --stat ([Feature]: Ensure gitignore is created before starting implementation code-yeongyu/oh-my-openagent#3215) -- The commit fixes a concrete behavior issue by excluding node_modules from git diff verification, with clear test additions.2d8b4a9dfix(anthropic-effort): skip effort injection for github-copilot provider ([Bug]: code-yeongyu/oh-my-openagent#3270) -- Explicit guard added to skip effort injection for github-copilot provider, preserving native Anthropic support, with clear test addition.796a646cfix(non-interactive-env): use detectShellType instead of hardcoded win32 check ([Bug]: Force PowerShell env behavior in Windows code-yeongyu/oh-my-openagent#3310, Bug: PowerShell env var syntax ($env:VAR) used in bash shell on Windows code-yeongyu/oh-my-openagent#3338) -- The commit replaces a hardcoded win32 check with detectShellType(), allowing correct shell syntax detection for various Windows environments (Git Bash, WSL, native PowerShell) through new tests.64e55936fix(multimodal-looker): instruct explicit Read tool usage for PDFs (Multimodal-Looker Cannot Read PDF Files code-yeongyu/oh-my-openagent#2998) -- Explicit instruction added to ensure PDFs are loaded via the Read tool before extraction, addressing a concrete behavior gap.d8b9bf1afix(doctor): check comment-checker lazy-download cache path ([Question]: comment-checker not found code-yeongyu/oh-my-openagent#2911, [Bug] comment-checker hook does not trigger code-yeongyu/oh-my-openagent#3315) -- Fixes a concrete behavior issue by aligning the doctor's resolution order with runtime, ensuring cached binaries are recognized as installed, with clear test addition.3bfa3bd6fix(background-agent): pass query directory to session.get in 4 call-sites ([Bug]: resolveSubagentSpawnContext fails to find project-scoped sessions — client.session.get() missing directory parameter code-yeongyu/oh-my-openagent#2937) -- The commit fixes a concrete behavior issue by passing the query directory to session.get in multiple call-sites, resolving 404 errors under newer OpenCode SDK versions, with clear test additions.eb495793fix(event): prefer real session.idle over recent synthetic dedup ([Bug]: The model has responded normally, but there is a red alert in the input box: [TODO-DIAG] BLOCKED: no todossession.idle event code-yeongyu/oh-my-openagent#2667) -- The commit fixes a concrete behavior issue by ensuring real session.idle events are not dropped when a synthetic idle has fired within the dedup window, with clear test case adjustments.aed8dbfafix(delegate-task): fetch session result before honoring abort signal ([Bug]: @explore subagent completes but parent never returns result; 3.12.3 aborts with "The operation was aborted." code-yeongyu/oh-my-openagent#2702) -- Fixes a concrete behavior issue where the sync poller returned 'Task aborted' immediately upon abort signal, even when a terminal assistant message was already received, by attempting a final fetch for the session result before emitting the abort message.c5c5bc36fix(delegate-task): consume fallback chain on sendSyncPrompt failure (delegate-task: No automatic retry with fallback models when subagent fails due to model error code-yeongyu/oh-my-openagent#2691) -- The commit fixes a concrete behavior issue by implementing a retry loop for sendSyncPrompt failures using a fallback chain, with clear test additions and functional improvements.3d2eb6e4fix(config): preserve explicit git_master overrides during merge -- Adds tests and logic to preserve explicit git_master overrides, addressing a concrete configuration behavior issue.dac0c99efeat: add Vercel AI Gateway as a provider -- Adds Vercel AI Gateway as a recognized provider with clear integration across multiple files and test updates, providing real user value.aac17135test: add vercel provider transform tests -- Adds multiple meaningful tests for Vercel provider transformations with clear expected outputs, covering various model types and edge cases.6f72ec75test: add integration tests for Vercel AI Gateway model resolution -- Adds integration tests for Vercel AI Gateway model resolution with multiple specific scenarios, ensuring correct model usage through snapshots and explicit expectations.542dc890fix(provider): use gateway-specific model IDs for vercel transform -- The commit fixes a concrete behavior issue by using gateway-specific model IDs for Vercel transform, with clear changes in both tests and implementation.34e334eafeat(provider): add vercel to all gateway-supported fallback entries -- Adds vercel provider fallback entries with clear integration and test updates, providing real user value.effae16crefactor(provider): replace per-model string replacements with generic regex -- Replaced multiple per-model string replacements with a generic regex, simplifying the code and making it more maintainable for future model additions.680d05a2Prometheus: keep planner primary-only -- Changes Prometheus agent mode from 'all' to 'primary' across multiple tests and implementation files, aligning with the stated goal of keeping the planner primary-only, with clear behavioral impact and no unnecessary churn.e3b5c2befix: address review feedback for Vercel AI Gateway PR -- Adds Vercel AI Gateway integration with clear CLI option, priority logic, and test updates, providing real user value.01a1b141fix(delegate-task): reject primary agents in task subagent resolution -- The commit introduces a concrete behavior fix by rejecting primary agents in task subagent resolution, with clear changes in multiple files and no unnecessary churn.3673b962docs(readme-ru): add telemetry and legal section translation -- Added meaningful Russian translations for telemetry and legal sections in README.ru.md, including privacy policy and terms of service links with clear user value.23d0a0dcdocs(readme-zh-cn): add telemetry and legal section translation -- Added meaningful Chinese translations for telemetry and legal sections in README.zh-cn.md, including privacy policy and terms of service links with clear user value.0ece66e3docs(readme-ja): add telemetry and legal section translation -- Added meaningful Japanese translations for telemetry and legal sections in README.ja.md, including privacy policy and terms of service links with clear user value.12ed9501docs(readme-ko): add telemetry and legal section translation -- Added meaningful Korean translations for telemetry and legal sections in README.ko.md, including privacy policy and terms of service links with clear user value.c91db2ebdocs(cli): add --vercel-ai-gateway flag documentation -- Added documentation for a new CLI flag --vercel-ai-gateway with clear description and default value, providing user value.e223ab20docs(configuration): add sisyphus-junior to agent list -- Added a new agent 'sisyphus-junior' to the documented list of available agents in the configuration guide, providing clear user value by informing users of an additional option.9342e55bdocs(installation): replace npx with bunx and update provider flags -- Updated installation docs to replace 'npx' with 'bunx' and added new provider flags with clear user instructions and value.05e54444docs(overview): update model-role claims and complete category list -- The commit updates documentation to reflect accurate model mappings and categories, adding clear value for users understanding the system's configuration and capabilities.7c94ee45docs(agent-model-matching): sync fallback chains with current source -- Updated fallback chains in documentation to match current source of truth in src/shared/model-requirements.ts, providing accurate information for users.b57a7975docs(ollama): verify troubleshooting steps and issue links -- Updated troubleshooting steps with verified issue links and clear documentation of a workaround, providing concrete user value.bbbd1bd0docs(orchestration): update diagram model names and category tables -- Updated documentation with clear, substantive changes including model fallback chains and category tables, enhancing user understanding and value.4ce1dde3CLI: isolate provider model id transforms from shared mocks -- Added meaningful tests for provider model ID transformations across multiple providers with clear expected outputs.1b36194bfix(cli): treat missing session status as idle in run completion -- Added a test case to handle missing session status as idle, ensuring the CLI doesn't hang indefinitely, and updated the logic in poll-for-completion.ts to return 'idle' when the session ID is missing from the statuses.b5250555fix(telemetry): guard PostHog init failures -- Adds meaningful test coverage for PostHog init failure handling, ensuring no-throw behavior for clients.0dab3116fix: resolve 3 bugs ([Bug]: non-interactive-env hook generates PowerShell $env: syntax on Git Bash (Windows) code-yeongyu/oh-my-openagent#3366, Agent name case change breaks Todo Continuation for historical sessions code-yeongyu/oh-my-openagent#3272, [Bug]: Using oh-my-opencode via bunx causes a new oh-my-openagent.json.bak.* backup file to be created on every OpenCode startup, even when no config changes were made. code-yeongyu/oh-my-openagent#3222) -- The commit fixes three concrete bugs with clear functional impact, including shell detection, legacy agent name resolution, and config backup optimization, all with direct user benefits.62c60ae9fix: numeric skill names, ultrawork missing run_in_background, ZWSP agent lookups -- The commit fixes concrete bugs with clear functional impact, including numeric skill name handling, missing 'run_in_background' parameter, and ZWSP agent lookup issues, all providing direct user benefits.76c5356atest(agent-config): add regression tests for agent merge priority order -- Adds meaningful regression tests for agent merge priority order with clear test cases covering various scenarios.da91c535fix(call-omo-agent): address cubic review findings and add requirement-based tests -- The commit fixes concrete issues, adds requirement-based tests, and improves agent resolution logic with clear user benefits.1e85a88dfix(agent-restrictions): restore EXPLORATION_AGENT_DENYLIST as default fallback for unknown agents -- Restores a default fallback for unknown agents, directly impacting agent restriction behavior with clear functional value.fd28f7e6feat(agents): add agent_definitions schema, eager path resolution, and JSON agent loader -- Adds agent_definitions schema, eager path resolution, and JSON agent loader with clear functional value and meaningful test coverage.5755a90cfeat(agents): add agent definitions file loader and opencode.json reader -- Adds agent definitions loader with multiple file format support, comprehensive tests, and clear functional value for loading and parsing agent configurations.39bda91bfeat(agents): wire agent_definitions and opencode.json agents into precedence chain -- The commit integrates agent_definitions and opencode.json agents into the precedence chain with clear functional value, adding new capabilities and meaningful tests.3d0fb22cfix(call-omo-agent): adapt dev's model override tests to use createMockCtx factory -- The commit fixes a concrete compatibility issue by adapting tests to use a new factory function, ensuring test validity after a code change.42445f51fix(agents): address cubic review findings on agent loader -- The commit addresses specific, concrete issues with agent loading, including case-insensitive file extension handling, relative path resolution, and precedence logic, with clear functional improvements and new tests.cf4b2315fix(agents): replace 'in' with Object.hasOwn() for prototype-safe property checks -- Replaced 'in' with Object.hasOwn() for prototype-safe property checks in opencode-config-agents-reader.ts to avoid skipping valid agent names that match inherited properties.4c77045cfix(agents): use null-prototype accumulator to prevent proto pollution -- The commit fixes a concrete security issue by preventing proto pollution using a null-prototype accumulator, directly improving the safety of property assignments and checks in the agent loader.e5d3fe96fix(agents): address all PR feat(call-omo-agent): support custom agents via dynamic resolution code-yeongyu/oh-my-openagent#2299 code review findings -- The commit addresses multiple concrete issues and improvements, including security fixes (prototype pollution prevention), functional enhancements (path resolution, caching), and test additions, all with clear value and no apparent slop.ab11f2ebfix(tests): replace mock.module with spyOn to prevent test pollution -- Replaced mock.module() with spyOn() to prevent test state pollution, ensuring tests are isolated and reliable.e1b2f97bfix: isPlanFamily regression tests, code-review -> review-work in test data (bug: isPlanFamily() substring matching false-positives Atlas/Metis/Momus display names code-yeongyu/oh-my-openagent#3312, [Bug]: Skill tool schema uses non-existent "code-review" as example instead of actual "review-work" skill code-yeongyu/oh-my-openagent#3285, transformModelForProvider missing anthropic provider — dash-format model IDs rejected by OpenCode code-yeongyu/oh-my-openagent#3290) -- The commit fixes a regression in test data by updating 'code-review' to 'review-work' in both test setup and expectation, and adds three new tests to ensure isPlanFamily correctly handles edge cases with false positives.47aa3025fix(cli): use getAgentRuntimeName for agent resolution in run command -- The commit fixes a concrete behavior issue by replacing 'getAgentDisplayName' with 'getAgentRuntimeName' for agent resolution in the run command, ensuring correct agent naming in the CLI.0764526afix(posthog): disable exception autocapture to stay within free tier -- Disables exception autocapture to stay within PostHog's free tier limit, preserving manual capture for critical errors.ccb2715afix: hide native plan agent when replace_plan is true ([Bug]: Native plan agent not hidden when replace_plan is true - Sisyphus routes to it instead of Prometheus code-yeongyu/oh-my-openagent#3443) -- The commit fixes a concrete behavior issue by hiding the native plan agent when replace_plan is true, preventing incorrect routing to the native plan agent instead of Prometheus, with clear functional benefit.a1842f2dfeat(tool-metadata): add shared metadata contract and bridge -- Adds a shared metadata contract and bridge with meaningful tests covering various scenarios, including round-trip persistence, casing insensitivity, and edge cases like blank or missing call IDs.80d3339cfeat(background-agent): add wait-for-task-session helper -- Adds a functional helperwaitForTaskSessionIDwith meaningful tests covering various scenarios, including immediate resolution, delayed resolution, abort signals, timeouts, and terminal task statuses.4da30057fix(plugin): harden metadata recovery and extraction -- The commit introduces meaningful functionality to extract session IDs from metadata, including legacy aliases, with clear tests and functional improvements across multiple hooks.c6a407c4refactor(tools): migrate producers to shared metadata bridge -- The commit refactors multiple files to migrate producers to a shared metadata bridge, replacingstoreToolMetadatawithpublishToolMetadataand removing redundantresolveCallIDlogic, indicating a clear architectural improvement with broad impact.7bc170fbfix: installer writes hyphenated anthropic IDs, variant=max Anthropic OAuth compat (variant: max sends output_config which breaks Claude Pro/Max OAuth authentication code-yeongyu/oh-my-openagent#3429, [Bug]: installer generates invalid Anthropic model IDs with dotted version suffixes code-yeongyu/oh-my-openagent#3459) -- The commit fixes a concrete behavior issue by updating model IDs to use hyphens for Anthropic OAuth compatibility, with clear functional benefit and multiple test scenario updates.Branch:
sync/upstream/v3.17.4-good(local only; not on origin)🟡 Review batch
Ambiguous. Human should review before merging.
569addd3docs(provider): add comments to vercel transform logic -- Classification failed: No object generated: response did not match schema.Branch:
sync/upstream/v3.17.4-needs-review(local only; not on origin)🔴 Slop batch
Classified as AI slop or pointless churn. Do not merge as-is; rewrite intent if salvageable.
1e2e0019refactor(create-tools): keep result type internal -- The commit changes the visibility ofCreateToolsResultfromexportto internal without any clear functional or architectural benefit, indicating minor visibility churn.9d89bbb0refactor(commands): keep builtin command options internal -- Changed LoadBuiltinCommandsOptions from export to internal without clear functional or architectural benefit, indicating minor visibility churn.0c5cd3a1chore(agents): update all AGENTS.md generation dates to 2026-04-11 -- The commit only updates generation dates in multiple AGENTS.md files without adding any new functionality, documentation, or fixes, indicating date metadata churn.e654cfb4@ahuangsnail has signed the CLA in fix: treat zero limit.output as unknown to enable fallback to bundled… code-yeongyu/oh-my-openagent#3316 -- The commit only adds a CLA signature entry to cla.json without any code or functional changes.79a475d6refactor(background-agent): simplify loop detector null guard -- The commit simplifies a null guard from explicit null and undefined checks to a single '== null' check, which is a minor visibility-only change with no clear functional or architectural benefit.cd8352c1refactor(claude-code-mcp-loader): simplify env expansion null guard -- The commit simplifies a null guard from explicit null and undefined checks to a single '== null' check, which is a minor visibility-only change with no clear functional or architectural benefit.6713b30crefactor(hooks): drop no-op directory injector callbacks -- Removes unused 'tool.execute.before' callback with no functional impact, classified as minor churn.21cad26cdocs(config): remove redundant schema default comments -- Removed redundant schema default comments, which is considered docs_churn as it only updates metadata without adding new information.141798efrefactor(background-agent): standardize loop detector null guards -- The commit replaces explicit null and undefined checks with a single '== null' check, which is a minor visibility-only change with no clear functional or architectural benefit, aligning with the 'refactor_churn' category.6a0d515d@divlook has signed the CLA in fix: align GitHub Copilot model variants with catalog code-yeongyu/oh-my-openagent#3353 -- The commit only adds a CLA signature to cla.json, which is administrative noise with no code or product value.5b33cd22@lrq3000 has signed the CLA in docs(install): Update installation commands for humans in documentation to oh-my-openagent code-yeongyu/oh-my-openagent#3358 -- The commit only adds a CLA signature to cla.json, which is administrative noise with no code or product value.c6deb6d6@Zireael has signed the CLA in fix: detect Git Bash/WSL/MSYS2 shell on Windows (non-interactive-env hook) code-yeongyu/oh-my-openagent#3370 -- Commit adds a CLA signature to cla.json, which is administrative noise with no code or product value.42df1c3c@FuDesign2008 has signed the CLA in fix(agent-key): restore getAgentDisplayName for HTTP-header-safe agent keys code-yeongyu/oh-my-openagent#3371 -- Commit only adds a CLA signature to cla.json, which is administrative noise with no code or product value.84f980c9@matchai has signed the CLA in feat(provider): add Vercel AI Gateway support code-yeongyu/oh-my-openagent#3376 -- Commit only adds a CLA signature to cla.json, which is administrative noise with no code or product value.678011c7docs(contributing): update tool/hook counts and version references -- The commit updates counts and version references in the contributing docs without adding new information or functionality.cfd152addocs(features): update agent count and verify category list -- Added two new features ('review-work' and 'ai-slop-remover') with overly broad, vague descriptions lacking concrete user value or clear behavior delta.0cb0a6c0docs(contributing): update tool/hook counts and version references -- Updated counts and version references in docs without adding new information or functionality.3419bbc4@mauriciozaffari has signed the CLA in fix: recognize 'hit your limit' as retryable error pattern code-yeongyu/oh-my-openagent#3398 -- The commit only adds a CLA signature to cla.json, which is administrative noise with no code or product value.1bb59c3erelease: v3.17.2 -- The commit only updates version numbers in package.json files across multiple platforms, which is administrative noise with no code or product value.571cf1f1@kywoo26 has signed the CLA in fix(background-agent): skip unavailable fallback models code-yeongyu/oh-my-openagent#3402 -- The commit only adds a CLA signature to cla.json, which is administrative noise with no code or product value.f98f7ec7@garnetlyx has signed the CLA in feat: Task ID semantics and lifecycle integrity (#3404, #3405) code-yeongyu/oh-my-openagent#3409 -- The commit only adds a CLA signature to cla.json, which is administrative noise with no code or product value.d97c067d@lightrabbit has signed the CLA in fix(skill-mcp): pass workspace directory as cwd to stdio MCP processes code-yeongyu/oh-my-openagent#3415 -- The commit only adds a CLA signature to cla.json, which is administrative noise with no code or product value.eaf5ff21@fr1sk has signed the CLA in fix(agent-display): remove ZWSP sort prefixes that truncate agent names in terminals code-yeongyu/oh-my-openagent#3419 -- The commit only adds a CLA signature to cla.json, which is administrative noise with no code or product value.f8f7ac10@grandmaster451 has signed the CLA in fix(auto-update): use semantic version comparison instead of string e… code-yeongyu/oh-my-openagent#3420 -- The commit only adds a CLA signature to cla.json, which is administrative noise with no code or product value.54a94d41@kithawk has signed the CLA in Fix primary agent model precedence code-yeongyu/oh-my-openagent#3428 -- The commit only adds a CLA signature to cla.json, which is administrative noise with no code or product value.81a03fa9@orbisai0security has signed the CLA in fix: upgrade express-rate-limit to 8.2.2, 8.1.1, 8.0.2 (CVE-2026-30827) code-yeongyu/oh-my-openagent#3440 -- The commit only adds a CLA signature to cla.json, which is administrative noise with no code or product value.9aeb87c2chore: bump version to 3.17.3 -- The commit only updates the version number in package.json with no functional changes.80e73f57@CHLK has signed the CLA in fix(cli-run): prevent premature exit when background tasks are active code-yeongyu/oh-my-openagent#3455 -- The commit only adds a CLA signature to cla.json, which is administrative noise with no code or product value.fe091ef2chore: bump version to 3.17.4 -- The commit only updates the version number in package.json with no functional changes.c9350c67release: v3.17.4 -- The commit only updates version numbers in multiple package.json files with no functional changes, constituting date/count metadata churn.Branch:
sync/upstream/v3.17.4-slop(on origin)Slop verifier second-pass notes
1e2e001CONFIRMED_SLOP (behavior delta: none): The commit changes the visibility ofCreateToolsResultfromexportto internal without any clear functional or architectural benefit, indicating minor visibility churn. There's no concrete behavior delta, and the change does not strengthen or weaken any invariant. The commit message accurately reflects the change but lacks justification for why this internalization is necessary or beneficial. A senior engineer would likely question the value of this change without further context on planned usage or dependencies that require this visibility adjustment.9d89bbbCONFIRMED_SLOP (behavior delta: none): The commit changes the visibility of LoadBuiltinCommandsOptions from export to internal without clear functional or architectural benefit, indicating minor visibility churn. No runtime behavior changes, and the abstraction's scope remains unchanged. A senior engineer would likely question the value of this change without further context on intended future use or constraints.0c5cd3aCONFIRMED_SLOP (behavior delta: none): The commit only updates generation dates in multiple AGENTS.md files without adding any new functionality, documentation, or fixes. This is a clear case of date metadata churn, which is classified as SLOP according to the guidelines. There is no concrete behavior delta, and the change does not provide any measurable value or improvement.e654cfbCONFIRMED_SLOP (behavior delta: none): The commit only adds a CLA signature entry to cla.json without any code or functional changes, aligning with 'cla_admin' slop signals. No behavior delta exists as it's administrative noise. A senior engineer would not defend this as value-adding in a code review focused on merge value for this fork.79a475dCONFIRMED_SLOP (behavior delta: none): The commit simplifies a null guard from explicit checks to '== null', which is a minor visibility change with no clear functional or architectural benefit. The first-pass correctly identified this as refactor_churn with high confidence. No concrete behavior delta exists beyond stylistic change, and no new abstractions or value are added. A senior engineer would likely question the necessity of this change without broader impact.cd8352cCONFIRMED_SLOP (behavior delta: none): The commit simplifies a null guard from explicit checks to '== null', which is a minor visibility change with no clear functional or architectural benefit. The first-pass reason correctly identifies this as refactor_churn with no concrete value. No behavior delta exists beyond stylistic change.6713b30CONFIRMED_SLOP (behavior delta: none): The commit removes unused 'tool.execute.before' callbacks in two hook files, which the first-pass classified as refactor_churn with no functional impact. Upon review, the removed code had no behavior delta (voided inputs/outputs, no side effects), and the change is purely a cleanup of unused code. While removing dead code is generally positive, in this context, it lacks a concrete benefit (e.g., performance gain, readability improvement for maintained code) that would justify demoting from SLOP. The commit message accurately reflects the change but does not provide a measurable justification for the refactor. A senior engineer might defend it as minor hygiene, but without a clear value proposition, it aligns with the initial SLOP verdict.21cad26CONFIRMED_SLOP (behavior delta: none): The commit removes redundant schema default comments, which is classified as docs_churn. The changes do not affect runtime behavior, user-visible output, or invariants. The commit message accurately reflects the change, but it does not add new information or value beyond metadata updates. A senior engineer might question the necessity of this change as it doesn't provide clear benefits or prepare for future functionality. The first-pass verdict correctly identifies this as SLOP due to the lack of concrete value addition.141798eCONFIRMED_SLOP (behavior delta: none): The commit replaces explicit null and undefined checks with a single '== null' check, which is a minor visibility-only change with no clear functional or architectural benefit. This aligns with 'refactor_churn' as it does not introduce new behavior, improve performance, or fix a bug. The change simplifies the code slightly but does not provide substantial value.6a0d515CONFIRMED_SLOP (behavior delta: none): The commit only adds a CLA signature to cla.json, which is administrative noise with no code or product value. This aligns with the 'cla_admin' slop signal and does not provide any concrete behavior delta, abstraction, or user-visible change. The first-pass verdict correctly identifies it as SLOP.5b33cd2CONFIRMED_SLOP (behavior delta: none): The commit adds a CLA signature to cla.json, which is purely administrative with no impact on code or product functionality. This aligns with the 'cla_admin' slop signal and does not introduce any behavior delta.c6deb6dCONFIRMED_SLOP (behavior delta: none): The commit adds a CLA signature to cla.json, which is purely administrative and does not introduce any code or product value. This aligns with the 'cla_admin' slop signal. There is no behavior delta, and the change does not strengthen or weaken any invariants. The commit message accurately reflects the administrative update but does not justify merge value under the fork's rubric.42df1c3CONFIRMED_SLOP (behavior delta: none): The commit only adds a CLA signature to cla.json, which is administrative noise with no direct code or product value. This matches the 'cla_admin' category, which is explicitly non-mergable as per the verification bias rules. No behavior delta exists as it doesn't alter runtime code or user-visible output.84f980cCONFIRMED_SLOP (behavior delta: none): The commit only adds a CLA signature to cla.json, which is administrative noise with no direct code or product value. The change does not alter any runtime behavior, user-visible output, or invariants. It fits the cla_admin category, which is excluded from being demoted to GOOD by the verification bias rules.678011cCONFIRMED_SLOP (behavior delta: none): The commit updates counts and version references in the contributing docs without adding new information or functionality. These changes are metadata-only and do not introduce any behavioral delta, new features, or bug fixes. The first-pass verdict correctly identifies this as SLOP due to the nature of the updates being purely informational and not enhancing the project's functionality or correctness.cfd152aCONFIRMED_SLOP (behavior delta: none): The commit adds two features with vague descriptions lacking clear user value or measurable metrics. 'review-work' and 'ai-slop-remover' do not specify how they enhance existing functionality or introduce new behavior deltas beyond generic claims. No concrete behavior delta is evident, and the descriptions rely on buzzwords without concrete examples or metrics.0cb0a6cCONFIRMED_SLOP (behavior delta: none): The commit updates counts and version references in documentation without adding new information or functionality. The changes are purely numerical and do not introduce any new concepts, explanations, or value beyond keeping numbers current. This aligns with the first-pass reason that the update expands existing content without new facts.3419bbcCONFIRMED_SLOP (behavior delta: none): The commit only adds a CLA signature to cla.json, which is administrative noise with no code or product value. This matches the 'cla_admin' category, which is explicitly excluded from being demoted to GOOD. No behavior delta exists as it doesn't alter runtime code or user-visible output.1bb59c3CONFIRMED_SLOP (behavior delta: none): The commit only updates version numbers in multiple package.json files, which is classified as release_version_bump, a type of administrative noise with no direct code or product value. There is no concrete behavior delta, and the change does not introduce new functionality, fixes, or tests. The first-pass verdict correctly identifies this as SLOP following the guidelines.571cf1fCONFIRMED_SLOP (behavior delta: none): The commit only adds a CLA signature to cla.json, which is administrative noise with no code or product value. This matches the 'cla_admin' category, which is explicitly excluded from being demoted to GOOD. There is no behavior delta, no new functionality, and the change does not impact any runtime code path or user-visible output.f98f7ecCONFIRMED_SLOP (behavior delta: none): The commit only adds a CLA signature to cla.json, which is administrative noise with no code or product value. The change does not affect any runtime behavior, user-visible output, or invariants. It falls under the 'cla_admin' category, which is explicitly excluded from being demoted to GOOD by the verification bias rules.d97c067CONFIRMED_SLOP (behavior delta: none): The commit only adds a CLA signature to cla.json, which is administrative noise with no code or product value. This matches the 'cla_admin' category, which is explicitly non-GOOD by the verification bias rules. No behavior delta exists as it doesn't alter runtime code or user-visible output.eaf5ff2CONFIRMED_SLOP (behavior delta: none): The commit only adds a CLA signature to cla.json, which is administrative noise with no code or product value. The change does not affect any runtime behavior, abstractions, or user-visible output. It aligns with the 'cla_admin' category, which is explicitly non-GOOD by the verification bias rules.f8f7ac1CONFIRMED_SLOP (behavior delta: none): The commit only adds a CLA signature to cla.json, which is administrative noise with no code or product value. The first-pass verdict correctly identifies it as cla_admin, a category excluded from being demoted to GOOD by the verification bias rules.54a94d4CONFIRMED_SLOP (behavior delta: none): The commit only adds a CLA signature to cla.json, which is administrative noise with no code or product value. The first-pass verdict correctly identifies this as cla_admin, a category excluded from being demoted to GOOD by the verification bias. There is no concrete behavior delta, and the change does not improve functionality or user experience in any way.81a03faCONFIRMED_SLOP (behavior delta: none): The commit only adds a CLA signature to cla.json, which is administrative noise with no code or product value. This aligns with the 'cla_admin' slop signal and does not provide any concrete behavior delta or value to the repository's functionality.9aeb87cCONFIRMED_SLOP (behavior delta: none): The commit only updates the version number in package.json with no functional changes, aligning with the 'release_version_bump' slop pattern. No behavior delta exists as it's purely administrative. The first-pass verdict correctly identifies this as SLOP based on the provided guidelines.80e73f5CONFIRMED_SLOP (behavior delta: none): The commit adds a CLA signature to cla.json, which is purely administrative noise with no impact on code or product functionality. The first-pass verdict correctly identifies this as cla_admin, a category excluded from being demoted to GOOD by the verification bias. There is no concrete behavior delta, and the change does not introduce any new functionality or improvements.fe091efCONFIRMED_SLOP (behavior delta: none): The commit only updates the version number in package.json with no functional changes, aligning with the 'release_version_bump' slop pattern. No behavior delta exists as it's purely administrative. First-pass verdict is correct given the guidelines.c9350c6CONFIRMED_SLOP (behavior delta: none): The commit only updates version numbers in multiple package.json files with no functional changes, constituting date/count metadata churn, which is explicitly categorized as SLOP under the given rubric. No behavior delta exists as the changes are purely metadata updates. The commit message accurately reflects the change but does not justify merging value. A senior engineer would likely not defend this as valuable in a code review focused on functional or behavioral changes.Fork-sync impact assessment
Breaking changes
(none detected)
Dependency changes
(none)
Architecture drift
(none)
Hidden concerns
Action items before merging
use spyOn instead of vi.mockandcentralize name normalization.Generated by
upstream-analyzerworkflow. This issue is advisory: no merges or publishes happen automatically. Phase 1: draft PRs only. The prompt lives in.github/prompts/and is editable without touching workflow code.Classify chain:
openrouter:qwen/qwen3-coder:free → nvidia:nvidia/llama-3.3-nemotron-super-49b-v1 → github:openai/gpt-4.1-miniSlop-verify chain:
openrouter:nvidia/nemotron-3-super-120b-a12b:free → nvidia:nvidia/llama-3.3-nemotron-super-49b-v1 → github:openai/gpt-4.1Synthesis chain:
openrouter:nvidia/nemotron-3-super-120b-a12b:free → nvidia:nvidia/llama-3.3-nemotron-super-49b-v1 → github:openai/gpt-4.1