Skip to content

🟡 Upstream v3.17.0 → v3.17.4: CHERRY_PICK (slop 23%) #47

Open
Open
🟡 Upstream v3.17.0 → v3.17.4: CHERRY_PICK (slop 23%)#47
Labels
cost-benefitupstream-reviewupstream-tag:v3.17.4upstream:cherry-pick
@github-actions

Description

@github-actions
github-actions
bot
opened on Apr 21, 2026

🟡 Upstream cost-benefit: v3.17.0 → v3.17.4

Upstream: code-yeongyu/oh-my-openagent
Recommendation: CHERRY_PICK (confidence: medium)
Slop ratio: 23%

The release from v3.17.0 to v3.17.4 contains a significant number of GOOD commits (87 out of 116) with tangible value, including critical bug fixes, documentation improvements, and refactorings with clear benefits. However, the slop ratio (~23%) indicates a notable amount of non-value or low-value changes. Notably, administrative noise (e.g., CLA signatures, version bumps) and minor refactor churn are present. While there are no reported breaking changes or dependency conflicts, the mix of valuable and non-valuable changes warrants selective incorporation. Recommended Action: Cherry-pick the explicitly valued GOOD commits, while subjecting the SLOP and NEEDS_REVIEW commits to human evaluation for potential inclusion.

Batch classification

Verdict Count Branch
🟢 GOOD 87 sync/upstream/v3.17.4-good
🟡 NEEDS_REVIEW 2 sync/upstream/v3.17.4-needs-review
🔴 SLOP 27 sync/upstream/v3.17.4-slop

🟢 Good batch

Classified as real value. Candidate for merge.

  • ad85e438 fix: include user/project agents in task(subagent_type) resolution -- Adds user/project agents to task resolution with clear logic, precedence rules, and 4 targeted tests covering core scenarios.
  • 2266f28f fix: correct merge order so project agents override user agents -- The commit fixes a specific behavior issue by correcting the merge order of project and user agents, ensuring project agents override user agents when names collide, with clear tests added to validate this logic.
  • 64408823 fix: actually swap merge order so project is added before user -- The commit fixes a specific behavior issue by swapping the merge order of project and user agents, ensuring project agents take precedence, with clear tests validating this logic.
  • 5441c848 refactor: use spyOn instead of vi.mock for agent loader mocks -- The commit replaces vi.mock with spyOn for agent loader mocks, which is a clear refactor with a specific, justified purpose (being more idiomatic for bun:test as per PR review), directly improving test setup clarity and maintainability.
  • b0b19f30 fix(grep): handle Windows drive-letter paths and CRLF in parseOutput -- Fixes concrete behavior issues on Windows by updating regex patterns to handle drive-letter paths and CRLF line endings, resolving a known bug (Closes [Bug]: Grep tool content mode always returns 'No matches found' on Windows — drive letter breaks regex parsing code-yeongyu/oh-my-openagent#2962).
  • e9b6bba1 refactor(agent-display): centralize name normalization resolution -- The commit centralizes name normalization for agent displays, adds tests for legacy name conversion and prefix stripping, and refactors the resolution logic with clear functional benefits.
  • f95e7a6c refactor(openclaw): reuse shared gateway url validation -- The commit refactors the code to reuse a shared gateway URL validation function, removing duplicated logic and improving maintainability.
  • 40411f32 docs(agents): add AGENTS.md documentation for prometheus, hephaestus, sisyphus variants, and builtin-skills -- Added substantial documentation for multiple agents and skills with clear, detailed explanations and structure.
  • 21822ba2 test(openclaw): cover shared gateway url validation -- Adds meaningful test coverage for gateway URL validation scenarios, including HTTPS, local HTTP, and invalid URLs.
  • a2ae3de3 refactor(openclaw): extract gateway url validator -- Extracted a reusable function validateGatewayUrl, reducing code duplication and improving maintainability.
  • 69f1c9ae fix(doctor): add timeouts to subprocess spawns to prevent exit code 137 -- Adds timeouts to subprocess spawns to prevent hanging processes and SIGKILL (exit code 137), introducing a clear fix for a specific reliability issue.
  • 314e1a5e fix(telemetry): enable GeoIP resolution for PostHog events -- Explicitly enables GeoIP resolution for PostHog events by setting disableGeoip to false, which adds clear value for geographic analytics.
  • d21ed3f7 fix(doctor): add timeouts to subprocess spawns to prevent exit code 137 -- Adds timeouts to subprocess spawns to prevent hanging processes and SIGKILL (exit code 137), introducing a clear fix for a specific reliability issue.
  • 565d3ffa fix(ci): build darwin binaries on macOS runners to restore code signing -- The commit fixes a concrete CI issue by routing darwin platforms to macOS runners for native compilation and adds an explicit ad-hoc codesign step to restore code signing, directly addressing a specific problem causing macOS Gatekeeper rejections.
  • 71b5ab67 fix(ci): replace breaking codesign step with signature verification -- The commit replaces a breaking codesign step in the CI workflow with a signature verification, addressing a specific issue with 'invalid or unsupported format for signature' errors by leveraging the native macOS build's valid ad-hoc signature.
  • 16e7fa5b fix(ci): ad-hoc sign darwin binaries with plain codesign -- The commit fixes a concrete CI issue by explicitly signing Darwin binaries with 'codesign --sign -' to address a lack of default linker-signed signatures on GitHub macOS runners.
  • 470ed8b1 fix(ci): remove existing signature before ad-hoc signing darwin binary -- The commit fixes a concrete CI issue by removing an existing malformed signature before applying a fresh ad-hoc signature to Darwin binaries, directly addressing a specific problem.
  • 2d65896b refactor(shared): simplify normalize SDK null guards -- Simplifies null checks in normalizeSDKResponse from two separate checks to a single '== null' check, improving readability without changing behavior.
  • cd8352c1 refactor(claude-code-mcp-loader): simplify env expansion null guard -- The commit simplifies a null guard from two separate checks to a single '== null' check, which is a minor visibility change with no clear functional or architectural benefit, fitting the 'refactor_churn' category. | Verifier: The commit simplifies a null guard from two separate checks to a single '== null' check, which is a minor but legitimate refactor that improves code readability and maintainability. While the first-pass classified it as 'refactor_churn', this change has clear, albeit minor, value in reducing redundancy and aligning with common null checking practices. A senior engineer could defend this as a minor improvement in code quality.
  • 50df6f0d test(claude-code-plugin-loader): cover plugin path nullish resolution -- Adds meaningful test coverage for plugin path resolution, including nullish input handling.
  • 668bc8e8 refactor(config-manager): simplify config parsing guards -- The commit simplifies redundant null checks in parseOpenCodeConfigFileWithError and adds meaningful test coverage for config parsing edge cases.
  • a0d5131e refactor(plugin): remove dead chat params code -- Removes unused 'variant' parameter and dead code related to it in chat-params.ts, simplifying the buildChatParamsInput function.
  • 21cad26c docs(config): remove redundant schema default comments -- Removed redundant default value comments in schema definitions, improving documentation clarity.
  • 4de02094 test(background-agent): lock nullish loop detector behavior -- Adds meaningful test coverage for nullish input handling in loop detector behavior, ensuring consistent handling of null and undefined inputs.
  • e71c34ac fix(migration): return true when canonical config write succeeds regardless of archive status ([Bug]: v3.15.1 still inconsistently loads/migrates plugin config after rename code-yeongyu/oh-my-openagent#3133) -- Fixes a concrete behavior issue where migration incorrectly reported failure due to secondary archive status, despite successful canonical config write.
  • 7accb53c fix(shared): handle Windows rename-over-existing in write-file-atomically ([Bug]: Using oh-my-opencode via bunx causes a new oh-my-openagent.json.bak.* backup file to be created on every OpenCode startup, even when no config changes were made. code-yeongyu/oh-my-openagent#3222) -- Fixes a concrete behavior issue on Windows by handling rename-over-existing errors in write-file-atomically, with clear platform-specific logic and added tests.
  • 9ef133a8 fix(migration): register parenthesized legacy agent aliases in AGENT_NAME_MAP ([Bug]: Header 'x-opencode-agent-name' has invalid value: '​Atlas (Plan Executor)' code-yeongyu/oh-my-openagent#3281) -- Adds concrete mappings for legacy agent aliases and tests for migration correctness, addressing a specific compatibility issue.
  • a6e4f211 fix(shared): normalize claude model IDs for anthropic provider (transformModelForProvider missing anthropic provider — dash-format model IDs rejected by OpenCode code-yeongyu/oh-my-openagent#3290) -- Fixes a concrete compatibility issue by normalizing model IDs for Anthropic API, with clear necessity and direct impact on functionality.
  • 4f02ace7 fix(shared): guard maxOutputTokens <= 0 in model settings compatibility ([Bug]: Invalid argument for parameter maxOutputTokens: maxOutputTokens must be >= 1 code-yeongyu/oh-my-openagent#3305) -- Fixes a concrete behavior issue where invalid maxOutputTokens (<=0) in model metadata would break generation by preserving user-requested maxTokens.
  • c750781b fix(shared): avoid false-positive skill path resolution on npm scoped packages ([Bug]: Why my command run with error path? code-yeongyu/oh-my-openagent#2857) -- The commit fixes a concrete behavior issue by adjusting a regex to avoid false positives with npm scoped packages, adding a specific test case to validate the fix.
  • d7b4bec5 fix(hooks,tools): replace /plan example with prometheus delegation and rename code-review example to review-work (Error message references non-existent /plan command code-yeongyu/oh-my-openagent#2633, [Bug]: Skill tool schema uses non-existent "code-review" as example instead of actual "review-work" skill code-yeongyu/oh-my-openagent#3285, [Bug]: oh-my-openagent overrides built-in tools to bypass the permission system. code-yeongyu/oh-my-openagent#2873) -- The commit fixes concrete behavior issues by replacing a non-existent command reference with a valid Prometheus delegation and renaming a non-existent skill to a real one, with clear user value and functional impact.
  • 7e96af5f fix(atlas): exclude node_modules from verification git diff --stat ([Feature]: Ensure gitignore is created before starting implementation code-yeongyu/oh-my-openagent#3215) -- The commit fixes a concrete behavior issue by excluding node_modules from git diff verification, with clear necessity and direct impact on functionality.
  • 2d8b4a9d fix(anthropic-effort): skip effort injection for github-copilot provider ([Bug]: code-yeongyu/oh-my-openagent#3270) -- The commit fixes a concrete behavior issue by adding an explicit guard to skip effort injection for the github-copilot provider, preserving native Anthropic provider support, with clear necessity and direct impact on functionality.
  • 796a646c fix(non-interactive-env): use detectShellType instead of hardcoded win32 check ([Bug]: Force PowerShell env behavior in Windows code-yeongyu/oh-my-openagent#3310, Bug: PowerShell env var syntax ($env:VAR) used in bash shell on Windows code-yeongyu/oh-my-openagent#3338) -- The commit replaces a hardcoded win32 check with detectShellType(), adding tests for various shell environments (PowerShell, Git Bash, WSL, cmd) on Windows and Linux, ensuring correct command syntax based on actual shell type.
  • 64e55936 fix(multimodal-looker): instruct explicit Read tool usage for PDFs (Multimodal-Looker Cannot Read PDF Files code-yeongyu/oh-my-openagent#2998) -- Added explicit instruction for PDF handling to ensure files are loaded before extraction, addressing a specific functional gap.
  • d8b9bf1a fix(doctor): check comment-checker lazy-download cache path ([Question]: comment-checker not found code-yeongyu/oh-my-openagent#2911, [Bug] comment-checker hook does not trigger code-yeongyu/oh-my-openagent#3315) -- The commit fixes a concrete behavior issue by aligning the doctor's resolution order with runtime, ensuring cached binaries are recognized as installed.
  • 3bfa3bd6 fix(background-agent): pass query directory to session.get in 4 call-sites ([Bug]: resolveSubagentSpawnContext fails to find project-scoped sessions — client.session.get() missing directory parameter code-yeongyu/oh-my-openagent#2937) -- The commit fixes a concrete behavior issue by passing the query directory to session.get in multiple call-sites, resolving 404 errors under newer OpenCode SDK versions.
  • eb495793 fix(event): prefer real session.idle over recent synthetic dedup ([Bug]: The model has responded normally, but there is a red alert in the input box: [TODO-DIAG] BLOCKED: no todossession.idle event code-yeongyu/oh-my-openagent#2667) -- The commit fixes a concrete behavior issue by adjusting the deduplication logic to prioritize real session.idle events over synthetic ones, ensuring downstream hooks receive necessary data.
  • aed8dbfa fix(delegate-task): fetch session result before honoring abort signal ([Bug]: @explore subagent completes but parent never returns result; 3.12.3 aborts with "The operation was aborted." code-yeongyu/oh-my-openagent#2702) -- Fixes a concrete behavior issue by fetching session results before honoring abort signals, preventing premature 'Task aborted' messages when results are available.
  • c5c5bc36 fix(delegate-task): consume fallback chain on sendSyncPrompt failure (delegate-task: No automatic retry with fallback models when subagent fails due to model error code-yeongyu/oh-my-openagent#2691) -- The commit fixes a concrete behavior issue by implementing a retry mechanism with a fallback chain for failed sendSyncPrompt calls, directly improving functionality and error handling.
  • 3d2eb6e4 fix(config): preserve explicit git_master overrides during merge -- Adds meaningful test coverage for preserving explicit git_master settings during config merge, addressing a specific functional requirement with clear behavior delta.
  • dac0c99e feat: add Vercel AI Gateway as a provider -- Adds Vercel AI Gateway as a recognized provider with clear integration and fallback logic for multiple models, directly enhancing user capabilities.
  • aac17135 test: add vercel provider transform tests -- Adds meaningful test coverage for Vercel provider transformations with multiple specific scenarios
  • 6f72ec75 test: add integration tests for Vercel AI Gateway model resolution -- Adds integration tests for Vercel AI Gateway model resolution with specific scenarios and assertions, increasing test coverage for a real feature.
  • 542dc890 fix(provider): use gateway-specific model IDs for vercel transform -- Fixes model ID transformation for Vercel AI Gateway by removing '-preview' suffix for 'gemini-3-flash' as per gateway's specific requirements, with clear behavioral change and direct impact on functionality.
  • 34e334ea feat(provider): add vercel to all gateway-supported fallback entries -- Adds vercel provider fallback entries with clear integration and fallback logic for multiple models, enhancing user capabilities.
  • effae16c refactor(provider): replace per-model string replacements with generic regex -- Replaces multiple per-model string replacements with a generic regex, simplifying code and making it more maintainable for new models.
  • 680d05a2 Prometheus: keep planner primary-only -- Changes Prometheus agent mode from 'all' to 'primary' across multiple tests and config builders, aligning with the stated goal of keeping the planner primary-only, with clear behavioral impact.
  • e3b5c2be fix: address review feedback for Vercel AI Gateway PR -- Adds Vercel AI Gateway integration with CLI option, priority adjustment, and test updates, providing clear user value and behavioral changes.
  • 01a1b141 fix(delegate-task): reject primary agents in task subagent resolution -- The commit introduces a clear behavioral change by rejecting primary agents in task subagent resolution, with multiple new functions and logic additions that directly impact functionality and user capability.
  • 3673b962 docs(readme-ru): add telemetry and legal section translation -- Adds meaningful Russian translations for telemetry and legal sections in README.ru.md, including privacy policy and terms of service links with clear user value.
  • 23d0a0dc docs(readme-zh-cn): add telemetry and legal section translation -- Adds meaningful Chinese translations for telemetry and legal sections in README.zh-cn.md, including privacy policy and terms of service links with clear user value.
  • 0ece66e3 docs(readme-ja): add telemetry and legal section translation -- Adds meaningful Japanese translations for telemetry and legal sections in README.ja.md, including privacy policy and terms of service links with clear user value.
  • 12ed9501 docs(readme-ko): add telemetry and legal section translation -- Adds meaningful Korean translations for telemetry and legal sections in README.ko.md, including privacy policy and terms of service links with clear user value.
  • c91db2eb docs(cli): add --vercel-ai-gateway flag documentation -- Adds documentation for a new CLI flag --vercel-ai-gateway with clear description and default value, providing user value.
  • e223ab20 docs(configuration): add sisyphus-junior to agent list -- Added a new agent 'sisyphus-junior' to the list of available agents in the configuration documentation, providing clear user value by expanding the set of configurable options.
  • 9342e55b docs(installation): replace npx with bunx and update provider flags -- Updated installation docs to reflect 'bunx' usage and added relevant provider flags with clear user value.
  • 05e54444 docs(overview): update model-role claims and complete category list -- The commit updates the documentation to reflect accurate and expanded category lists and model mappings, providing clear user value by enhancing understanding of the system's capabilities.
  • 7c94ee45 docs(agent-model-matching): sync fallback chains with current source -- Updated fallback chains in agent documentation to include 'vercel' provider paths, reflecting current runtime configurations with clear user value.
  • b57a7975 docs(ollama): verify troubleshooting steps and issue links -- Updated troubleshooting steps with verified issue links and clear documentation improvements
  • bbbd1bd0 docs(orchestration): update diagram model names and category tables -- The commit updates documentation with new, specific, and informative content (e.g., model fallback chains, category tables) that enhances user understanding and provides clear value.
  • 4ce1dde3 CLI: isolate provider model id transforms from shared mocks -- Added meaningful tests for model ID transformations across multiple providers with clear expected outputs.
  • 1b36194b fix(cli): treat missing session status as idle in run completion -- The commit fixes a concrete behavior issue by treating missing session status as idle, preventing indefinite hanging, with clear test coverage added.
  • b5250555 fix(telemetry): guard PostHog init failures -- Adds meaningful test coverage for PostHog init failure scenarios, ensuring no-throw behavior for clients.
  • 0dab3116 fix: resolve 3 bugs ([Bug]: non-interactive-env hook generates PowerShell $env: syntax on Git Bash (Windows) code-yeongyu/oh-my-openagent#3366, Agent name case change breaks Todo Continuation for historical sessions code-yeongyu/oh-my-openagent#3272, [Bug]: Using oh-my-opencode via bunx causes a new oh-my-openagent.json.bak.* backup file to be created on every OpenCode startup, even when no config changes were made. code-yeongyu/oh-my-openagent#3222) -- The commit fixes three concrete bugs with clear functional impact, including detecting Git Bash via MSYSTEM, resolving legacy agent names, and optimizing config backups.
  • 62c60ae9 fix: numeric skill names, ultrawork missing run_in_background, ZWSP agent lookups -- The commit fixes concrete bugs with clear functional impact, including coercing numeric skill names to strings, adding a required parameter to task examples, and stripping ZWSP from agent names for accurate lookups.
  • 76c5356a test(agent-config): add regression tests for agent merge priority order -- Adds meaningful regression tests for agent merge priority order with clear test cases and expected outcomes.
  • da91c535 fix(call-omo-agent): address cubic review findings and add requirement-based tests -- The commit fixes concrete issues, adds meaningful tests, and improves functionality with clear value.
  • 1e85a88d fix(agent-restrictions): restore EXPLORATION_AGENT_DENYLIST as default fallback for unknown agents -- Restores a default fallback for unknown agents, fixing a functional gap in agent restrictions with clear behavior delta.
  • fd28f7e6 feat(agents): add agent_definitions schema, eager path resolution, and JSON agent loader -- Adds agent_definitions schema, eager path resolution, and JSON agent loader with comprehensive test suite and clear functional value.
  • 5755a90c feat(agents): add agent definitions file loader and opencode.json reader -- Adds agent definitions loader with comprehensive test coverage (23 tests) and refactors loader.ts with clear simplification (reducing LOC by 50)
  • 39bda91b feat(agents): wire agent_definitions and opencode.json agents into precedence chain -- The commit integrates agent_definitions and opencode.json agents into the precedence chain with clear functional value, adding new capabilities, detailed logging, and filtering logic, backed by 7 new integration tests.
  • 3d0fb22c fix(call-omo-agent): adapt dev's model override tests to use createMockCtx factory -- The commit fixes a concrete compatibility issue by adapting tests to use a new factory function, ensuring test validity after a deliberate architectural change.
  • 42445f51 fix(agents): address cubic review findings on agent loader -- The commit addresses specific, concrete issues with agent loading, including case-insensitive file extension handling, correct path resolution, and precedence logic, with clear functional improvements and new tests.
  • cf4b2315 fix(agents): replace 'in' with Object.hasOwn() for prototype-safe property checks -- Replaced 'in' with Object.hasOwn() for prototype-safe property checks in opencode-config-agents-reader.ts, addressing a concrete issue with inherited properties.
  • 4c77045c fix(agents): use null-prototype accumulator to prevent proto pollution -- The commit fixes a concrete security issue by preventing proto pollution using a null-prototype accumulator, addressing a specific vulnerability with clear behavior delta.
  • e5d3fe96 fix(agents): address all PR feat(call-omo-agent): support custom agents via dynamic resolution code-yeongyu/oh-my-openagent#2299 code review findings -- The commit addresses multiple concrete issues and improvements, including security fixes (prototype pollution prevention), functional changes (empty restrictions for unknown agents), and meaningful refactorings (extracting shared parseToolsConfig) with clear benefits and new tests.
  • ab11f2eb fix(tests): replace mock.module with spyOn to prevent test pollution -- Replaced mock.module() with spyOn() to prevent test pollution, ensuring proper restoration in afterEach()
  • e1b2f97b fix: isPlanFamily regression tests, code-review -> review-work in test data (bug: isPlanFamily() substring matching false-positives Atlas/Metis/Momus display names code-yeongyu/oh-my-openagent#3312, [Bug]: Skill tool schema uses non-existent "code-review" as example instead of actual "review-work" skill code-yeongyu/oh-my-openagent#3285, transformModelForProvider missing anthropic provider — dash-format model IDs rejected by OpenCode code-yeongyu/oh-my-openagent#3290) -- The commit fixes a regression in test data by updating 'code-review' to 'review-work' in both test setup and expectation, and adds three new tests to ensure isPlanFamily correctly handles false positives and undefined inputs.
  • 47aa3025 fix(cli): use getAgentRuntimeName for agent resolution in run command -- The commit fixes a concrete behavior issue by replacing display names with runtime names for agent resolution, including updates in tests to use getAgentRuntimeName, ensuring consistency and accuracy in agent handling.
  • 0764526a fix(posthog): disable exception autocapture to stay within free tier -- Disables exception autocapture to stay within PostHog's free tier limit, preserving manual capture for critical errors.
  • ccb2715a fix: hide native plan agent when replace_plan is true ([Bug]: Native plan agent not hidden when replace_plan is true - Sisyphus routes to it instead of Prometheus code-yeongyu/oh-my-openagent#3443) -- The commit fixes a concrete behavior issue by hiding the native plan agent when replace_plan is true, ensuring correct routing to Prometheus with clear behavior delta.
  • a1842f2d feat(tool-metadata): add shared metadata contract and bridge -- Adds a shared metadata contract and bridge with meaningful tests covering various scenarios, including round-trip preservation, casing insensitivity, and edge cases like blank or missing call IDs.
  • 80d3339c feat(background-agent): add wait-for-task-session helper -- Adds a meaningful waitForTaskSessionID helper with thorough test coverage for various scenarios, including immediate resolution, polling, abort signals, and timeouts, providing clear value for task session management.
  • 4da30057 fix(plugin): harden metadata recovery and extraction -- The commit introduces meaningful functionality to extract session IDs from metadata, including legacy aliases, with clear test coverage and direct behavior improvements.
  • c6a407c4 refactor(tools): migrate producers to shared metadata bridge -- The commit refactors multiple files to migrate producers to a shared metadata bridge, replacing storeToolMetadata with publishToolMetadata across various task handlers, indicating a clear architectural improvement with broad impact.
  • 7bc170fb fix: installer writes hyphenated anthropic IDs, variant=max Anthropic OAuth compat (variant: max sends output_config which breaks Claude Pro/Max OAuth authentication code-yeongyu/oh-my-openagent#3429, [Bug]: installer generates invalid Anthropic model IDs with dotted version suffixes code-yeongyu/oh-my-openagent#3459) -- The commit fixes a concrete behavior issue by replacing dots with hyphens in Anthropic model IDs to ensure compatibility with Anthropic OAuth requirements, as evidenced by the systematic replacement of '4.6' with '4-6' across all model configurations.

Branch: sync/upstream/v3.17.4-good (local only; not on origin)

⚠️ 6 commit(s) failed to cherry-pick and are NOT in the draft PR.
🚫 Push to origin was rejected. GITHUB_TOKEN cannot create or modify files under .github/workflows/. The batch branch exists only in the workflow runner and was discarded. To merge this batch, run the analyzer with a PAT that has the workflow scope, or cherry-pick locally.
📝 4 commit(s) touch .github/workflows/ and require elevated permissions to sync: 565d3ff, 71b5ab6, 16e7fa5, 470ed8b

🟡 Review batch

Ambiguous. Human should review before merging.

  • 79a475d6 refactor(background-agent): simplify loop detector null guard -- Classification failed: No object generated: response did not match schema.
  • 569addd3 docs(provider): add comments to vercel transform logic -- Classification failed: No object generated: response did not match schema.

Branch: sync/upstream/v3.17.4-needs-review (on origin)

⚠️ 1 commit(s) failed to cherry-pick and are NOT in the draft PR.

🔴 Slop batch

Classified as AI slop or pointless churn. Do not merge as-is; rewrite intent if salvageable.

Branch: sync/upstream/v3.17.4-slop (on origin)

Slop verifier second-pass notes

  • 1e2e001 CONFIRMED_SLOP (behavior delta: none): The commit changes the visibility of CreateToolsResult from export to internal without any clear functional or architectural benefit, indicating minor visibility churn. There is no concrete behavior delta, and the commit message does not provide a justification for the change. A senior engineer would likely question the value of this change in a code review.
  • 9d89bbb CONFIRMED_SLOP (behavior delta: none): The commit changes the visibility of LoadBuiltinCommandsOptions from export to internal without clear functional or architectural benefit, indicating minor visibility churn. There is no concrete behavior delta, as the interface's usage scope is merely reduced without altering its structure or any dependent code's behavior. The commit message lacks justification for the change, and a senior engineer would likely question the value of this refactor without additional context or future plans for the interface.
  • 0c5cd3a CONFIRMED_SLOP (behavior delta: none): The commit updates generation dates in multiple AGENTS.md files without adding new functionality or value beyond metadata churn, which aligns with the 'date_count_metadata_churn' slop signal. There is no concrete behavior delta, and the change does not introduce new functionality or improve existing code in a measurable way.
  • e654cfb CONFIRMED_SLOP (behavior delta: none): The commit only adds a CLA signature to cla.json, which is administrative noise with no code or product value. The change does not affect any runtime behavior, user-visible output, or invariants. It aligns with the 'cla_admin' category, which is explicitly non-GOOD by the verification bias rules.
  • cd8352c DEMOTE_TO_GOOD (behavior delta: minor): The commit simplifies a null guard from two separate checks to a single '== null' check, which is a minor but legitimate refactor that improves code readability and maintainability. While the first-pass classified it as 'refactor_churn', this change has clear, albeit minor, value in reducing redundancy and aligning with common null checking practices. A senior engineer could defend this as a minor improvement in code quality.
  • 6713b30 CONFIRMED_SLOP (behavior delta: none): The commit removes unused 'tool.execute.before' callbacks in two hook files, which the first-pass classified as refactor_churn with high confidence. Upon review, the removed callbacks are indeed no-ops (void input/output), confirming no functional impact. The change simplifies the code by removing unused parts but does not introduce new functionality, improve performance, or fix a bug. Thus, it aligns with refactor_churn without clear value addition beyond minor cleanliness.
  • 141798e CONFIRMED_SLOP (behavior delta: none): The commit simplifies null checks from two separate conditions to a single '== null' check. While this refactoring improves code readability by standardizing the null guard, it does not introduce any functional or architectural benefits. The change is purely cosmetic and does not alter runtime behavior, invariant strength, or user-visible output. A senior engineer might justify it for consistency, but without broader impact or multiple callers benefiting from this abstraction, it aligns with 'refactor_churn' without clear value.
  • 6a0d515 CONFIRMED_SLOP (behavior delta: none): The commit only adds a CLA signature to cla.json, which is administrative noise with no code or product value. This aligns with the 'cla_admin' slop signal and does not provide any concrete behavior delta or value to the repository's functionality.
  • 5b33cd2 CONFIRMED_SLOP (behavior delta: none): The commit only adds a CLA signature to cla.json, which is administrative noise with no code or product value. This aligns with the 'cla_admin' category, which is explicitly non-mergable as per the verification bias. No behavior delta exists, and the change does not introduce any new functionality or fixes.
  • c6deb6d CONFIRMED_SLOP (behavior delta: none): The commit adds a CLA signature to cla.json, which is purely administrative with no code or product value. This matches the 'cla_admin' slop pattern, and there's no concrete behavior delta or user-visible change. The first-pass verdict correctly identifies it as SLOP.
  • 42df1c3 CONFIRMED_SLOP (behavior delta: none): The commit only adds a CLA signature to cla.json, which is administrative noise with no code or product value. This matches the 'cla_admin' category, which is explicitly non-GOOD by the verification bias rules. No behavior delta exists as it doesn't alter runtime code or user-visible output.
  • 84f980c CONFIRMED_SLOP (behavior delta: none): The commit only adds a CLA signature to cla.json, which is administrative noise with no code or product value. This aligns with the 'cla_admin' slop signal and does not provide any concrete behavior delta or value to the repository's functionality.
  • 678011c CONFIRMED_SLOP (behavior delta: none): The commit updates counts and version references in documentation without adding new functionality or information. These changes are considered bookkeeping-only metadata churn, aligning with documented slop patterns. No runtime code paths change, and the commit message accurately reflects the limited scope of the updates. A senior engineer would likely view this as administrative noise rather than substantive value.
  • cfd152a CONFIRMED_SLOP (behavior delta: none): The commit adds two features with vague descriptions and no clear behavioral deltas. The features are gated behind flags without clear consumer demand, and the commit message lacks measurable metrics. No concrete user value or code changes are evident beyond documentation updates.
  • 0cb0a6c CONFIRMED_SLOP (behavior delta: none): The commit updates counts in documentation (e.g., changing '10' to '52' in plugin/hook composition) without adding new functionality, new facts, or substantive improvements. This aligns with 'docs_churn' as it's bookkeeping-only metadata updates. No runtime behavior changes, and the commit message accurately reflects the trivial update but lacks measurable value beyond housekeeping.
  • 3419bbc CONFIRMED_SLOP (behavior delta: none): The commit only updates a CLA signature in cla.json without any code or product changes, aligning with 'cla_admin' slop signals. No behavior delta exists as it's administrative noise. A senior engineer would not defend this as value-adding for the codebase.
  • 1bb59c3 CONFIRMED_SLOP (behavior delta: none): The commit is a release version bump with no code changes, only updating version numbers in multiple package.json files. This matches the 'release_version_bump' slop pattern. There is no concrete behavior delta, and the change is purely administrative. As per the verification bias, release version bumps are not considered GOOD by default.
  • 571cf1f CONFIRMED_SLOP (behavior delta: none): The commit only updates the CLA signatures in cla.json with no code or product changes, aligning with cla_admin slop signals. No behavior delta exists as it's administrative metadata churn. A senior engineer would likely not defend this as valuable for the codebase's functionality or quality.
  • f98f7ec CONFIRMED_SLOP (behavior delta: none): The commit adds a CLA signature to cla.json, which is administrative noise with no direct code or product value. The first-pass verdict correctly identifies it as SLOP based on the provided guidelines, which exclude CLA admin updates from being considered GOOD. No code behavior changes, and the update does not strengthen or weaken any invariants. The commit message accurately reflects the administrative change but lacks technical value.
  • d97c067 CONFIRMED_SLOP (behavior delta: none): The commit adds a CLA signature to cla.json, which is administrative noise with no direct code or product value. The first-pass verdict correctly identified it as SLOP due to being a CLA signature commit, which aligns with the verification bias to not rescue such commits into GOOD. There's no behavior delta, and the change does not strengthen any invariants or affect runtime code paths.
  • eaf5ff2 CONFIRMED_SLOP (behavior delta: none): The commit adds a CLA signature to cla.json with no code or product value changes. This matches the 'cla_admin' category, which is not considered GOOD by default. No behavior delta exists as it's administrative noise.
  • f8f7ac1 CONFIRMED_SLOP (behavior delta: none): The commit adds a CLA signature to cla.json, which is administrative noise with no direct code or product value. The first-pass verdict correctly identifies it as SLOP based on the provided guidelines, which exclude CLA admin updates from being considered GOOD. No behavior delta, abstractions, or user-visible changes are introduced.
  • 54a94d4 CONFIRMED_SLOP (behavior delta: none): The commit adds a CLA signature to cla.json, which is administrative noise with no direct code or product value. The first-pass verdict correctly identifies it as cla_admin, a category excluded from being demoted to GOOD by the verification bias. No behavior delta exists as this change does not affect runtime code or user-visible output.
  • 81a03fa CONFIRMED_SLOP (behavior delta: none): The commit only adds a CLA signature to cla.json, which is administrative noise with no code or product value. This aligns with the 'cla_admin' slop signal and does not provide any concrete behavior delta or value to the repository's functionality.
  • 9aeb87c CONFIRMED_SLOP (behavior delta: none): The commit only updates the version number in package.json, which is classified as release_version_bump, a documented slop pattern. There is no concrete behavior delta, no new functionality, and the change is purely administrative. The first-pass verdict correctly identifies this as administrative noise with no merge value for the fork.
  • 80e73f5 CONFIRMED_SLOP (behavior delta: none): The commit only adds a CLA signature to cla.json, which is administrative noise with no code or product value. This matches the 'cla_admin' category, which is explicitly non-GOOD by the verification bias rules. No behavior delta exists as it's purely administrative.
  • fe091ef CONFIRMED_SLOP (behavior delta: none): The commit only updates the version number in package.json, which is classified as 'release_version_bump' administrative noise. According to the verification bias, such commits should not be demoted to GOOD. There's no concrete behavior delta, and the change does not strengthen any invariants or add value beyond administrative tracking.
  • c9350c6 CONFIRMED_SLOP (behavior delta: none): The commit only updates version numbers in multiple package.json files, which is administrative noise with no code or product value. This aligns with the 'release_version_bump' category, which is explicitly non-GOOD by the rubric. There's no behavior delta, and the change does not strengthen or weaken any invariants beyond version tracking.

Fork-sync impact assessment

Breaking changes

(none detected)

Dependency changes

(none)

Architecture drift

(none)

Hidden concerns

  • Minor refactor churn without clear architectural benefit in some GOOD-classified commits
  • Administrative noise contributes to slop ratio without adding product value

Action items before merging

  • Manually review NEEDS_REVIEW commits (2) for hidden value or risks
  • Assess the necessity of minor refactor commits (e.g., cd8352c1, 141798ef) in the GOOD batch
  • Verify no implicit dependencies or version conflicts with fork's current setup

Generated by upstream-analyzer workflow. This issue is advisory: no merges or publishes happen automatically. Phase 1: draft PRs only. The prompt lives in .github/prompts/ and is editable without touching workflow code.

Classify chain: openrouter:qwen/qwen3-coder:free → nvidia:nvidia/llama-3.3-nemotron-super-49b-v1 → github:openai/gpt-4.1-mini
Slop-verify chain: openrouter:nvidia/nemotron-3-super-120b-a12b:free → nvidia:nvidia/llama-3.3-nemotron-super-49b-v1 → github:openai/gpt-4.1
Synthesis chain: openrouter:nvidia/nemotron-3-super-120b-a12b:free → nvidia:nvidia/llama-3.3-nemotron-super-49b-v1 → github:openai/gpt-4.1

Metadata

Metadata

Assignees

No one assigned

    Labels

    cost-benefitupstream-reviewupstream-tag:v3.17.4upstream:cherry-pick

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions