Skip to content

🟡 Upstream v3.17.0 → v3.17.4: CHERRY_PICK (slop 22%) #56

Open
Open
🟡 Upstream v3.17.0 → v3.17.4: CHERRY_PICK (slop 22%)#56
Labels
cost-benefitupstream-reviewupstream-tag:v3.17.4upstream:cherry-pick
@github-actions

Description

@github-actions
github-actions
bot
opened on Apr 21, 2026

🟡 Upstream cost-benefit: v3.17.0 → v3.17.4

Upstream: code-yeongyu/oh-my-openagent
Recommendation: CHERRY_PICK (confidence: medium)
Slop ratio: 22%

The release contains a mix of valuable updates (bug fixes, documentation, and refactors with clear benefits) and significant slop (administrative noise, minor churn). While the slop ratio is within the 15-40% threshold, the presence of administrative CLA signatures and minor visibility changes suggests cherry-picking the GOOD commits would be prudent. No critical breaking changes or dependency conflicts were identified that would outright prevent merging, but careful review of refactor churn is advised.

Batch classification

Verdict Count Branch
🟢 GOOD 89 sync/upstream/v3.17.4-good
🟡 NEEDS_REVIEW 1 sync/upstream/v3.17.4-needs-review
🔴 SLOP 26 sync/upstream/v3.17.4-slop

🟢 Good batch

Classified as real value. Candidate for merge.

  • ad85e438 fix: include user/project agents in task(subagent_type) resolution -- Adds meaningful functionality with clear user value and new test coverage for real scenarios.
  • 2266f28f fix: correct merge order so project agents override user agents -- The commit fixes a specific behavior issue by changing the merge order of project and user agents, ensuring project agents override user agents when names collide, with a new test added to cover this scenario.
  • 64408823 fix: actually swap merge order so project is added before user -- The commit fixes a specific behavior issue by changing the merge order of project and user agents, ensuring project agents override user agents when names collide, with a new test added to cover this scenario.
  • 5441c848 refactor: use spyOn instead of vi.mock for agent loader mocks -- The commit replaces vi.mock with spyOn for agent loader mocks in tests, which is a clear refactor with a specific, justified improvement for idiomatic use in bun:test as suggested in a PR review.
  • b0b19f30 fix(grep): handle Windows drive-letter paths and CRLF in parseOutput -- Fixes concrete behavior issues on Windows by updating regex to handle drive-letter paths and stripping CRLF line endings, resolving a reported bug ([Bug]: Grep tool content mode always returns 'No matches found' on Windows — drive letter breaks regex parsing code-yeongyu/oh-my-openagent#2962).
  • e9b6bba1 refactor(agent-display): centralize name normalization resolution -- Adds new test cases for name normalization and refactors the logic to centralize resolution, improving maintainability and coverage of edge cases like legacy names and UI prefixes.
  • f95e7a6c refactor(openclaw): reuse shared gateway url validation -- The commit refactors the code to reuse shared gateway URL validation, removing redundant logic and improving maintainability by centralizing validation in ./config.
  • 40411f32 docs(agents): add AGENTS.md documentation for prometheus, hephaestus, sisyphus variants, and builtin-skills -- The commit adds substantial, new documentation for multiple agents and built-in skills, providing clear, detailed information about their purpose, structure, and functionality.
  • 21822ba2 test(openclaw): cover shared gateway url validation -- Adds meaningful test coverage for gateway URL validation scenarios, including HTTPS, local HTTP, and invalid URLs.
  • a2ae3de3 refactor(openclaw): extract gateway url validator -- Extracts a reusable validateGatewayUrl function into its own file, reducing code duplication and improving maintainability.
  • 69f1c9ae fix(doctor): add timeouts to subprocess spawns to prevent exit code 137 -- Adds concrete timeouts to prevent subprocess hangs, directly addressing exit code 137 issues with clear functional benefit.
  • 314e1a5e fix(telemetry): enable GeoIP resolution for PostHog events -- Explicitly enables GeoIP resolution for PostHog events by setting disableGeoip to false, allowing for geographic analytics.
  • d21ed3f7 fix(doctor): add timeouts to subprocess spawns to prevent exit code 137 -- Adds concrete timeouts to prevent subprocess hangs, directly addressing exit code 137 issues with clear functional benefit.
  • 565d3ffa fix(ci): build darwin binaries on macOS runners to restore code signing -- The commit fixes a concrete CI issue by routing darwin platforms to macOS runners for native compilation and adds an explicit ad-hoc codesign step to restore code signing, directly addressing a functional problem with macOS Gatekeeper.
  • 71b5ab67 fix(ci): replace breaking codesign step with signature verification -- Replaces a breaking CI step with a necessary signature verification, directly addressing a functional issue with macOS code signing.
  • 16e7fa5b fix(ci): ad-hoc sign darwin binaries with plain codesign -- Explicitly signs Darwin binaries with 'codesign' to address CI issue, directly improving functionality.
  • 470ed8b1 fix(ci): remove existing signature before ad-hoc signing darwin binary -- The commit fixes a concrete CI issue by removing an existing malformed signature before applying a fresh ad-hoc signature to Darwin binaries, directly addressing a functional problem with macOS Gatekeeper.
  • 2d65896b refactor(shared): simplify normalize SDK null guards -- Simplifies null checks in normalizeSDKResponse from explicit null/undefined checks to the more concise '== null', improving readability without changing behavior.
  • 79a475d6 refactor(background-agent): simplify loop detector null guard -- Simplifies null checks in sortObject function from explicit null/undefined checks to '== null', improving readability without changing behavior.
  • cd8352c1 refactor(claude-code-mcp-loader): simplify env expansion null guard -- Simplifies null checks in env expansion function from explicit null/undefined checks to '== null', improving readability without changing behavior.
  • 50df6f0d test(claude-code-plugin-loader): cover plugin path nullish resolution -- Adds meaningful test coverage for plugin path resolution, including nullish input handling.
  • 668bc8e8 refactor(config-manager): simplify config parsing guards -- The commit simplifies redundant conditional logic in config parsing and adds meaningful test coverage for valid and invalid config scenarios.
  • a0d5131e refactor(plugin): remove dead chat params code -- Removes dead code (unused 'variant' parameter and its associated logic) in chat-params.ts, simplifying the buildChatParamsInput function.
  • 21cad26c docs(config): remove redundant schema default comments -- Removed redundant default value comments in schema definitions, improving clarity without changing behavior.
  • 4de02094 test(background-agent): lock nullish loop detector behavior -- Adds meaningful test coverage for nullish input handling in loop detector behavior, ensuring consistent behavior for null and undefined inputs.
  • 141798ef refactor(background-agent): standardize loop detector null guards -- Simplifies null checks in two functions from explicit null/undefined checks to '== null', improving readability without changing behavior.
  • e71c34ac fix(migration): return true when canonical config write succeeds regardless of archive status ([Bug]: v3.15.1 still inconsistently loads/migrates plugin config after rename code-yeongyu/oh-my-openagent#3133) -- Fixes a concrete behavior issue where migration incorrectly reported failure due to secondary archive status, despite successful canonical config write.
  • 7accb53c fix(shared): handle Windows rename-over-existing in write-file-atomically ([Bug]: Using oh-my-opencode via bunx causes a new oh-my-openagent.json.bak.* backup file to be created on every OpenCode startup, even when no config changes were made. code-yeongyu/oh-my-openagent#3222) -- Fixes a concrete behavior issue on Windows by handling rename-over-existing errors with a fallback strategy, adding meaningful test coverage for atomic file writes.
  • 9ef133a8 fix(migration): register parenthesized legacy agent aliases in AGENT_NAME_MAP ([Bug]: Header 'x-opencode-agent-name' has invalid value: '​Atlas (Plan Executor)' code-yeongyu/oh-my-openagent#3281) -- Adds concrete mappings for legacy agent aliases and tests for migration correctness, addressing a specific compatibility issue.
  • a6e4f211 fix(shared): normalize claude model IDs for anthropic provider (transformModelForProvider missing anthropic provider — dash-format model IDs rejected by OpenCode code-yeongyu/oh-my-openagent#3290) -- Fixes a concrete compatibility issue by normalizing model IDs for Anthropic API, with clear test expectation updates.
  • 4f02ace7 fix(shared): guard maxOutputTokens <= 0 in model settings compatibility ([Bug]: Invalid argument for parameter maxOutputTokens: maxOutputTokens must be >= 1 code-yeongyu/oh-my-openagent#3305) -- Fixes a concrete behavior issue where invalid maxOutputTokens (<=0) in model metadata would break generation by preserving user-requested maxTokens.
  • c750781b fix(shared): avoid false-positive skill path resolution on npm scoped packages ([Bug]: Why my command run with error path? code-yeongyu/oh-my-openagent#2857) -- Fixes a concrete behavior issue by adjusting regex to exclude npm scoped packages, with clear test addition.
  • d7b4bec5 fix(hooks,tools): replace /plan example with prometheus delegation and rename code-review example to review-work (Error message references non-existent /plan command code-yeongyu/oh-my-openagent#2633, [Bug]: Skill tool schema uses non-existent "code-review" as example instead of actual "review-work" skill code-yeongyu/oh-my-openagent#3285, [Bug]: oh-my-openagent overrides built-in tools to bypass the permission system. code-yeongyu/oh-my-openagent#2873) -- The commit fixes concrete behavior issues by replacing a non-existent command with a valid Prometheus delegation and renaming a non-existent skill to a real one, with accompanying test updates.
  • 7e96af5f fix(atlas): exclude node_modules from verification git diff --stat ([Feature]: Ensure gitignore is created before starting implementation code-yeongyu/oh-my-openagent#3215) -- The commit fixes a concrete behavior issue by excluding node_modules from git diff verification, with clear test additions.
  • 2d8b4a9d fix(anthropic-effort): skip effort injection for github-copilot provider ([Bug]: code-yeongyu/oh-my-openagent#3270) -- The commit fixes a concrete behavior issue by adding an explicit guard to skip effort injection for the github-copilot provider, preserving native Anthropic provider support, with a meaningful new test case.
  • 796a646c fix(non-interactive-env): use detectShellType instead of hardcoded win32 check ([Bug]: Force PowerShell env behavior in Windows code-yeongyu/oh-my-openagent#3310, Bug: PowerShell env var syntax ($env:VAR) used in bash shell on Windows code-yeongyu/oh-my-openagent#3338) -- The commit replaces a hardcoded platform check with a dynamic detectShellType() call, improving compatibility with various shells on Windows (Git Bash, WSL, native PowerShell) through updated tests.
  • 64e55936 fix(multimodal-looker): instruct explicit Read tool usage for PDFs (Multimodal-Looker Cannot Read PDF Files code-yeongyu/oh-my-openagent#2998) -- Explicit instruction added to use Read tool for PDFs, ensuring files are loaded before extraction, addressing a concrete behavior gap.
  • d8b9bf1a fix(doctor): check comment-checker lazy-download cache path ([Question]: comment-checker not found code-yeongyu/oh-my-openagent#2911, [Bug] comment-checker hook does not trigger code-yeongyu/oh-my-openagent#3315) -- Fixes a concrete behavior issue by aligning doctor resolution order with runtime to recognize cached binaries, with clear test addition.
  • 3bfa3bd6 fix(background-agent): pass query directory to session.get in 4 call-sites ([Bug]: resolveSubagentSpawnContext fails to find project-scoped sessions — client.session.get() missing directory parameter code-yeongyu/oh-my-openagent#2937) -- The commit fixes a concrete behavior issue by passing the query directory to session.get in multiple call-sites, resolving 404 errors under newer OpenCode SDK versions, with clear test additions.
  • eb495793 fix(event): prefer real session.idle over recent synthetic dedup ([Bug]: The model has responded normally, but there is a red alert in the input box: [TODO-DIAG] BLOCKED: no todossession.idle event code-yeongyu/oh-my-openagent#2667) -- Fixes a concrete behavior issue by adjusting deduplication logic to prioritize real session.idle events over synthetic ones, with clear test additions.
  • aed8dbfa fix(delegate-task): fetch session result before honoring abort signal ([Bug]: @explore subagent completes but parent never returns result; 3.12.3 aborts with "The operation was aborted." code-yeongyu/oh-my-openagent#2702) -- Fixes a concrete behavior issue where the sync poller would immediately return 'Task aborted' without checking for a potentially completed session, now fetching session results before honoring the abort signal.
  • c5c5bc36 fix(delegate-task): consume fallback chain on sendSyncPrompt failure (delegate-task: No automatic retry with fallback models when subagent fails due to model error code-yeongyu/oh-my-openagent#2691) -- The commit fixes a concrete behavior issue by implementing a retry mechanism with a fallback chain for failed sendSyncPrompt calls, including meaningful test additions.
  • 3d2eb6e4 fix(config): preserve explicit git_master overrides during merge -- The commit fixes a concrete behavior issue by preserving explicit git_master overrides during merge, with clear test additions.
  • dac0c99e feat: add Vercel AI Gateway as a provider -- Adds Vercel AI Gateway as a recognized provider with clear integration across multiple files and test updates, enabling universal fallback for various models.
  • aac17135 test: add vercel provider transform tests -- Adds meaningful test coverage for Vercel provider transformations with multiple scenarios
  • 6f72ec75 test: add integration tests for Vercel AI Gateway model resolution -- Adds integration tests for Vercel AI Gateway model resolution with clear scenarios and snapshot updates.
  • 542dc890 fix(provider): use gateway-specific model IDs for vercel transform -- The commit fixes a concrete behavior issue by using gateway-specific model IDs for Vercel transform, with clear test updates and model ID transformations.
  • 34e334ea feat(provider): add vercel to all gateway-supported fallback entries -- Adds vercel to all gateway-supported fallback entries with clear integration and test updates, enabling universal fallback for various models.
  • effae16c refactor(provider): replace per-model string replacements with generic regex -- Replaces multiple per-model string replacements with a generic regex, simplifying code and making it more maintainable for new models.
  • 680d05a2 Prometheus: keep planner primary-only -- The commit fixes Prometheus's mode from 'all' to 'primary' across multiple tests and config builders, ensuring consistency with other core agents and updating related tests to reflect this change.
  • e3b5c2be fix: address review feedback for Vercel AI Gateway PR -- Adds a new CLI option for Vercel AI Gateway, updates priority logic, and fixes test expectations with clear model ID corrections.
  • 01a1b141 fix(delegate-task): reject primary agents in task subagent resolution -- The commit introduces a concrete behavior fix by rejecting primary agents in task subagent resolution, with clear functional changes and new utility functions (e.g., sanitizeSubagentType, findPrimaryAgentMatch) that directly address the issue.
  • 3673b962 docs(readme-ru): add telemetry and legal section translation -- Added meaningful Russian translations for telemetry and legal sections in README.ru.md, including privacy policy and terms of service links.
  • 23d0a0dc docs(readme-zh-cn): add telemetry and legal section translation -- Added meaningful Chinese translations for telemetry and legal sections in README.zh-cn.md, including privacy policy and terms of service links.
  • 0ece66e3 docs(readme-ja): add telemetry and legal section translation -- Added meaningful Japanese translations for telemetry and legal sections in README.ja.md, including privacy policy and terms of service links.
  • 12ed9501 docs(readme-ko): add telemetry and legal section translation -- Added meaningful Korean translations for telemetry and legal sections in README.ko.md, including privacy policy and terms of service links.
  • c91db2eb docs(cli): add --vercel-ai-gateway flag documentation -- Added documentation for a new CLI flag with clear description and default value.
  • e223ab20 docs(configuration): add sisyphus-junior to agent list -- Added a new agent 'sisyphus-junior' to the list of available agents in the configuration documentation, providing clear user value by informing users of an additional option.
  • 9342e55b docs(installation): replace npx with bunx and update provider flags -- Updated installation docs to reflect 'bunx' usage and added new provider flags with clear explanations.
  • 05e54444 docs(overview): update model-role claims and complete category list -- The commit updates the documentation with a complete and detailed category list for model roles, providing clear user value by enhancing understanding of how categories map to specific models.
  • 7c94ee45 docs(agent-model-matching): sync fallback chains with current source -- Updated fallback chains in documentation to match current source, providing accurate information for users.
  • b57a7975 docs(ollama): verify troubleshooting steps and issue links -- Updated troubleshooting steps with verified issue links and clear documentation improvements.
  • bbbd1bd0 docs(orchestration): update diagram model names and category tables -- Updated documentation with clear, substantive changes to model names, category tables, and fallback chains, enhancing user understanding and accuracy.
  • 4ce1dde3 CLI: isolate provider model id transforms from shared mocks -- Added meaningful test coverage for provider model ID transformations across multiple providers with specific, real scenarios.
  • 1b36194b fix(cli): treat missing session status as idle in run completion -- Added a test case to handle missing session status as idle, ensuring the CLI doesn't hang indefinitely.
  • b5250555 fix(telemetry): guard PostHog init failures -- Adds meaningful test coverage for PostHog init failure scenarios, ensuring no-throw behavior for clients.
  • 0dab3116 fix: resolve 3 bugs ([Bug]: non-interactive-env hook generates PowerShell $env: syntax on Git Bash (Windows) code-yeongyu/oh-my-openagent#3366, Agent name case change breaks Todo Continuation for historical sessions code-yeongyu/oh-my-openagent#3272, [Bug]: Using oh-my-opencode via bunx causes a new oh-my-openagent.json.bak.* backup file to be created on every OpenCode startup, even when no config changes were made. code-yeongyu/oh-my-openagent#3222) -- The commit fixes three concrete bugs with clear functional impact, including shell detection, legacy agent name resolution, and config backup optimization.
  • 62c60ae9 fix: numeric skill names, ultrawork missing run_in_background, ZWSP agent lookups -- The commit fixes concrete bugs with clear functional impact, including coercing numeric skill names to strings, adding a required parameter to task examples, and stripping invisible characters for agent name comparisons.
  • 76c5356a test(agent-config): add regression tests for agent merge priority order -- Adds meaningful regression tests for agent merge priority order with clear test cases and expected outcomes.
  • da91c535 fix(call-omo-agent): address cubic review findings and add requirement-based tests -- The commit fixes concrete issues, adds requirement-based tests, and improves validation with clear functional impact.
  • 1e85a88d fix(agent-restrictions): restore EXPLORATION_AGENT_DENYLIST as default fallback for unknown agents -- Restores a default fallback for unknown agents, directly addressing a functional behavior gap.
  • fd28f7e6 feat(agents): add agent_definitions schema, eager path resolution, and JSON agent loader -- Adds agent_definitions schema, eager path resolution, and JSON agent loader with comprehensive test suite and clear functional value.
  • 5755a90c feat(agents): add agent definitions file loader and opencode.json reader -- Adds agent definitions loader with comprehensive test coverage and clear functional value, including support for multiple file formats and precedence rules.
  • 39bda91b feat(agents): wire agent_definitions and opencode.json agents into precedence chain -- The commit integrates agent_definitions and opencode.json agents into the precedence chain with clear functional value, including new loading functions, integration tests, and logging.
  • 3d0fb22c fix(call-omo-agent): adapt dev's model override tests to use createMockCtx factory -- The commit adapts existing tests to use a new factory function (createMockCtx) replacing a deprecated constant (mockCtx), ensuring test compatibility with the current codebase.
  • 42445f51 fix(agents): address cubic review findings on agent loader -- Fixes concrete issues with agent loading, including case-insensitive file extension handling, relative path resolution, and precedence logic, with clear functional impact and new test coverage.
  • cf4b2315 fix(agents): replace 'in' with Object.hasOwn() for prototype-safe property checks -- Replaces 'in' with Object.hasOwn() for prototype-safe property checks in two locations, addressing a specific issue with inherited properties.
  • 4c77045c fix(agents): use null-prototype accumulator to prevent proto pollution -- The commit fixes a concrete security issue by preventing proto pollution using a null-prototype accumulator, addressing a specific vulnerability with clear functional impact.
  • e5d3fe96 fix(agents): address all PR feat(call-omo-agent): support custom agents via dynamic resolution code-yeongyu/oh-my-openagent#2299 code review findings -- The commit addresses multiple concrete issues and improvements, including security fixes (preventing prototype pollution), functional changes (handling unknown agents, path resolution), and meaningful test additions, all with clear value and no apparent slop.
  • ab11f2eb fix(tests): replace mock.module with spyOn to prevent test pollution -- Replaced mock.module() with spyOn() to prevent test state pollution, ensuring tests restore properly in afterEach()
  • e1b2f97b fix: isPlanFamily regression tests, code-review -> review-work in test data (bug: isPlanFamily() substring matching false-positives Atlas/Metis/Momus display names code-yeongyu/oh-my-openagent#3312, [Bug]: Skill tool schema uses non-existent "code-review" as example instead of actual "review-work" skill code-yeongyu/oh-my-openagent#3285, transformModelForProvider missing anthropic provider — dash-format model IDs rejected by OpenCode code-yeongyu/oh-my-openagent#3290) -- The commit fixes regression tests by updating 'code-review' to 'review-work' in test data and adds specific tests to ensure isPlanFamily correctly handles false positives and edge cases.
  • 47aa3025 fix(cli): use getAgentRuntimeName for agent resolution in run command -- The commit fixes a concrete behavior issue by using getAgentRuntimeName for agent resolution in the run command, with clear functional impact and updated tests.
  • 0764526a fix(posthog): disable exception autocapture to stay within free tier -- Disables exception autocapture in posthog to stay within the free tier limit, preserving manual capture for critical errors.
  • ccb2715a fix: hide native plan agent when replace_plan is true ([Bug]: Native plan agent not hidden when replace_plan is true - Sisyphus routes to it instead of Prometheus code-yeongyu/oh-my-openagent#3443) -- The commit fixes a concrete behavior issue by hiding the native plan agent when replace_plan is true, with clear functional impact and updated tests.
  • a1842f2d feat(tool-metadata): add shared metadata contract and bridge -- Adds a shared metadata contract and bridge with meaningful tests covering various scenarios, including round-trip persistence, casing insensitivity, and edge cases like missing or blank call IDs.
  • 80d3339c feat(background-agent): add wait-for-task-session helper -- Adds a waitForTaskSessionID helper with meaningful tests covering immediate resolution, polling, abort signals, and timeouts, providing clear functional value for task session management.
  • 4da30057 fix(plugin): harden metadata recovery and extraction -- The commit introduces meaningful functionality to extract session IDs from metadata, including legacy aliases, with corresponding tests and clear functional impact.
  • c6a407c4 refactor(tools): migrate producers to shared metadata bridge -- The commit refactors multiple files to migrate producers to a shared metadata bridge, replacing storeToolMetadata with publishToolMetadata across various task handlers, indicating a structural improvement with clear architectural benefit.
  • 7bc170fb fix: installer writes hyphenated anthropic IDs, variant=max Anthropic OAuth compat (variant: max sends output_config which breaks Claude Pro/Max OAuth authentication code-yeongyu/oh-my-openagent#3429, [Bug]: installer generates invalid Anthropic model IDs with dotted version suffixes code-yeongyu/oh-my-openagent#3459) -- The commit fixes a concrete behavior issue by replacing dots with hyphens in Anthropic model IDs to ensure compatibility with Anthropic OAuth, as evidenced by the systematic replacement across all model references in the snapshot.

Branch: sync/upstream/v3.17.4-good (local only; not on origin)

⚠️ 6 commit(s) failed to cherry-pick and are NOT in the draft PR.
🚫 Push to origin was rejected. GITHUB_TOKEN cannot create or modify files under .github/workflows/. The batch branch exists only in the workflow runner and was discarded. To merge this batch, run the analyzer with a PAT that has the workflow scope, or cherry-pick locally.
📝 4 commit(s) touch .github/workflows/ and require elevated permissions to sync: 565d3ff, 71b5ab6, 16e7fa5, 470ed8b

🟡 Review batch

Ambiguous. Human should review before merging.

  • 569addd3 docs(provider): add comments to vercel transform logic -- Classification failed: No object generated: response did not match schema.

Branch: sync/upstream/v3.17.4-needs-review (local only; not on origin)

⚠️ 1 commit(s) failed to cherry-pick and are NOT in the draft PR.

🔴 Slop batch

Classified as AI slop or pointless churn. Do not merge as-is; rewrite intent if salvageable.

Branch: sync/upstream/v3.17.4-slop (on origin)

Slop verifier second-pass notes

  • 1e2e001 CONFIRMED_SLOP (behavior delta: none): The commit changes the visibility of CreateToolsResult from export to internal without any clear functional or architectural benefit. This fits the 'minor_visibility_churn' category with no apparent payoff. No runtime behavior changes, and the abstraction's scope reduction lacks justification. A senior engineer would likely question the value of this change without additional context or future plans explicitly mentioned.
  • 9d89bbb CONFIRMED_SLOP (behavior delta: none): The commit changes the visibility of LoadBuiltinCommandsOptions from export to internal without clear functional or architectural benefit, aligning with minor_visibility_churn. No runtime behavior delta exists, and the change lacks a concrete benefit or multiple callers. A senior engineer would likely question this change without further justification.
  • 0c5cd3a CONFIRMED_SLOP (behavior delta: none): The commit only updates generation dates in multiple AGENTS.md files without adding new functionality or information. This aligns with the 'date_count_metadata_churn' slop pattern. There is no concrete behavior delta, and the change does not introduce new value beyond metadata updates.
  • e654cfb CONFIRMED_SLOP (behavior delta: none): The commit adds a CLA signature to cla.json, which is purely administrative and does not introduce any code or product value. This aligns with the 'cla_admin' slop signal. No behavior delta exists as it's metadata churn.
  • 6713b30 CONFIRMED_SLOP (behavior delta: none): The commit removes no-op callbacks but introduces overly complex hook interfaces with optional and vague event handlers, suggesting AI-generated churn. The changes lack a clear payoff and increase complexity without measurable benefits. No concrete behavior delta is observed beyond removing unused code, and the added abstractions do not have multiple callers or a clear growth path. The commit message's claim of 'refactor' is accurate in removing no-op code but misleading in implying value from the new complexity.
  • 6a0d515 CONFIRMED_SLOP (behavior delta: none): The commit adds a CLA signature to cla.json, which is purely administrative with no impact on code or product functionality. This aligns with the 'cla_admin' slop signal and does not provide any measurable value to the repository's functionality or quality.
  • 5b33cd2 CONFIRMED_SLOP (behavior delta: none): The commit only adds a CLA signature to cla.json, which is administrative noise with no code or product value. This matches the 'cla_admin' category, which is explicitly non-GOOD by the verification bias rules. There's no behavior delta, no new functionality, and the change is purely administrative.
  • c6deb6d CONFIRMED_SLOP (behavior delta: none): The commit only adds a CLA signature to cla.json, which is administrative noise with no code or product value. This aligns with the 'cla_admin' slop signal and does not provide any concrete behavior delta or value to the project's functionality.
  • 42df1c3 CONFIRMED_SLOP (behavior delta: none): The commit only adds a CLA signature to cla.json, which is administrative noise with no code or product value. This aligns with the 'cla_admin' category, which is explicitly excluded from being demoted to GOOD. No behavior delta exists as it doesn't affect runtime code or user-visible output.
  • 84f980c CONFIRMED_SLOP (behavior delta: none): The commit only adds a CLA signature to cla.json, which is administrative noise with no code or product value. The change does not affect any runtime behavior, user-visible output, or invariants. It aligns with the 'cla_admin' category, which is explicitly non-GOOD by the verification bias rules.
  • 678011c CONFIRMED_SLOP (behavior delta: none): The commit updates counts and version references in documentation without adding new functionality or substantial information. These changes are considered metadata updates and do not introduce a concrete behavior delta in runtime code. The first-pass verdict correctly identifies this as SLOP due to the nature of the changes being limited to doc edits that expand existing content without new facts.
  • cfd152a CONFIRMED_SLOP (behavior delta: none): The commit adds two new features with vague descriptions lacking concrete user value or measurable metrics. The changes are purely documentary without a clear functional delta, aligning with the first-pass slop signals. No runtime code paths change, and the commit message's claims (e.g., 'verify category list') are unquantified.
  • 0cb0a6c CONFIRMED_SLOP (behavior delta: none): The commit updates counts in documentation (e.g., changing '10' to '52' in plugin/hook composition) without adding new functionality, features, or substantive information. This aligns with the first-pass reason of expanding existing content without new facts. No runtime behavior changes, and the update is purely informational with no clear growth path or defendable value beyond accuracy, which is expected in docs.
  • 3419bbc CONFIRMED_SLOP (behavior delta: none): The commit adds a CLA signature to cla.json, which is purely administrative and does not introduce any code or product value. The first-pass verdict correctly identifies this as cla_admin, a category excluded from being demoted to GOOD by the verification bias. No behavior delta exists as this change does not affect runtime code paths or user-visible outputs.
  • 1bb59c3 CONFIRMED_SLOP (behavior delta: none): The commit is a release version bump from 3.17.0 to 3.17.2 with no code changes, only updating package versions across multiple packages. This matches the 'release_version_bump' slop pattern. There is no concrete behavior delta, as no runtime code paths or user-visible outputs change—only version numbers in package.json files are updated. According to the verification bias, release version bumps should not be rescued into GOOD.
  • 571cf1f CONFIRMED_SLOP (behavior delta: none): The commit only adds a CLA signature to cla.json, which is administrative noise with no code or product value. The first-pass verdict correctly identifies this as cla_admin, a category excluded from being demoted to GOOD by the verification bias rules. There is no behavior delta, no new functionality, and the change does not impact any runtime code path or user-visible output.
  • f98f7ec CONFIRMED_SLOP (behavior delta: none): The commit adds a CLA signature to cla.json, which is purely administrative with no impact on code or product functionality. This aligns with the 'cla_admin' slop signal and does not introduce any behavior delta.
  • d97c067 CONFIRMED_SLOP (behavior delta: none): The commit only adds a CLA signature to cla.json, which is administrative noise with no code or product value. This aligns with the 'cla_admin' category, which is explicitly non-mergable as per the verification bias rules.
  • eaf5ff2 CONFIRMED_SLOP (behavior delta: none): The commit only adds a CLA signature to cla.json, which is administrative noise with no code or product value. This matches the 'cla_admin' category, which is explicitly non-mergable as per the verification bias rules. No behavior delta exists, and the change does not impact runtime code or user-visible output.
  • f8f7ac1 CONFIRMED_SLOP (behavior delta: none): The commit adds a CLA signature to cla.json, which is purely administrative and does not introduce any code or product value. This aligns with the 'cla_admin' slop signal. No behavior delta exists as it's metadata churn.
  • 54a94d4 CONFIRMED_SLOP (behavior delta: none): The commit only adds a CLA signature to cla.json, which is administrative noise with no code or product value. This matches the 'cla_admin' category, which is explicitly non-mergable as per the verification bias rules.
  • 81a03fa CONFIRMED_SLOP (behavior delta: none): The commit adds a CLA signature to cla.json, which is administrative noise with no code or product value. The first-pass verdict correctly identifies it as cla_admin, a category excluded from being demoted to GOOD by the verification bias rules. No behavior delta exists as it doesn't alter runtime code or user-visible output.
  • 9aeb87c CONFIRMED_SLOP (behavior delta: none): The commit only updates the version number in package.json, which is classified as release_version_bump, a documented slop pattern. There is no concrete behavior delta, no new functionality, and the change is purely administrative. The first-pass verdict correctly identifies this as administrative noise with no code or product value.
  • 80e73f5 CONFIRMED_SLOP (behavior delta: none): The commit only adds a CLA signature to cla.json, which is administrative noise with no code or product value. This aligns with the 'cla_admin' slop signal and does not provide any concrete behavior delta or value to the repository's functionality.
  • fe091ef CONFIRMED_SLOP (behavior delta: none): The commit only updates the version number in package.json, which is classified as release_version_bump, a category explicitly marked as non-value adding (SLOP) by the rubric. There's no code change, behavior delta, or product value added beyond administrative metadata update.
  • c9350c6 CONFIRMED_SLOP (behavior delta: none): The commit only updates version numbers in multiple package.json files, which is administrative noise with no code or product value. This aligns with the 'release_version_bump' category, which is explicitly non-mergable as per the guidelines. There's no behavior delta, and the change does not strengthen or weaken any invariants beyond version tracking.

Fork-sync impact assessment

Breaking changes

(none detected)

Dependency changes

(none)

Architecture drift

(none)

Hidden concerns

  • Minor refactor churn in non-critical areas (e.g., create-tools, commands visibility changes)

Action items before merging

  • Review refactor impact in shared, background-agent, and plugin areas for unintended side effects
  • Verify no hidden dependencies in updated package.json versions
  • Manually inspect CLA-related commits for relevance before inclusion

Generated by upstream-analyzer workflow. This issue is advisory: no merges or publishes happen automatically. Phase 1: draft PRs only. The prompt lives in .github/prompts/ and is editable without touching workflow code.

Classify chain: openrouter:qwen/qwen3-coder:free → nvidia:nvidia/llama-3.3-nemotron-super-49b-v1 → github:openai/gpt-4.1-mini
Slop-verify chain: openrouter:nvidia/nemotron-3-super-120b-a12b:free → nvidia:nvidia/llama-3.3-nemotron-super-49b-v1 → github:openai/gpt-4.1
Synthesis chain: openrouter:nvidia/nemotron-3-super-120b-a12b:free → nvidia:nvidia/llama-3.3-nemotron-super-49b-v1 → github:openai/gpt-4.1

Metadata

Metadata

Assignees

No one assigned

    Labels

    cost-benefitupstream-reviewupstream-tag:v3.17.4upstream:cherry-pick

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions