Remove frontend import from backend files

Author: leonm1

__mocks__/svgrMock.js

@@ -1 +1 @@
-module.exports = 'icon-mock';
+module.exports = 'IconMock';

__snapshots__/client/components/Sidebar/Sidebar.test.tsx.snap

@@ -12,7 +12,7 @@ exports[`Test Sidebar Sidebar renders correctly 1`] = `
     >
       <img
         alt="VH graphic"
-        src="icon-mock"
+        src="IconMock"
       />
     </div>
     <hr

__snapshots__/client/routes/dashboard/Frame.test.tsx.snap

@@ -48,7 +48,7 @@ exports[`Test Frame Frame renders correctly 1`] = `
       >
         <img
           alt="VH graphic"
-          src="icon-mock"
+          src="IconMock"
         />
       </div>
       <hr

__snapshots__/client/routes/login/Login.test.tsx.snap

@@ -2,7 +2,7 @@
 
 exports[`Login renders properly 1`] = `
 <div
-  className="sc-fjdhpX ebOgGV"
+  className="sc-fjdhpX dmItWC"
 >
   <div
     className="sc-bdVaJa sc-bwzfXH sc-ifAKCX sc-jzJRlG hPKjIj"
@@ -34,7 +34,7 @@ exports[`Login renders properly 1`] = `
           <img
             alt="Google logo"
             className="sc-iwsKbI kXBzef"
-            src={[Function]}
+            src="IconMock"
           />
         </div>
         <div
@@ -63,7 +63,7 @@ exports[`Login renders properly 1`] = `
           <img
             alt="GitHub logo"
             className="sc-iwsKbI kXBzef"
-            src={[Function]}
+            src="IconMock"
           />
         </div>
         <div

jest.config.js

@@ -21,12 +21,11 @@ module.exports = {
 			testEnvironment: 'jsdom',
 			snapshotResolver: './__mocks__/snapshotResolver',
 			moduleNameMapper: {
-				'../../assets/img/square_hackathon_logo.svg': '<rootDir>/__mocks__/svgrMock.js',
-				'../../assets/img/unchecked_box.svg': '<rootDir>/__mocks__/svgrMock.js',
-				'../../assets/img/checked_box.svg': '<rootDir>/__mocks__/svgrMock.js',
-				'.+\\.svg?.+$': '@svgr/webpack', // see https://github.com/smooth-code/svgr/issues/83
+				// '../../assets/img/square_hackathon_logo.svg': '<rootDir>/__mocks__/svgrMock.js',
+				// '../../assets/img/unchecked_box.svg': '<rootDir>/__mocks__/svgrMock.js',
+				// '../../assets/img/checked_box.svg': '<rootDir>/__mocks__/svgrMock.js',
+				'\\.svg': '<rootDir>/__mocks__/svgrMock.js', // see https://github.com/smooth-code/svgr/issues/83
 				'\\.(css|less)$': 'jest-transform-css',
-
 				'\\.(jpg|jpeg|png|gif)$': '<rootDir>/__mocks__/svgrMock.js',
 			},
 			transform: {

src/client/assets/application.js

@@ -98,7 +98,6 @@ export const questions = [
 				Component: Slider,
 				default: '2019',
 				fieldName: 'gradYear',
-				optional: true,
 				options: ['2019', '2020', '2021', '2022', '2023', 'Other'],
 				other: true,
 				title: 'Graduation Year',

src/server/resolvers/index.ts

@@ -14,8 +14,27 @@ import Context from '../context';
 import { fetchUser, query, queryById, toEnum, updateUser, checkIsAuthorized } from './helpers';
 import { checkInUserToEvent, removeUserFromEvent, registerNFCUIDWithUser } from '../nfc';
 import { getSignedUploadUrl, getSignedReadUrl } from '../storage/gcp';
-import appConfig from '../../client/assets/application';
-import { ConfigField } from '../../client/routes/application/Application';
+
+// TODO: Cannot import frontend files so this is ugly workaround. Fix this.
+const requiredFields = [
+	'firstName',
+	'lastName',
+	'shirtSize',
+	'gender',
+	'phoneNumber',
+	'dateOfBirth',
+	'school',
+	'major',
+	'gradYear',
+	'race',
+	'favArtPiece',
+	'essay1',
+	'volunteer',
+	'resume',
+	'codeOfConduct',
+	'infoSharingConsent',
+];
+
 /**
  * Used to define a __resolveType function on the User resolver that doesn't take in a promise. This is important as it
  */
@@ -240,12 +259,9 @@ export const resolvers: CustomResolvers<Context> = {
 			 * Finds the first element that is required (not optional) but does not have any input.
 			 * If this element exists, the application is not finished.
 			 */
-			const appFinished = !appConfig
-				.flatMap(section => section.fields as ConfigField[])
-				.some(
-					field =>
-						!field.optional && !args.input.find(el => el.question === field.fieldName && el.answer)
-				);
+			const appFinished = !requiredFields.some(
+				field => !args.input.find(el => el.question === field && el.answer)
+			);
 
 			// Update the fields of the hacker object with application data.
 			// TODO: Improve the quality of this resolver by removing this hack.