@@ -650,7 +650,7 @@ bool ElfView::Init()
650
650
vector<string> readWriteDataSectionNames = {" .data" , " .bss" };
651
651
vector<string> readOnlyDataSectionNames = {" .rodata" , " .dynamic" , " .dynsym" , " .dynstr" , " .ehframe" ,
652
652
" .ctors" , " .dtors" , " .got" , " .got2" , " .data.rel.ro" , " .gnu.hash" };
653
- if ((m_elfSections[i].flags & ELF_SHF_EXECINSTR) || In (sectionNames[i], readOnlyCodeSectionNames))
653
+ if ((m_elfSections[i].flags & ELF_SHF_EXECINSTR) || In (sectionNames[i], readOnlyCodeSectionNames))
654
654
semantics = ReadOnlyCodeSectionSemantics;
655
655
else if (!(m_elfSections[i].flags & ELF_SHF_WRITE) || In (sectionNames[i], readOnlyDataSectionNames))
656
656
semantics = ReadOnlyDataSectionSemantics;
@@ -1693,8 +1693,7 @@ bool ElfView::Init()
1693
1693
1694
1694
for (auto & s : gotSectionsToCreate)
1695
1695
{
1696
- // Don't try creating a section if it starts in an already-created
1697
- // section.
1696
+ // Don't try creating a section if it starts in an already-created section.
1698
1697
if (GetSectionsAt (s.first ).size () > 0 )
1699
1698
continue ;
1700
1699
@@ -2376,8 +2375,8 @@ bool ElfView::Init()
2376
2375
DefineAutoSymbol (new Symbol (DataSymbol, " __elf_rela_table" , m_relocaSection.offset , NoBinding));
2377
2376
}
2378
2377
2379
- // In 32-bit mips with .got, add .extern symbol "RTL_Resolve"
2380
- if (gotStart && In (m_arch->GetName (), { " mips32 " , " mipsel32 " , " mips64 " , " nanomips " } ))
2378
+ // Create resolver symbol for MIPS load files containing a global offset table
2379
+ if (gotStart && (m_arch->GetName (). find ( " mips " ) != std::string::npos ))
2381
2380
{
2382
2381
const char *name = " RTL_Resolve" ;
2383
2382
0 commit comments