VFP instructions are not implemented in Thumb2 IL lifter

[joelreymont]

Version and Platform (required):

• Binary Ninja Version: 3.4.4242-dev, 2e3a4286
• OS: macos
• OS Version: 13.3
• CPU Architecture: arm64

A load of VFP instructions are not implemented in Thumb2 mode. Also others like UMLAL. I started fixing this already but figure an issue is need to track the work.

[plafosse]

Great! Thanks for the code. If you submit a PR we can get that accepted. Please note that we've started our release process today so we won't be accepting an PRs for the next 2 weeks, as we work on stability and bug fixes.

[joelreymont]

What do I need to do to complete a PR? What's missing in the code? Testing? Anything else?

[plafosse]

Nothing really. What would be helpful is some before/after screenshots and a binary if possible.

[joelreymont]

I still want to tackle VFMA, VPUSH, VPOP, VCMP, VMRS, VLDMIA, VDIV, VNEG, VCVT, VABS and SMLABB. I may be able to finish them in the next two weeks. I'll submit a PR once I'm done.

…

On Wed, Apr 19, 2023 at 5:31 PM Peter LaFosse ***@***.***> wrote: Nothing really. What would be helpful is some before/after screenshots and a binary if possible. — Reply to this email directly, view it on GitHub <#4248 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAESZ6AE7ZF2ZHNP5U3PITXB7ZNDANCNFSM6AAAAAAXEEEK6Q> . You are receiving this because you authored the thread.Message ID: ***@***.***>