Update shopt.sh by Ven0m0 · Pull Request #154 · Ven0m0/dotfiles

Ven0m0 · 2026-01-04T13:13:49Z

No description provided.

continue · 2026-01-04T13:13:52Z

Learn more

All Green is an AI agent that automatically:

✅ Addresses code review comments

✅ Fixes failing CI checks

✅ Resolves merge conflicts

Unsubscribe from All Green comments

github-actions · 2026-01-04T13:14:00Z

🤖 Hi @Ven0m0, I've received your request, and I'm working on it now! You can track my progress in the logs for more details.

gemini-code-assist · 2026-01-04T13:14:11Z

Summary of Changes

Hello @Ven0m0, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the shopt.sh script to significantly reduce its reliance on external tools for preprocessing, string manipulation, and code formatting. By implementing core functionalities directly in bash or leveraging standard utilities like sed and awk, the script becomes more self-contained and robust. Additionally, logging has been enhanced with colored output for better readability, and the overall code structure has been streamlined.

Highlights

Dependency Reduction: The script now relies less on external tools by implementing functionalities like preprocessing and string normalization directly in bash or using standard utilities like sed and awk. Specifically, external preprocess, beautysh, and sd tools are no longer required.
Native Bash Preprocessor: A new preprocess_shell function has been introduced, providing a pure bash implementation for handling conditional compilation directives (#ifdef, #ifndef, #else, #endif), replacing the need for the external preprocess utility.
Enhanced Logging: Logging functions have been refactored to include colored output (clog, cwarn, cerr), improving the readability and clarity of messages printed to the console.
Simplified Formatting: The script now exclusively uses shfmt for code formatting, removing the dependency on beautysh and streamlining the formatting process.
Variant Handling Updates: The default shell variants for compilation have been narrowed down to bash only, and the command-line parsing for the -V (variants) option has been explicitly added and clarified in the usage message.

Ignored Files

Ignored by pattern: .github/workflows/** (9)
- .github/workflows/claude-code-review.yml
- .github/workflows/claude-pr-auto-review.yml
- .github/workflows/claude.yml
- .github/workflows/codacy.yml
- .github/workflows/dependency-review.yml
- .github/workflows/eslint.yml
- .github/workflows/gemini-scheduled-triage.yml
- .github/workflows/pyre.yml
- .github/workflows/summary.yml

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request introduces a significant refactoring of the shopt.sh script. The main changes include removing external dependencies like preprocess, sd, and beautysh, and replacing them with pure bash implementations or standard tools like sed and shfmt. A new pure-bash preprocessor for handling #ifdef-style directives is added. The logging functions have also been refactored for better clarity.

Overall, these changes are a great improvement, making the script more self-contained and portable. I've found a few issues, including a critical bug in environment variable setting and some typos in regular expressions that break functionality. I've also noted a logic bug in the new preprocessor and a point about bash version compatibility.

Home/.local/bin/shopt.sh

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

Copilot

Pull request overview

This PR refactors the shopt.sh shell script optimizer and updates GitHub Actions workflows. The main focus is replacing external preprocessor dependencies with a pure Bash implementation and consolidating workflow files for Claude AI integration.

Key Changes

Replaced external preprocess dependency with a custom pure Bash preprocessor for shell variant handling
Removed dependencies on optional tools (sd, beautysh, preprocess) and consolidated normalization into native sed
Consolidated GitHub Actions workflows: removed 5 security/analysis workflows and added 2 new Claude AI workflows

Reviewed changes

Copilot reviewed 9 out of 10 changed files in this pull request and generated 8 comments.

Show a summary per file

File	Description
`Home/.local/bin/shopt.sh`	Major refactor: added pure Bash preprocessor, removed external tool dependencies, improved logging functions, fixed find command grouping
`.github/workflows/claude.yml`	New workflow for Claude AI mention-based triggers on issues and PRs
`.github/workflows/claude-code-review.yml`	New workflow for automatic PR reviews using Claude AI
`.github/workflows/summary.yml`	Removed AI inference workflow for issue summarization
`.github/workflows/pyre.yml`	Removed Python type checking workflow
`.github/workflows/gemini-scheduled-triage.yml`	Removed Gemini-based issue triage workflow
`.github/workflows/eslint.yml`	Removed ESLint security scanning workflow
`.github/workflows/dependency-review.yml`	Removed dependency review workflow
`.github/workflows/codacy.yml`	Removed Codacy security scanning workflow
`.github/workflows/claude-pr-auto-review.yml`	Removed older Claude PR auto-review workflow

Copilot · 2026-01-04T13:18:26Z

Home/.local/bin/shopt.sh

+      local var="${BASH_REMATCH[1]}"
+      stack+=("$active")
+      ((depth++))
+      ((active == 1 && var == "$def")) && active=1 || active=0
+    elif [[ $line =~ ^[[:space:]]*#ifndef[[:space:]]+(.+)$ ]]; then
+      local var="${BASH_REMATCH[1]}"


Variable line is declared in the function parameters but then redeclared inside the loop with local var="${BASH_REMATCH[1]}". The variable name conflicts with the loop variable line.

This will cause the variable name var to shadow or conflict with the intended usage, potentially breaking the preprocessor logic.

Copilot · 2026-01-04T13:18:26Z

Home/.local/bin/shopt.sh

-[[ ${#files[@]} -gt 1 && -n $output && $output != - ]] && ((! compile && !concat)) && die "Multiple files with single output unsupported (use -c/--compile)"
-
-read -r -d '' AWK_STRIP <<'AWK' || : 
+# AWK script:  strip comments/blank lines, keep shebang


Missing space in comment formatting. The comment should have consistent spacing: # AWK script: strip instead of # AWK script: strip (double space after colon).

Suggested change

# AWK script: strip comments/blank lines, keep shebang

# AWK script: strip comments/blank lines, keep shebang

Copilot · 2026-01-04T13:18:26Z

Home/.local/bin/shopt.sh

+  local -a stack=() line
+  local active=1 depth=0


Variable line is incorrectly declared in the local declaration on line 90. The declaration local -a stack=() line declares line as part of an array declaration statement, but line should be a scalar variable for use in the while loop.

This should be split into two separate declarations: one for the array and one for the scalar.

Suggested change

local -a stack=() line

local active=1 depth=0

local -a stack=()

local line active=1 depth=0

Copilot · 2026-01-04T13:18:27Z

Home/.local/bin/shopt.sh

  files=("$target")
 fi
+((${#files[@]} == 0 && !compile && !concat)) && { clog "No scripts found"; exit 0; }
+[[ ${#files[@]} -gt 1 && -n $output && $output != - ]] && ((!  compile && !concat)) && die "Multiple files require -c/--compile"


Missing space before the negation operator. The condition has a double space: ((! compile should be ((! compile with a single space.

Suggested change

[[ ${#files[@]} -gt 1 && -n $output && $output != - ]] && ((! compile && !concat)) && die "Multiple files require -c/--compile"

[[ ${#files[@]} -gt 1 && -n $output && $output != - ]] && ((! compile && !concat)) && die "Multiple files require -c/--compile"

Copilot · 2026-01-04T13:18:27Z

Home/.local/bin/shopt.sh

-
 if ((compile || concat)); then
-  [[ !  -d $target ]] && die "Compile/concat mode needs directory"
+  [[ ! -d $target ]] && die "Compile/concat mode needs directory"


Unquoted variable in test expression. The variable $target should be quoted to prevent word splitting and glob expansion.

This violates bash best practices and can cause unexpected behavior if the target path contains spaces or special characters.

Suggested change

[[ ! -d $target ]] && die "Compile/concat mode needs directory"

[[ ! -d "$target" ]] && die "Compile/concat mode needs directory"

Copilot · 2026-01-04T13:18:27Z

Home/.local/bin/shopt.sh

+      stack+=("$active")
+      ((depth++))
+      ((active == 1 && var == "$def")) && active=1 || active=0
+    elif [[ $line =~ ^[[:space:]]*#ifndef[[:space:]]+(.+)$ ]]; then


The regex pattern has a typo with an incorrect character class syntax. The pattern [[: space:]] is malformed - there should be a colon immediately after the opening bracket.

This will cause the regex match to fail, preventing the preprocessor from recognizing #ifndef directives.

Copilot · 2026-01-04T13:18:27Z

Home/.local/bin/shopt.sh

-      continue
-    }
    [[ $line =~ ^#!  ]] && continue
    if [[ $line =~ ^[[:space:]]*# ]]; then


The regex pattern has a typo with an incorrect character class syntax. The pattern [[: space:]] is malformed - there should be a colon immediately after the opening bracket.

This will cause comment detection to fail during the minification process.

Copilot · 2026-01-04T13:18:28Z

Home/.local/bin/shopt.sh

+      ((NR <= 10)) && [[ $line =~ Copyright|License ]] && { printf '%s\n' "$line" >>"$out"; continue; }
      continue
    fi
    line=$(sed -E 's/^[[:space:]]*function[[:space:]]+([a-zA-Z0-9_]+)[[:space:]]*\{/\1(){/g' <<<"$line")


The regex pattern has a typo with an incorrect character class syntax. The pattern [[: space:]] is malformed - there should be a colon immediately after the opening bracket.

This will cause the function normalization pattern to fail during minification.

Ven0m0 added 9 commits January 4, 2026 14:08

Update shopt.sh

df01eab

Update and rename claude-pr-auto-review.yml to claude-code-review.yml

6f12232

Create claude.yml

0dcc596

Delete .github/workflows/pyre.yml

77cff98

Delete .github/workflows/summary.yml

20fa38e

Delete .github/workflows/eslint.yml

89f1bb2

Delete .github/workflows/codacy.yml

46acff9

Delete .github/workflows/dependency-review.yml

0d0330d

Delete .github/workflows/gemini-scheduled-triage.yml

c002577

Copilot AI review requested due to automatic review settings January 4, 2026 13:13

repo-command bot added the ready for review label Jan 4, 2026

Copilot started reviewing on behalf of Ven0m0 January 4, 2026 13:14 View session

gemini-code-assist bot reviewed Jan 4, 2026

View reviewed changes

Ven0m0 and others added 6 commits January 4, 2026 14:16

Update Home/.local/bin/shopt.sh

6940d28

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

Update Home/.local/bin/shopt.sh

3f27636

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

Update Home/.local/bin/shopt.sh

a4cc1e5

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

Update Home/.local/bin/shopt.sh

e912242

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

Update Home/.local/bin/shopt.sh

3a13913

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

Update Home/.local/bin/shopt.sh

55766ce

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

Ven0m0 merged commit 60a9e89 into main Jan 4, 2026
3 of 8 checks passed

Ven0m0 deleted the local/bin branch January 4, 2026 13:17

repo-command bot added merged and removed ready for review labels Jan 4, 2026

Copilot AI reviewed Jan 4, 2026

View reviewed changes

	# AWK script: strip comments/blank lines, keep shebang
	# AWK script: strip comments/blank lines, keep shebang

	[[ ${#files[@]} -gt 1 && -n $output && $output != - ]] && ((! compile && !concat)) && die "Multiple files require -c/--compile"
	[[ ${#files[@]} -gt 1 && -n $output && $output != - ]] && ((! compile && !concat)) && die "Multiple files require -c/--compile"

	[[ ! -d $target ]] && die "Compile/concat mode needs directory"
	[[ ! -d "$target" ]] && die "Compile/concat mode needs directory"

Uh oh!

Conversation

Ven0m0 commented Jan 4, 2026

Uh oh!

continue bot commented Jan 4, 2026

Uh oh!

github-actions bot commented Jan 4, 2026

Uh oh!

gemini-code-assist bot commented Jan 4, 2026

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Key Changes

Reviewed changes

Uh oh!

Copilot AI Jan 4, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 4, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 4, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 4, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 4, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 4, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 4, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 4, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants