lsp-client-features does not mention vim.lsp.completion.enable

[aktau]

I found

lsp-zero-docs/content/blog/lsp-client-features.md

Line 166 in e99e304

### Simple tab complete

through Google, because I wanted to check how other people were doing things. It's pretty neat.

Given that you mention on this page that this deals with Neovim v0.11 features, I would've expected a mention of vim.lsp.completion.enable. The "Simple tab completion" header seems like a v0.10 holdover. I know you know of this, since later I found https://vonheikemen.github.io/devlog/tools/neovim-lsp-client-guide/. Maybe one page should reference the others? There seems to be some duplication.

Thanks for writing these articles, they're quite helpful.

[VonHeikemen]

Given that you mention on this page that this deals with Neovim v0.11 features, I would've expected a mention of vim.lsp.completion.enable.

It is there. Completion side effects. In the opt-in features section.

lsp-zero-docs/content/blog/lsp-client-features.md

Lines 68 to 86 in e99e304

	### Completion side effects
	These are additional actions a language server can send. It could be something simple like adding parenthesis on a function call, or something more complex like adding a missing import if the completion item is a class name.
	You can also enable autotrigger. This will make Neovim show the completion menu when you type a "trigger character" set by the language server.
	To opt-in to these features we must call the function [vim.lsp.completion.enable()](https://neovim.io/doc/user/lsp.html#vim.lsp.completion.enable()).
	```lua
	vim.api.nvim_create_autocmd('LspAttach', {
	callback = function(args)
	local client = vim.lsp.get_client_by_id(args.data.client_id)
	if client:supports_method('textDocument/completion') then
	vim.lsp.completion.enable(true, client.id, args.buf, {autotrigger = true})
	end
	end,
	})
	```

---

I found https://vonheikemen.github.io/devlog/tools/neovim-lsp-client-guide/. Maybe one page should reference the others?

I think is fine the way it is. The old post on github.io has too many details. Over the years I've found people get overwhelmed pretty easily. The new one on lsp-zero's site only has the chunks of code most people care about.

[aktau]

It is there. Completion side effects. In the opt-in features section.

You're right. I think I had too many tabs open and one of your pages didn't have a mention of completion where I woul've expected it. It's somewhat dizzying to compare and contrast to make sure I didn't miss anything.

As you say, this is likely fine for more of your readers since they'll just read the one page they landed on and it will generally contain something useful.

But, even so, on [the page I mentioned]((

lsp-zero-docs/content/blog/lsp-client-features.md

Line 166 in e99e304

### Simple tab complete

), there is no mention in the "Simple tab complete" section that this is superseded in a sense by vim.lsp.completion.enable(). That could perhaps use a backreference, as in: you can use this if you're on v0.10, for v0.11 vim.lsp.completion is the more complete solution with builtin snippet support.

Similarly, https://vonheikemen.github.io/devlog/tools/neovim-lsp-client-guide/ mentions a homegrown v0.10 version of tab completion before mentioning vim.lsp.completion. That mention is also under "Expand snippets", something which I'm much less interested in than "autocompletion" (I don't use snippets, and the only LSP I use which has them needs them explicitly enabled).

I think it'd be clearer in both posts to first present the v0.11 version, and then follow up with a fallback for v0.10 or lower.

Anyway, that's just my two cents. Thanks for the posts.

[VonHeikemen]

there is no mention in the "Simple tab complete" section that this is superseded in a sense by vim.lsp.completion.enable()

I don't think about it like that.

The default behavior in vim.lsp.completion.enable doesn't replace the tab complete keymaps. Even if you do enable autotrigger the way it works is so "basic" that you'll still need a way to trigger the completion menu manually.

[aktau]

the way it works is so "basic" that you'll still need a way to trigger the completion menu manually.

OK sure, tab-completion can be an enhancement.

fwiw, I just set a manual trigger like this:

    -- Trigger lsp completion manually using Ctrl + Space
    vim.keymap.set('i', '<C-Space>', '<cmd>lua vim.lsp.completion.trigger()<cr>')

Do you know if there is any difference between <C-x><C-o and vim.lsp.completion.trigger()? Is the former just more generic?

[aktau]

Somewhat relatedly, I notice:

vim.opt.completeopt = {'menu', 'menuone', 'noselect', 'noinsert'}

I've been making use of completeopt+=fuzzy as a way to avoid the need for a fuzzy finding plugin, and find that it works quite well. You may want to mention it too.

[VonHeikemen]

Do you know if there is any difference between <C-o and vim.lsp.completion.trigger()? Is the former just more generic?

Right now they are the same.

vim.lsp.completion.trigger might do other things in the future. My guess is <C-x><C-o> will remain fixed to whatever behavior fits best with the omnifunc feature that was inherited from vim.

And by the way, I think vim.lsp.completion.trigger was renamed to vim.lsp.completion.get somewhat recently.

I've been making use of completeopt+=fuzzy as a way to avoid the need for a fuzzy finding plugin, and find that it works quite well. You may want to mention it too.

I haven't tried myself. Will have to use it for a while to see how it works. Thank you for mention it.