Skip to content

Commit f4ebdfa

Browse files
authored
changing numbers API to use header authentication (#255)
1 parent d338f37 commit f4ebdfa

File tree

2 files changed

+11
-16
lines changed

2 files changed

+11
-16
lines changed

src/vonage/client.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@
2525
import re
2626
from uuid import uuid4
2727

28+
from requests import Response
2829
from requests.adapters import HTTPAdapter
2930
from requests.sessions import Session
3031

@@ -269,7 +270,7 @@ def delete(self, host, request_uri, auth_type=None):
269270
logger.debug(f"DELETE to {repr(uri)} with headers {repr(self._request_headers)}")
270271
return self.parse(host, self.session.delete(uri, headers=self._request_headers, timeout=self.timeout))
271272

272-
def parse(self, host, response):
273+
def parse(self, host, response: Response):
273274
logger.debug(f"Response headers {repr(response.headers)}")
274275
if response.status_code == 401:
275276
raise AuthenticationError("Authentication failed. Check you're using a valid authentication method.")

src/vonage/number_management.py

Lines changed: 9 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -1,32 +1,26 @@
11
class Numbers:
2-
auth_type = 'params'
2+
auth_type = 'header'
33
defaults = {'auth_type': auth_type, 'body_is_json': False}
44

55
def __init__(self, client):
66
self._client = client
7-
7+
88
def get_account_numbers(self, params=None, **kwargs):
99
return self._client.get(self._client.host(), "/account/numbers", params or kwargs, auth_type=Numbers.auth_type)
1010

1111
def get_available_numbers(self, country_code, params=None, **kwargs):
1212
return self._client.get(
13-
self._client.host(),
14-
"/number/search",
15-
dict(params or kwargs, country=country_code),
16-
auth_type=Numbers.auth_type
13+
self._client.host(),
14+
"/number/search",
15+
dict(params or kwargs, country=country_code),
16+
auth_type=Numbers.auth_type,
1717
)
1818

1919
def buy_number(self, params=None, **kwargs):
20-
return self._client.post(
21-
self._client.host(), "/number/buy", params or kwargs, **Numbers.defaults
22-
)
20+
return self._client.post(self._client.host(), "/number/buy", params or kwargs, **Numbers.defaults)
2321

2422
def cancel_number(self, params=None, **kwargs):
25-
return self._client.post(
26-
self._client.host(), "/number/cancel", params or kwargs, **Numbers.defaults
27-
)
23+
return self._client.post(self._client.host(), "/number/cancel", params or kwargs, **Numbers.defaults)
2824

2925
def update_number(self, params=None, **kwargs):
30-
return self._client.post(
31-
self._client.host(), "/number/update", params or kwargs, **Numbers.defaults
32-
)
26+
return self._client.post(self._client.host(), "/number/update", params or kwargs, **Numbers.defaults)

0 commit comments

Comments
 (0)