Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow ignoring files with paketkoll check #158

Open
VorpalBlade opened this issue Feb 17, 2025 · 0 comments
Open

Allow ignoring files with paketkoll check #158

VorpalBlade opened this issue Feb 17, 2025 · 0 comments
Labels
A-paketkoll Area: paketkoll C-enhancement Category: New feature or request

Comments

@VorpalBlade
Copy link
Owner

Broken out from issue #157.

Only check-unexpected allows for passing ignores currently. It would be nice to have that for check too, though the implementation is quite different, so it would be a separate implementation.

It should not be done as a filter at the end, it would be more efficient to simply not check files at all. Look into if the API of the ignore crate that we currently use is suitable or if we need to build our own regex-set instead. We shouldn't need to take on a new dependency for this.

cc @mbideau (original reporter)

@VorpalBlade VorpalBlade added C-enhancement Category: New feature or request A-paketkoll Area: paketkoll labels Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-paketkoll Area: paketkoll C-enhancement Category: New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant