Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in kwargs in print_convergencehistory #17

Closed
jpthiele opened this issue Nov 19, 2024 · 3 comments
Closed

Typo in kwargs in print_convergencehistory #17

jpthiele opened this issue Nov 19, 2024 · 3 comments

Comments

@jpthiele
Copy link
Contributor

The keyword argument seperated should be separated.
I am not sure how much this is used and I can look into ways to deprecate such an argument.

Since we are still on 0.x we could also 'simply' rename this and hope no-one is using it so far.

@j-fu
Copy link
Member

j-fu commented Nov 19, 2024

Just as a remark: at this point, Julia extends the notion of semver: Julia Pkg considers a change from 0.n to 0.n+1 as breaking.

BTW that is why I nowadays think that makes sense to move to versions 1.x as early as possible.

@chmerdon
Copy link
Member

I think nobody else is using this particular function, so I would not mind to simply rename it at this stage.

Before releasing 1.0 I think we should think about refactoring some bulky parts of the code like the FEEvaluator as @jpthiele and @pjaap already suggested earlier.

@pjaap
Copy link
Member

pjaap commented Nov 20, 2024

fixed by #18

@pjaap pjaap closed this as completed Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants