Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vision Pro Unity Support #223

Closed
Biso240 opened this issue Apr 27, 2024 · 13 comments
Closed

Vision Pro Unity Support #223

Biso240 opened this issue Apr 27, 2024 · 13 comments
Assignees
Labels
bug Something isn't working

Comments

@Biso240
Copy link

Biso240 commented Apr 27, 2024

hi, I would like to ask if it is possible to make a version also for the vision pro as Unity modal does not work for it at the moment. A thousand thanks

@skibitsky
Copy link
Member

Hello,

What exactly isn't working?

@Biso240
Copy link
Author

Biso240 commented Apr 30, 2024

When I try to build for visionOS(Windowed Mode), the unity compiler give me this errors(I'm logged because in the editor works):
Screenshot 2024-04-30 alle 2 48 34 PM

@skibitsky
Copy link
Member

  1. Did you install packages through OpenUPM or directly from git?
  2. If you installed directly from git, do you also have com.walletconnect.core installed?
  3. Are you encountering similar errors when the target platform is iOS?
  4. What version of Unity are you using?

@skibitsky
Copy link
Member

Unable to reproduce with Unity 2022.3.18. I don't get the errors.
Screenshot 2024-04-30@2x

@Biso240
Copy link
Author

Biso240 commented Apr 30, 2024

I tried from git and also from OpenUPM. For iOS it works, but for VisionOs no. I have the 2022.3.24f1 version and I will try with your version

@Biso240
Copy link
Author

Biso240 commented Apr 30, 2024

also with your unity version doesn't work :(

@Biso240
Copy link
Author

Biso240 commented Apr 30, 2024

if I build in this way: like an IpadOS app, it works

Screenshot 2024-04-30 alle 7 35 42 PM

@skibitsky
Copy link
Member

Does it work for you in the Editor with VisionOS as the target platform?

@skibitsky
Copy link
Member

I was able to reproduce it. It happens when building for VisionOS.

@skibitsky skibitsky self-assigned this May 1, 2024
@skibitsky skibitsky added the bug Something isn't working label May 1, 2024
@skibitsky
Copy link
Member

Temporary workaround

  • Manually download packages directly into Package directory to enable write access
  • From the Inspector enable visionOS platform for Packages/com.walletconnect.core/Runtime/WalletConnectUnity.Core.asmdef and apply changes

@Biso240 let me know if that helps. I'll include visionOS in the next release.

@skibitsky
Copy link
Member

@Biso240, could you please test this PR? I also fixed the UI layout setting; it will now use wallet deep link by default , similar to how it works on mobile.

#225

@Biso240
Copy link
Author

Biso240 commented May 2, 2024

Ok I can now build for VisionOs and build it into Vision Pro. After I got the same issue that you can find it also in IOS and Android. #224

@skibitsky
Copy link
Member

Nice, I'm working on #224, but it shouldn't block you from development. I'll try to release a fix next week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants