fix: drop useless MARK rule

Author: MatteoPreti

WeTransferPRLinter/Sources/WeTransferPRLinter/WeTransferPRLinter.swift

@@ -34,10 +34,6 @@ public enum WeTransferPRLinter {
             validateWorkInProgress(using: danger)
         }
 
-        measure(taskName: "Validating Files", danger: danger) {
-            validateFiles(using: danger)
-        }
-
         measure(taskName: "Bitrise URL showing", danger: danger) {
             showBitriseBuildURL(using: danger, environmentVariables: environmentVariables)
         }
@@ -207,28 +203,6 @@ public enum WeTransferPRLinter {
     }
 }
 
-extension WeTransferPRLinter {
-    /// Validates the added and modified files.
-    static func validateFiles(using danger: DangerDSL) {
-        let allFiles = Set(danger.git.createdFiles).union(danger.git.modifiedFiles)
-        let swiftFiles = allFiles.filter { $0.fileType == FileType.swift }
-
-        swiftFiles.forEach { file in
-            let lines = danger.utils.readFile(file).components(separatedBy: .newlines)
-            validateMarkUsage(using: danger, file: file, lines: lines)
-        }
-    }
-
-    /// Warns if a big files is containing any MARK comments.
-    static func validateMarkUsage(using danger: DangerDSL, file: Danger.File, lines: [String], minimumLinesCount: Int = 300) {
-        guard !file.lowercased().contains("test"), lines.count >= minimumLinesCount else { return }
-        let containsMark = lines.contains(where: { line in line.contains("MARK:") })
-        guard !containsMark else { return }
-
-        danger.warn("Consider to place some `MARK:` lines for \(file), which is over \(minimumLinesCount) lines big.")
-    }
-}
-
 extension String {
     /// Whether the current String contains a class definition.
     var isClassDefinition: Bool {

WeTransferPRLinter/Tests/WeTransferPRLinterTests/WeTransferLinterTests.swift

@@ -70,52 +70,6 @@ final class WeTransferLinterTests: XCTestCase {
         XCTAssertEqual(danger.warnings.first?.message, "PR is classed as Work in Progress")
     }
 
-    /// It should warn for using Mark in big files without any mark.
-    func testMarkUsage() {
-        let danger = DangerDSL(testSettings: [:])
-        WeTransferPRLinter.validateMarkUsage(using: danger, file: "File.swift", lines: [
-            "func myMethod() {",
-            "print(\"something\")",
-            "}"
-        ], minimumLinesCount: 2)
-        XCTAssertEqual(danger.warnings.count, 1)
-        XCTAssertEqual(danger.warnings.first?.message, "Consider to place some `MARK:` lines for File.swift, which is over 2 lines big.")
-    }
-
-    /// It should not warn for using Mark in small files without any mark.
-    func testMarkUsageSmallFiles() {
-        let danger = DangerDSL(testSettings: [:])
-        WeTransferPRLinter.validateMarkUsage(using: danger, file: "File.swift", lines: [
-            "func myMethod() {",
-            "print(\"something\")",
-            "}"
-        ], minimumLinesCount: 5)
-        XCTAssertEqual(danger.warnings.count, 0)
-    }
-
-    /// It should not warn for using Mark in big files if a mark is used.
-    func testMarkAlreadyUsed() {
-        let danger = DangerDSL(testSettings: [:])
-        WeTransferPRLinter.validateMarkUsage(using: danger, file: "File.swift", lines: [
-            "MARK: Methods",
-            "func myMethod() {",
-            "print(\"something\")",
-            "}"
-        ], minimumLinesCount: 2)
-        XCTAssertEqual(danger.warnings.count, 0)
-    }
-
-    /// It should not warn for using Mark in test files.
-    func testMarkUsageInTests() {
-        let danger = DangerDSL(testSettings: [:])
-        WeTransferPRLinter.validateMarkUsage(using: danger, file: "FileTests.swift", lines: [
-            "func myMethod() {",
-            "print(\"something\")",
-            "}"
-        ], minimumLinesCount: 2)
-        XCTAssertEqual(danger.warnings.count, 0)
-    }
-
     /// It should show the Bitrise URL if it's set.
     func testBitriseURL() {
         let danger = DangerDSL(testSettings: [:])