Skip to content

Commit 0b0581a

Browse files
authored
Fix some outdated comments (#4617)
* We implemented specialization of field types (the TypeRefining pass). * LUBFinder now handles nulls, so we need nothing extra for it in TypeRefining.
1 parent b337a11 commit 0b0581a

File tree

2 files changed

+2
-6
lines changed

2 files changed

+2
-6
lines changed

src/passes/GlobalTypeOptimization.cpp

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,6 @@
2121
// * Immutability: If a field has no struct.set, it can become immutable.
2222
// * Fields that are never read from can be removed entirely.
2323
//
24-
// TODO: Specialize field types.
25-
//
2624

2725
#include "ir/effects.h"
2826
#include "ir/localize.h"

src/passes/TypeRefining.cpp

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -32,10 +32,8 @@ namespace wasm {
3232

3333
namespace {
3434

35-
// We use a LUBFinder to track field info. A LUBFinder keeps track of the best
36-
// possible LUB so far. The only extra functionality we need here is whether
37-
// there is a default null value (which would force us to keep the type
38-
// nullable).
35+
// We use a LUBFinder to track field info, which includes the best LUB possible
36+
// as well as relevant nulls (nulls force us to keep the type nullable).
3937
using FieldInfo = LUBFinder;
4038

4139
struct FieldInfoScanner

0 commit comments

Comments
 (0)