Skip to content
This repository was archived by the owner on Aug 27, 2023. It is now read-only.
This repository was archived by the owner on Aug 27, 2023. It is now read-only.

Make dataCSV & filteredData in reports/index.js be sorted consistently #261

@blimpich

Description

@blimpich

if a report doesn't ever get filtered, then the columns will be out of order (ie in inventory shipments, without modifying anything, material number ends up on the far right). This is because when a table is filtered in any way the piece of state used to create the csv is grabbed from the table state itself, which is ordered, but when its not filtered it uses the dataCSV from when we made the csv data ourself not by grabbing from the table state, which means that it isn't necessarilly in order. We could potentialy fix this by figuring out how we're ordering our fields in report/util.js, or potentially by reworking how the csv gets generated in reports/index.js. This is fairly low priority though since it doesn't really break anything and if you really need your columns in order you can just filter the csv by something arbitrarily and then unfilter it and they will be ordered then. Shows probably though that reports will eventually need an overhaul

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingrefactororganize the code in a better way

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions