Skip to content

Commit 02dd6ac

Browse files
committed
refactor: add TODO
1 parent 37cff1c commit 02dd6ac

1 file changed

Lines changed: 3 additions & 0 deletions

File tree

  • src/entry-points/content/ElementPlaybackControllerCloning

src/entry-points/content/ElementPlaybackControllerCloning/Lookahead.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -574,6 +574,9 @@ export default class Lookahead {
574574
// we don't loose too much time not skipping them anyway.
575575
if (silenceDuration < 0.010) {
576576
if (IS_DEV_MODE) {
577+
// TODO refactor: we call `pushNewSilenceRange` regardless of whether
578+
// the silence was long enough to be skipped given `marginBefore` and
579+
// `marginAfter`, so this warning is giving false alarms.
577580
if (silenceDuration <= 0) {
578581
if (silenceDuration < -0.050) {
579582
console.error('Huge negative silence duration', silenceDuration);

0 commit comments

Comments
 (0)