Improve compatibility with legacy SQLite versions #302
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JanJakes
force-pushed
the
on-conflict-clause-legacy-fix
branch
20 times, most recently
from
ae3a212 to
a713a67
Compare
JanJakes
force-pushed
the
on-conflict-clause-legacy-fix
branch
9 times, most recently
from
53d0133 to
3932f95
Compare
JanJakes
force-pushed
the
on-conflict-clause-legacy-fix
branch
from
36a0880 to
2576a15
Compare
JanJakes
changed the title
ON CONFLICT clause) on SQLite < 3.35.0
JanJakes
force-pushed
the
on-conflict-clause-legacy-fix
branch
4 times, most recently
from
570a5a0 to
815aa76
Compare
JanJakes
force-pushed
the
on-conflict-clause-legacy-fix
branch
from
815aa76 to
3bb586b
Compare
…h SQLite < 3.33.0
…upport on old SQLite versions
JanJakes
force-pushed
the
on-conflict-clause-legacy-fix
branch
from
3bb586b to
7e14b6e
Compare
Contributor
|
I didn't test each case individually, but I tested the changes on the Studio and Studio preview sites. It worked well in all cases. Code-wise looks good. It's great that we are adding support for older SQLite versions, as it will improve support on some LTS images. |
wojtekn
approved these changes
Jan 15, 2026
JanJakes
commented
Jan 15, 2026
| rowid, | ||
| row_number() OVER (PARTITION BY index_name ORDER BY seq_in_index) AS seq_in_index | ||
| FROM %s | ||
| FROM %s x |
Member
Author
There was a problem hiding this comment.
Oh, this x is a leftover from a quick fix when I was probably nagged by SQLite to use an alias. I'll rename it to something more reasonable, in case it is required.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SQLite Version Compatibility Fixes
This PR adds support for older SQLite versions by addressing various compatibility issues. It also updates the CI workflow to test against multiple SQLite versions.
Compatibility fixes:
UPSERT / ON CONFLICT clause (SQLite < 3.35.0) — The generic
ON CONFLICT DO UPDATEclause without an explicit column list is only supported from SQLite 3.35.0. For older versions, we now catch the constraint violation error, parse the conflicting column names from the error message, and re-execute with an explicit column list.STRICT tables (SQLite < 3.37.0) — The
STRICTkeyword for table creation is only supported from SQLite 3.37.0. It is now conditionally omitted on older versions.VALUES list
columnNnaming (SQLite < 3.33.0) — Automatic column naming for VALUES lists (column1,column2, etc.) is only supported from SQLite 3.33.0. For older versions, we now emulate this by prepending a dummySELECT NULL AS column1, ... WHERE FALSE UNION ALL ...header.UPDATE ... FROMsyntax (SQLite < 3.33.0) — TheUPDATE ... FROMsyntax is only supported from SQLite 3.33.0. We now avoid using it internally in the information schema builder.IIF()function (all versions) — TheIIF()function was added in SQLite 3.32.0. We now useCASE WHEN ... THEN ... ELSE ... ENDinstead for broader compatibility.SUBSTRING()function (all versions) — TheSUBSTRING()function is not supported in older SQLite versions. We now translate it toSUBSTR().sqlite_schematable (SQLite < 3.33.0) — Thesqlite_schematable alias was added in SQLite 3.33.0. We now use the oldersqlite_mastername for compatibility.SQLite version detection — Changed from using a
SELECT SQLITE_VERSION()query to using thePDO::ATTR_SERVER_VERSIONattribute for retrieving the SQLite version, which avoids extra queries by using SQLite C API directly.CI workflow — Added support for testing against multiple SQLite versions.