fix bitarray/IsEmpty()

brentp · brentp · commit 75c27ff6fcb9 · 2016-01-01T17:59:43.000-07:00
diff --git a/bitarray/bitarray.go b/bitarray/bitarray.go
@@ -233,7 +233,7 @@ func (ba *bitArray) Blocks() Iterator {
 }
 
 func (ba *bitArray) IsEmpty() bool {
-	return ba.anyset
+	return !ba.anyset
 }
 
 // complement flips all bits in this array.
diff --git a/bitarray/bitarray_test.go b/bitarray/bitarray_test.go
@@ -134,6 +134,14 @@ func TestOutOfBounds(t *testing.T) {
 	}
 }
 
+func TestIsEmpty(t *testing.T) {
+	ba := newBitArray(10)
+	assert.True(t, ba.IsEmpty())
+
+	ba.SetBit(5)
+	assert.False(t, ba.IsEmpty())
+}
+
 func TestClear(t *testing.T) {
 	ba := newBitArray(10)
 

Original file line number	Diff line number	Diff line change
`@@ -233,7 +233,7 @@ func (ba *bitArray) Blocks() Iterator {`
`233`	`233`	`}`
`234`	`234`
`235`	`235`	`func (ba *bitArray) IsEmpty() bool {`
`236`		`- return ba.anyset`
	`236`	`+ return !ba.anyset`
`237`	`237`	`}`
`238`	`238`
`239`	`239`	`// complement flips all bits in this array.`
Original file line number	Diff line number	Diff line change
`@@ -134,6 +134,14 @@ func TestOutOfBounds(t *testing.T) {`
`134`	`134`	`}`
`135`	`135`	`}`
`136`	`136`
	`137`	`+func TestIsEmpty(t *testing.T) {`
	`138`	`+ ba := newBitArray(10)`
	`139`	`+ assert.True(t, ba.IsEmpty())`
	`140`	`+`
	`141`	`+ ba.SetBit(5)`
	`142`	`+ assert.False(t, ba.IsEmpty())`
	`143`	`+}`
	`144`	`+`
`137`	`145`	`func TestClear(t *testing.T) {`
`138`	`146`	`ba := newBitArray(10)`
`139`	`147`