Skip to content

Commit b8c436a

Browse files
Merge pull request #135 from alexandercampbell-wf/update_readme_set
README: update to point to alternative Set impls
2 parents 3c6cf04 + aff438c commit b8c436a

File tree

2 files changed

+9
-3
lines changed

2 files changed

+9
-3
lines changed

README.md

+5-3
Original file line numberDiff line numberDiff line change
@@ -59,9 +59,11 @@ Inserts are typical BBST times at O(log n^d) where d is the number of
5959
dimensions.
6060

6161
#### Set
62-
Self explanatory. Could be further optimized by getting the uintptr of the
63-
generic interface{} used and using that as the key as Golang maps handle that
64-
much better than the generic struct type.
62+
Our Set implementation is very simple, accepts items of type `interface{}` and
63+
includes only a few methods. If your application requires a richer Set
64+
implementation over lists of type `sort.Interface`, see
65+
[xtgo/set](https://github.com/xtgo/set) and
66+
[goware/set](https://github.com/goware/set).
6567

6668
#### Threadsafe
6769
A package that is meant to contain some commonly used items but in a threadsafe

set/dict.go

+4
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,10 @@ Package set is a simple unordered set implemented with a map. This set
1919
is threadsafe which decreases performance.
2020
2121
TODO: Actually write custom hashmap using the hash/fnv hasher.
22+
23+
TODO: Our Set implementation Could be further optimized by getting the uintptr
24+
of the generic interface{} used and using that as the key; Golang maps handle
25+
uintptr much better than the generic interace{} key.
2226
*/
2327

2428
package set

0 commit comments

Comments
 (0)