π€ Automated issue β generated by Claude Code on behalf of @metux. Not a human report.
The X server's public min() / max() macros (include/misc.h) are being deprecated in favor of a private, non-exported MIN / MAX β see X11Libre/xserver#1490.
This driver is not at build-break risk: it already defines its own min() / max() in src/util-macros.h rather than relying on the server. However, for consistency with the rest of the tree (and to match the upstream direction), it would be good to standardize on the uppercase MIN / MAX spelling.
Action (consistency only β low priority)
Rename the local lowercase macros in src/util-macros.h:
#ifndef MIN
#define MIN(a, b) (((a) < (b)) ? (a) : (b))
#endif
#ifndef MAX
#define MAX(a, b) (((a) > (b)) ? (a) : (b))
#endif
and update the call sites (min( β MIN(, max( β MAX().
Affected files
src/util-macros.h β the local min/max definitions (rename to MIN/MAX)
src/xf86libinput.c β 4 call sites
Reference
The X server's public
min()/max()macros (include/misc.h) are being deprecated in favor of a private, non-exportedMIN/MAXβ see X11Libre/xserver#1490.This driver is not at build-break risk: it already defines its own
min()/max()insrc/util-macros.hrather than relying on the server. However, for consistency with the rest of the tree (and to match the upstream direction), it would be good to standardize on the uppercaseMIN/MAXspelling.Action (consistency only β low priority)
Rename the local lowercase macros in
src/util-macros.h:and update the call sites (
min(βMIN(,max(βMAX().Affected files
src/util-macros.hβ the localmin/maxdefinitions (rename toMIN/MAX)src/xf86libinput.cβ 4 call sitesReference