Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mypy Support #174

Closed
weddige opened this issue Aug 20, 2021 · 2 comments
Closed

Mypy Support #174

weddige opened this issue Aug 20, 2021 · 2 comments

Comments

@weddige
Copy link

weddige commented Aug 20, 2021

Is there any chance, that we will see mypy support?

I saw you startet at https://github.com/XML-Security/signxml/tree/mypy and it seems, that there isn't too much to do:

(.env38) signxml [develop ≡]> mypy .\signxml\ --non-interactive --install-types --ignore-missing-imports
signxml\__init__.py:142: error: Cannot instantiate abstract class "EllipticCurve" with abstract attributes "key_size" and "name"
Found 1 error in 1 file (checked 3 source files)
(.env38) signxml [develop ≡]>

Type hints would be awesome, but including mypy in the linting would be a first step in this direction.

@kislyuk
Copy link
Member

kislyuk commented Oct 8, 2021

PRs are welcome for type hinting support and mypy lint support. I don't currently have the bandwidth to implement those myself.

@kislyuk
Copy link
Member

kislyuk commented Aug 21, 2022

Added in #195

@kislyuk kislyuk closed this as completed Aug 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants