fix review comments

Signed-off-by: saumya garg <[email protected]>

fix review comments

Signed-off-by: saumya garg <[email protected]>

Author: saumya garg

src/runtime_src/core/common/api/aie/xrt_graph.cpp

@@ -130,7 +130,9 @@ class profiling_impl
   {}
 
   ~profiling_impl()
-  {}
+  {
+    device->stop_profiling(profiling_hdl);
+  }
 
   handle 
   start_profiling(int option, const std::string& port1_name, const std::string& port2_name, uint32_t value)

src/runtime_src/core/include/xrt/xrt_aie.h

@@ -24,6 +24,7 @@
 #include "xrt/xrt_bo.h"
 #include "xrt/xrt_device.h"
 #include "xrt/xrt_graph.h"
+#include "xrt/detail/pimpl.h"
 
 #ifdef __cplusplus
 # include <cstdint>
@@ -164,17 +165,21 @@ class bo : public xrt::bo
 };
 
 class profiling_impl;
-class profiling 
+class profiling : public detail::pimpl<profiling_impl>
 {
 public:
   enum class profiling_option : int { io_total_stream_running_to_idle_cycles = 0, io_stream_start_to_bytes_transferred_cycles = 1, io_stream_start_difference_cycles = 2, io_stream_running_event_count = 3 };
+
+  profiling() = default;
+
   /**
    * event() - Constructor from a device
    *
    * @param device
    *  The device on which the profiling should start
    *
    */
+  explicit
   profiling(const xrt::device& device);
 
   /**
@@ -212,7 +217,7 @@ class profiling
   stop() const;
 
 private:
-    std::shared_ptr<profiling_impl> impl;
+  std::shared_ptr<profiling_impl> impl;
 };
 
 }} // aie, xrt
@@ -313,8 +318,8 @@ xrtResetAIEArray(xrtDeviceHandle handle);
  *
  * @handle:          Handle to the device
  * @option:          Profiling option.
- * @port1Name:       Profiling port 1 name
- * @port2Name:       Profiling port 2 name
+ * @port1Name:       PLIO/GMIO port 1 name
+ * @port2Name:       PLIO/GMIO port 2 name
  * @value:           The number of bytes to trigger the profiling event
  *
  * Return:         An integer profiling handle on success,

src/runtime_src/doc/toc/xrt_native_apis.rst

@@ -854,7 +854,7 @@ The ``xrt::aie::profiling::stop`` function stops the performance profiling assoc
       :number-lines: 35
            
         event.stop();
-        double throughput = (double)output_size_in_bytes / (cycle_count *0.8 * 1e-3); 
+        double throughput = output_size_in_bytes / (cycle_count *0.8 * 1e-3); 
         // Every AIE cycle is 0.8ns in production board
         std::cout << "Throughput of the graph: " << throughput << " MB/s" << std::endl;