diff --git a/.gitignore b/.gitignore index 46602db953..a04227128c 100644 --- a/.gitignore +++ b/.gitignore @@ -36,4 +36,7 @@ tests/Microsoft.AspNet.SignalR.Client.Store.Tests/AppPackages/ /Microsoft.AspNet.SignalR.sln.ide /.vs/ project.lock.json -src/Microsoft.AspNet.SignalR.Client.NetStandard/Microsoft.AspNet.SignalR.Client.NetStandard.nuget.targets \ No newline at end of file +src/Microsoft.AspNet.SignalR.Client.NetStandard/Microsoft.AspNet.SignalR.Client.NetStandard.nuget.targets +tests/Microsoft.AspNet.SignalR.Client.UWP.Tests/AppPackages/ +tests/Microsoft.AspNet.SignalR.Client.UWP.Tests/Microsoft.AspNet.SignalR.Client.UWP.Tests.nuget.props +tests/Microsoft.AspNet.SignalR.Client.UWP.Tests/Microsoft.AspNet.SignalR.Client.UWP.Tests.nuget.targets diff --git a/.nuget/packages.config b/.nuget/packages.config index 57a18a1cf4..1b5a12fa4e 100644 --- a/.nuget/packages.config +++ b/.nuget/packages.config @@ -4,8 +4,5 @@ - - - - + \ No newline at end of file diff --git a/build.cmd b/build.cmd index 9892c671f8..adc5db6b51 100644 --- a/build.cmd +++ b/build.cmd @@ -3,6 +3,7 @@ rem Enforce package restore to avoid build issues. See http://go.microsoft.com/fwlink/?LinkID=317568 for more details msbuild .nuget\NuGet.targets /t:RestorePackages .nuget\nuget.exe restore %~dp0\src\Microsoft.AspNet.SignalR.Client.UWP\project.json +.nuget\nuget.exe restore %~dp0\tests\Microsoft.AspNet.SignalR.Client.UWP.Tests\project.json .nuget\nuget.exe restore %~dp0\src\Microsoft.AspNet.SignalR.Client.NetStandard\project.json set target=%1 diff --git a/build/Build.proj b/build/Build.proj index 50dd15ef5c..c948a3bce1 100644 --- a/build/Build.proj +++ b/build/Build.proj @@ -23,7 +23,7 @@ $(ProjectRoot)\.nuget $(NuGetToolsPath)\nuget.exe $(ProjectRoot)\tools\ - $(ProjectRoot)\packages\xunit.runners.2.0.0-beta4-build2738\tools\ + $(ProjectRoot)\packages\xunit.runner.msbuild.2.2.0\build\net452\ chutzpah.console.exe $(ProjectRoot)\tools\chutzpah $(ChutzpahPath)\$(ChutzpahExe) @@ -165,8 +165,9 @@ - - + + + @@ -236,31 +237,28 @@ - + Xml="$(TestResultsPath)\Microsoft.AspNet.SignalR.Tests.XunitResults.xml" /> + Xml="$(TestResultsPath)\Microsoft.AspNet.SignalR.Client.Tests.XunitResults.xml" /> + Xml="$(TestResultsPath)\Microsoft.AspNet.SignalR.SqlServer.Tests.XunitResults.xml" /> + + - - + - + + - + - + @@ -290,7 +288,7 @@ - + + Xml="$(TestResultsPath)\Microsoft.AspNet.SignalR.FunctionalTests.XunitResults.xml" /> diff --git a/src/Microsoft.AspNet.SignalR.Core/Messaging/MessageBus.cs b/src/Microsoft.AspNet.SignalR.Core/Messaging/MessageBus.cs index 808a66f046..d082c81f45 100644 --- a/src/Microsoft.AspNet.SignalR.Core/Messaging/MessageBus.cs +++ b/src/Microsoft.AspNet.SignalR.Core/Messaging/MessageBus.cs @@ -152,7 +152,7 @@ public virtual Task Publish(Message message) if (Topics.TryGetValue(message.Key, out topic)) { topic.Store.Add(message); - ScheduleTopic(message.Key, topic); + ScheduleTopic(topic); } Counters.MessageBusMessagesPublishedTotal.Increment(); @@ -258,11 +258,11 @@ protected void ScheduleEvent(string eventKey) Topic topic; if (Topics.TryGetValue(eventKey, out topic)) { - ScheduleTopic(eventKey, topic); + ScheduleTopic(topic); } } - private void ScheduleTopic(string eventKey, Topic topic) + private void ScheduleTopic(Topic topic) { try { diff --git a/src/Microsoft.AspNet.SignalR.Redis/RedisScaleoutConfiguration.cs b/src/Microsoft.AspNet.SignalR.Redis/RedisScaleoutConfiguration.cs index 07e037a1a3..ff4c6e1700 100644 --- a/src/Microsoft.AspNet.SignalR.Redis/RedisScaleoutConfiguration.cs +++ b/src/Microsoft.AspNet.SignalR.Redis/RedisScaleoutConfiguration.cs @@ -31,7 +31,7 @@ public RedisScaleoutConfiguration(string connectionString, string eventKey) } ConnectionString = connectionString; - if (connectionString != string.Empty) + if (connectionString.Length > 0) { var options = ConfigurationOptions.Parse(connectionString); Database = options.DefaultDatabase.GetValueOrDefault(0); diff --git a/tests/Microsoft.AspNet.SignalR.Client.Store.TestHost/Microsoft.AspNet.SignalR.Client.UWP.TestHost.csproj b/tests/Microsoft.AspNet.SignalR.Client.Store.TestHost/Microsoft.AspNet.SignalR.Client.UWP.TestHost.csproj index a888d1a794..b37d86fe15 100644 --- a/tests/Microsoft.AspNet.SignalR.Client.Store.TestHost/Microsoft.AspNet.SignalR.Client.UWP.TestHost.csproj +++ b/tests/Microsoft.AspNet.SignalR.Client.Store.TestHost/Microsoft.AspNet.SignalR.Client.UWP.TestHost.csproj @@ -8,7 +8,7 @@ Exe Properties Microsoft.AspNet.SignalR.Client.Store.TestHost - Microsoft.AspNet.SignalR.Client.Store.TestHost + Microsoft.AspNet.SignalR.Client.UWP.TestHost v4.5.2 512 ..\..\ diff --git a/tests/Microsoft.AspNet.SignalR.Client.Store.TestHost/Program.cs b/tests/Microsoft.AspNet.SignalR.Client.Store.TestHost/Program.cs index d01d477101..a189ab8957 100644 --- a/tests/Microsoft.AspNet.SignalR.Client.Store.TestHost/Program.cs +++ b/tests/Microsoft.AspNet.SignalR.Client.Store.TestHost/Program.cs @@ -6,7 +6,7 @@ using Microsoft.Owin.Hosting; using Owin; -namespace Microsoft.AspNet.SignalR.Client.Store.TestHost +namespace Microsoft.AspNet.SignalR.Client.UWP.TestHost { // Used for running End-to-End tests for Store WebSockets transport. public class Program @@ -16,7 +16,7 @@ static void Main(string[] args) const string url = "http://localhost:42424"; using (WebApp.Start(url)) { - Console.WriteLine("SignalR host for E2E Store Client tests running on {0}", url); + Console.WriteLine("SignalR host for E2E UWP Client tests running on {0}", url); Thread.Sleep(args.Length > 0 ? int.Parse(args[0]) : Timeout.Infinite); } } diff --git a/tests/Microsoft.AspNet.SignalR.Client.Store.TestHost/StoreWebSocketTestHub.cs b/tests/Microsoft.AspNet.SignalR.Client.Store.TestHost/StoreWebSocketTestHub.cs index ddfd03ca9e..6e3869b753 100644 --- a/tests/Microsoft.AspNet.SignalR.Client.Store.TestHost/StoreWebSocketTestHub.cs +++ b/tests/Microsoft.AspNet.SignalR.Client.Store.TestHost/StoreWebSocketTestHub.cs @@ -4,7 +4,7 @@ using System.Collections.Generic; using System; -namespace Microsoft.AspNet.SignalR.Client.Store.TestHost +namespace Microsoft.AspNet.SignalR.Client.UWP.TestHost { public class StoreWebSocketTestHub : Hub { diff --git a/tests/Microsoft.AspNet.SignalR.Client.UWP.Tests/Microsoft.AspNet.SignalR.Client.UWP.Tests.csproj b/tests/Microsoft.AspNet.SignalR.Client.UWP.Tests/Microsoft.AspNet.SignalR.Client.UWP.Tests.csproj index 111532069c..58c4f8409a 100644 --- a/tests/Microsoft.AspNet.SignalR.Client.UWP.Tests/Microsoft.AspNet.SignalR.Client.UWP.Tests.csproj +++ b/tests/Microsoft.AspNet.SignalR.Client.UWP.Tests/Microsoft.AspNet.SignalR.Client.UWP.Tests.csproj @@ -147,6 +147,7 @@ 14.0 +