Skip to content

Replace hardcoded #ff9a8b in Skills.jsx progress bar with CSS custom property#21

Merged
Yasar2019 merged 2 commits into
mainfrom
copilot/replace-hardcoded-progress-bar-color
Mar 18, 2026
Merged

Replace hardcoded #ff9a8b in Skills.jsx progress bar with CSS custom property#21
Yasar2019 merged 2 commits into
mainfrom
copilot/replace-hardcoded-progress-bar-color

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Mar 15, 2026

The ProgressBar gradient in Skills.jsx had a hardcoded #ff9a8b coral stop, bypassing the CSS-variable theming system entirely and producing inconsistent results in dark mode.

Changes

  • src/styles/GlobalStyles.js — Introduces --accent-secondary in both theme scopes:

    • :root: #ff9a8b (preserves existing light-theme appearance)
    • [data-theme='dark']: #ffb3a7 (lighter coral for legibility on dark backgrounds)
  • src/Components/Skills.jsx — Swaps the hardcoded hex for the new variable:

// Before
background: linear-gradient(90deg, var(--accent), #ff9a8b);

// After
background: linear-gradient(90deg, var(--accent), var(--accent-secondary));
Original prompt

This section details on the original issue you should resolve

<issue_title>Replace hardcoded #ff9a8b color in Skills.jsx progress bar with a CSS custom property</issue_title>
<issue_description>Source: Copilot review comment on PR #8src/Components/Skills.jsx line 77

Problem

The progress bar gradient still includes a hardcoded hex color (#ff9a8b), which undermines the CSS-variable theming approach and may look off in dark mode.

Suggested Fix

Move the hardcoded color to a CSS custom property (e.g. a secondary accent) so it can be tuned per theme:

:root {
  --accent-secondary: #ff9a8b;
}
[data-theme="dark"] {
  --accent-secondary: /* dark theme value */;
}

Then use var(--accent-secondary) in the gradient definition.

Review thread: #8 (comment)</issue_description>

Comments on the Issue (you are @copilot in this section)


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI changed the title [WIP] Replace hardcoded color in Skills.jsx progress bar with CSS custom property Replace hardcoded #ff9a8b in Skills.jsx progress bar with CSS custom property Mar 15, 2026
Copilot AI requested a review from Yasar2019 March 15, 2026 16:57
Copy link
Copy Markdown
Owner

@Yasar2019 Yasar2019 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good

@github-actions
Copy link
Copy Markdown

Azure Static Web Apps: Your stage site is ready! Visit it here: https://witty-mud-031b23a0f-21.eastus2.2.azurestaticapps.net

@Yasar2019 Yasar2019 marked this pull request as ready for review March 18, 2026 00:44
@Yasar2019 Yasar2019 merged commit b55bc1e into main Mar 18, 2026
2 checks passed
@Yasar2019 Yasar2019 deleted the copilot/replace-hardcoded-progress-bar-color branch March 18, 2026 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replace hardcoded #ff9a8b color in Skills.jsx progress bar with a CSS custom property

2 participants