Guard GithubRepos against non-array/error GitHub API responses before slicing#25
Merged
Merged
Conversation
Agent-Logs-Url: https://github.com/Yasar2019/myPortfolio/sessions/2b4c41be-e18d-4865-98f8-0676d7aa2dfc Co-authored-by: Yasar2019 <[email protected]>
Agent-Logs-Url: https://github.com/Yasar2019/myPortfolio/sessions/2b4c41be-e18d-4865-98f8-0676d7aa2dfc Co-authored-by: Yasar2019 <[email protected]>
Copilot
AI
changed the title
[WIP] Guard GithubRepos.jsx against non-array API responses
Guard Apr 4, 2026
GithubRepos against non-array/error GitHub API responses before slicing
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://witty-mud-031b23a0f-25.eastus2.2.azurestaticapps.net |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GithubRepos.jsxassumed the GitHub repos API always returned an array and called.slice()unconditionally. On rate-limit/error responses (object payloads), this could throw at runtime.Response handling hardening
response.okgate before JSON parsing.Data-shape validation
Array.isArray(data)validation before calling.slice(0, 5).Behavioral impact
.sliceon non-array payloads.