Skip to content

Commit 0a337dc

Browse files
committed
Adds a kustomize base for the typescript runtime, and renames from test
to specs because that's the recommended folder name in source. Also when using skaffold dev (or run --tail) logs are prefixed with container name and [specs] is more clear and less likely to be used by other deployments.
1 parent 15dc7b5 commit 0a337dc

File tree

2 files changed

+7
-2
lines changed

2 files changed

+7
-2
lines changed

runtime-nodejs/kustomize/scrapeable-deployment.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
apiVersion: apps/v1
22
kind: Deployment
33
metadata:
4-
name: test
4+
name: specs
55
spec:
66
replicas: 1
77
selector:
@@ -14,7 +14,7 @@ spec:
1414
spec:
1515
serviceAccountName: assert
1616
containers:
17-
- name: runtime
17+
- name: specs
1818
# We can't have a tag here because https://kubectl.docs.kubernetes.io/pages/reference/kustomize.html#images won't unset it, and Skaffold required no-tag URLs for build
1919
image: yolean/assert-runtime-nodejs
2020
env:
Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
bases:
2+
- ../../runtime-nodejs/kustomize
3+
images:
4+
- name: yolean/assert-runtime-nodejs
5+
newName: yolean/assert-runtime-typescript

0 commit comments

Comments
 (0)