ANDROID: fix uninitilized variable

Currently we set CONFIG_CC_OPTIMIZE_FOR_SIZE which suppressed the compiler
warning of unused variables which can lead undefined behavior e.g. memory
corruption and panic. See https://lkml.org/lkml/2013/3/25/347.

This patch fixes all the uninitilized variables in kernel

Bug: 33353384
Test: On device
Signed-off-by: Wei Wang <[email protected]>
Change-Id: I0ae1082f447b435d71156d471878ba71aa16c378

Author: weivincewang

drivers/clk/qcom/clock-cpu-8994.c

@@ -987,6 +987,8 @@ void sanity_check_clock_tree(u32 muxval, struct mux_clk *mux)
 		case AUX_CLK_SEL:
 			rate = sys_apcsaux_clk.c.rate;
 		break;
+		default:
+			return;
 		};
 	break;
 	case PLL0_EARLY_SEL:
@@ -997,6 +999,8 @@ void sanity_check_clock_tree(u32 muxval, struct mux_clk *mux)
 		rate = readl_relaxed(base + C0_PLLA_L_VAL);
 		rate *= xo_ao.c.rate;
 	break;
+	default:
+		return;
 	};
 
 	/* One regulator */
@@ -1556,7 +1560,7 @@ static void populate_opp_table(struct platform_device *pdev)
 	struct platform_device *apc0_dev, *apc1_dev;
 	struct device_node *apc0_node, *apc1_node;
 	unsigned long apc0_fmax, apc1_fmax;
-	int cpu, a53_cpu, a57_cpu;
+	int cpu, a53_cpu = 0, a57_cpu = 0;
 
 	apc0_node = of_parse_phandle(pdev->dev.of_node, "vdd-a53-supply", 0);
 	apc1_node = of_parse_phandle(pdev->dev.of_node, "vdd-a57-supply", 0);
@@ -1957,7 +1961,6 @@ static int cpu_clock_8994_driver_probe(struct platform_device *pdev)
 	u64 pte_efuse;
 	char a57speedbinstr[] = "qcom,a57-speedbinXX-vXX";
 	char a53speedbinstr[] = "qcom,a53-speedbinXX-vXX";
-
 	v2 = msm8994_v2 | msm8992;
 
 	a53_pll0_main.c.flags = CLKFLAG_NO_RATE_CACHE;
@@ -1984,7 +1987,7 @@ static int cpu_clock_8994_driver_probe(struct platform_device *pdev)
 
 		snprintf(a53speedbinstr, ARRAY_SIZE(a53speedbinstr),
 			"qcom,a53-speedbin%d-v%d", a53speedbin, pvs_ver);
-	} else if (v2)
+	} else
 		pte_efuse = readl_relaxed(vbases[EFUSE_BASE]);
 
 	snprintf(a53speedbinstr, ARRAY_SIZE(a53speedbinstr),

drivers/cpufreq/cpufreq_stats.c

@@ -838,7 +838,7 @@ void cpufreq_task_stats_remove_uids(uid_t uid_start, uid_t uid_end)
 static int cpufreq_stat_notifier_policy(struct notifier_block *nb,
 		unsigned long val, void *data)
 {
-	int ret, count = 0, i;
+	int ret = 0, count = 0, i;
 	struct cpufreq_policy *policy = data;
 	struct cpufreq_frequency_table *table;
 	unsigned int cpu = policy->cpu;

drivers/input/touchscreen/synaptics_fw_update.c

@@ -2379,7 +2379,7 @@ static int synaptics_rmi4_fwu_init(struct synaptics_rmi4_data *rmi4_data)
 	fwu->ts_info = kzalloc(RMI4_INFO_MAX_LEN, GFP_KERNEL);
 	if (!fwu->ts_info) {
 		dev_err(&rmi4_data->i2c_client->dev, "Not enough memory\n");
-		goto exit_free_ts_info;
+		goto exit_free_mem;
 	}
 
 	synaptics_rmi4_update_debug_info();
@@ -2393,7 +2393,6 @@ static int synaptics_rmi4_fwu_init(struct synaptics_rmi4_data *rmi4_data)
 #endif
 
 	return 0;
-exit_free_ts_info:
 	debugfs_remove(temp);
 exit_remove_attrs:
 	for (attr_count--; attr_count >= 0; attr_count--) {

drivers/power/qcom/debug_core.c

@@ -290,7 +290,7 @@ int msm_core_debug_init(void)
 
 	msm_core_data = get_cpu_pwr_stats();
 	if (!msm_core_data)
-		goto fail;
+		return PTR_ERR(NULL);
 
 	dir = debugfs_create_dir("msm_core", NULL);
 	if (IS_ERR_OR_NULL(dir))

drivers/power/qcom/msm-core.c

@@ -354,10 +354,10 @@ static int update_userspace_power(struct sched_params __user *argp)
 {
 	int i;
 	int ret;
-	int cpu;
 	struct cpu_activity_info *node;
 	struct cpu_static_info *sp, *clear_sp;
 	int cpumask, cluster, mpidr;
+	int cpu = num_possible_cpus();
 
 	get_user(cpumask, &argp->cpumask);
 	get_user(cluster, &argp->cluster);

drivers/power/qpnp-fg.c

@@ -5041,6 +5041,7 @@ static int fg_batt_profile_init(struct fg_chip *chip)
 	const char *data, *batt_type_str, *old_batt_type;
 	bool tried_again = false, vbat_in_range, profiles_same;
 	u8 reg = 0;
+	old_batt_type = default_batt_type;
 
 wait:
 	fg_stay_awake(&chip->profile_wakeup_source);
@@ -5068,7 +5069,6 @@ static int fg_batt_profile_init(struct fg_chip *chip)
 							fg_batt_type);
 	if (!profile_node) {
 		pr_err("couldn't find profile handle\n");
-		old_batt_type = default_batt_type;
 		rc = -ENODATA;
 		goto fail;
 	}

drivers/power/qpnp-smbcharger.c

@@ -7883,6 +7883,8 @@ static int smbchg_probe(struct spmi_device *spmi)
 						rc);
 			return rc;
 		}
+	} else {
+		vadc_dev = NULL;
 	}
 
 	if (of_find_property(spmi->dev.of_node, "qcom,vchg_sns-vadc", NULL)) {

drivers/soc/qcom/npa-dump.c

@@ -155,7 +155,7 @@ static int npa_dump_probe(struct platform_device *pdev)
 	struct resource *res;
 	void __iomem *npa_base, *rpm_base;
 	struct dentry *dent;
-	int ret;
+	int ret = 0;
 
 	/* Get the location of the NPA log's start address offset */
 	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);

drivers/video/msm/mdss/mdss_mdp_intf_cmd.c

@@ -1646,4 +1646,3 @@ int mdss_mdp_cmd_start(struct mdss_mdp_ctl *ctl)
 
 	return 0;
 }
-

sound/soc/msm/qdsp6v2/msm-pcm-routing-v2.c

@@ -4097,10 +4097,10 @@ static int msm_routing_put_stereo_to_custom_stereo_control(
 	int flag = 0, i = 0, rc = 0, idx = 0;
 	int be_index = 0, port_id, topo_id;
 	unsigned int session_id = 0;
-	uint16_t op_FL_ip_FL_weight;
-	uint16_t op_FL_ip_FR_weight;
-	uint16_t op_FR_ip_FL_weight;
-	uint16_t op_FR_ip_FR_weight;
+	uint16_t op_FL_ip_FL_weight = 0;
+	uint16_t op_FL_ip_FR_weight = 0;
+	uint16_t op_FR_ip_FL_weight = 0;
+	uint16_t op_FR_ip_FR_weight = 0;
 	flag = ucontrol->value.integer.value[0];
 	pr_debug("%s E flag %d\n", __func__, flag);