ZBUG-3640 - fix for OWASP Sanitizer blocking message from displaying … #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shrutig0510
approved these changes
Jun 12, 2024
|
LGTM. |
sumitkumar1110
force-pushed
the
ZBUG-3640
branch
from
79b0645 to
05f272a
Compare
sumitkumar1110
requested review from
RakeshAMore,
chitranshu198,
dasiyogesh,
preshitaagrawal,
silentsakky and
zimsuchitgupta
shrutig0510
approved these changes
Jun 19, 2024
PrasadpLad
approved these changes
Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem - OWASP Sanitizer blocking message from displaying in webmail.
Analysis- While checking for the HTML Comment, it seems to have been checked the previous two characters are "-" but only char - 2 is checked twice. So if a CSS Child combinator with - selector is used, it was treated as error.
This is a known issue of OWASP/java-html-sanitizer. This PR has been merged but we haven't took the latest code, due to which we are still facing the issue.
PR link - OWASP/java-html-sanitizer#297
Fix- Referred the above PR and did similar changes to fix the issue.