Merge branch 'develop'

Author: Pathoschild

.github/workflows/build.yml

@@ -0,0 +1,27 @@
+name: Build releases
+on: push
+jobs:
+    build:
+        runs-on: ubuntu-latest
+        permissions:
+           id-token: write     # for attestation
+           attestations: write # for attestation
+
+        steps:
+            - name: Fetch code
+              uses: actions/checkout@v4
+              with:
+                  fetch-tags: false
+
+            - name: Add build environment
+              uses: Pathoschild/SMAPI-ModBuildWorkflow/add-build-environment@v1
+
+            - name: Build mods
+              run: dotnet build
+
+            - name: Upload release zips
+              uses: Pathoschild/SMAPI-ModBuildWorkflow/upload-release-artifacts@v1
+              with:
+                  create_attestations: ${{github.ref_type == 'tag'}}
+                  create_combined_zip: "all-mods"
+              if: ${{github.ref_type == 'tag'}}

BetterRNG/Framework/MersenneTwister.cs

@@ -19,7 +19,7 @@ public MersenneTwister(int seed)
     /// Creates a new pseudo-random number generator with a default seed.
     /// </summary>
     /// <remarks>
-    /// <c>new <see cref="System.Random"/>().<see cref="Random.Next()"/></c> 
+    /// <c>new <see cref="System.Random"/>().<see cref="Random.Next()"/></c>
     /// is used for the seed.
     /// </remarks>
     public MersenneTwister() : this(new Random().Next(int.MinValue, int.MaxValue)) /* a default initial seed is used   */
@@ -34,7 +34,7 @@ public MersenneTwister(int[] initKey)
     {
         if (initKey == null)
         {
-            throw new ArgumentNullException("initKey");
+            throw new ArgumentNullException(nameof(initKey));
         }
 
         uint[] initArray = new uint[initKey.Length];
@@ -82,13 +82,13 @@ public override int Next(int maxValue)
     }
 
     /// <summary>
-    /// Returns the next pseudo-random <see cref="Int32"/> 
-    /// at least <paramref name="minValue"/> 
+    /// Returns the next pseudo-random <see cref="Int32"/>
+    /// at least <paramref name="minValue"/>
     /// and up to <paramref name="maxValue"/>.
     /// </summary>
     /// <param name="minValue">The minimum value of the pseudo-random number to create.</param>
     /// <param name="maxValue">The maximum value of the pseudo-random number to create.</param>
-    /// <returns>A pseudo-random Int32 value which is at least <paramref name="minValue"/> and at 
+    /// <returns>A pseudo-random Int32 value which is at least <paramref name="minValue"/> and at
     /// most <paramref name="maxValue"/>.</returns>
     /// <exception cref="ArgumentOutOfRangeException">
     /// If <c><paramref name="minValue"/> &gt;= <paramref name="maxValue"/></c>.
@@ -137,17 +137,17 @@ public override void NextBytes(byte[] buffer)
     /// <returns>A pseudo-random double floating point value.</returns>
     /// <remarks>
     /// <para>
-    /// There are two common ways to create a double floating point using MT19937: 
-    /// using <see cref="GenerateUInt32"/> and dividing by 0xFFFFFFFF + 1, 
-    /// or else generating two double words and shifting the first by 26 bits and 
+    /// There are two common ways to create a double floating point using MT19937:
+    /// using <see cref="GenerateUInt32"/> and dividing by 0xFFFFFFFF + 1,
+    /// or else generating two double words and shifting the first by 26 bits and
     /// adding the second.
     /// </para>
     /// <para>
-    /// In a newer measurement of the randomness of MT19937 published in the 
+    /// In a newer measurement of the randomness of MT19937 published in the
     /// journal "Monte Carlo Methods and Applications, Vol. 12, No. 5-6, pp. 385 ñ 393 (2006)"
     /// entitled "A Repetition Test for Pseudo-Random Number Generators",
-    /// it was found that the 32-bit version of generating a double fails at the 95% 
-    /// confidence level when measuring for expected repetitions of a particular 
+    /// it was found that the 32-bit version of generating a double fails at the 95%
+    /// confidence level when measuring for expected repetitions of a particular
     /// number in a sequence of numbers generated by the algorithm.
     /// </para>
     /// <para>
@@ -250,24 +250,23 @@ private void init(uint seed)
         for (this._mti = 1; this._mti < MersenneTwister.N; this._mti++)
         {
             this._mt[this._mti] = (uint)(1812433253u * (this._mt[this._mti - 1] ^ (this._mt[this._mti - 1] >> 30)) + this._mti);
-            // See Knuth TAOCP Vol2. 3rd Ed. P.106 for multiplier. 
-            // In the previous versions, MSBs of the seed affect   
-            // only MSBs of the array _mt[].                        
-            // 2002/01/09 modified by Makoto Matsumoto             
+            // See Knuth TAOCP Vol2. 3rd Ed. P.106 for multiplier.
+            // In the previous versions, MSBs of the seed affect
+            // only MSBs of the array _mt[].
+            // 2002/01/09 modified by Makoto Matsumoto
             this._mt[this._mti] &= 0xffffffffu;
             // for >32 bit machines
         }
     }
 
     private void init(uint[] key)
     {
-        int i, j, k;
         this.init(19650218u);
 
         int keyLength = key.Length;
-        i = 1;
-        j = 0;
-        k = (MersenneTwister.N > keyLength ? MersenneTwister.N : keyLength);
+        int i = 1;
+        int j = 0;
+        int k = (MersenneTwister.N > keyLength ? MersenneTwister.N : keyLength);
 
         for (; k > 0; k--)
         {
@@ -326,7 +325,7 @@ private double compute53BitRandom(double translate, double scale)
         // add another pseudo-random 26 bits (+ b).
         return ((a * 67108864.0 + b) + translate) * scale;
 
-        // What about the following instead of the above? Is the multiply better? 
+        // What about the following instead of the above? Is the multiply better?
         // Why? (Is it the FMUL instruction? Does this count in .Net? Will the JITter notice?)
         //return BitConverter.Int64BitsToDouble((a << 26) + b));
     }

BetterRNG/Framework/ModConfig.cs

@@ -1,3 +1,5 @@
+using System.Diagnostics.CodeAnalysis;
+using System.Runtime.Serialization;
 using StardewModdingAPI;
 using StardewModdingAPI.Utilities;
 
@@ -6,6 +8,9 @@ namespace BetterRNG.Framework;
 /// <summary>The mod configuration.</summary>
 internal class ModConfig
 {
+    /*********
+    ** Accessors
+    *********/
     /// <summary>Whether to randomise your daily luck.</summary>
     public bool EnableDailyLuckOverride { get; set; }
 
@@ -29,4 +34,17 @@ internal class ModConfig
 
     /// <summary>The keys which reload the mod config.</summary>
     public KeybindList ReloadKey { get; set; } = new(SButton.F5);
+
+
+    /*********
+    ** Private methods
+    *********/
+    /// <summary>The method called after the config file is deserialized.</summary>
+    /// <param name="context">The deserialization context.</param>
+    [OnDeserialized]
+    [SuppressMessage("ReSharper", "NullCoalescingConditionIsAlwaysNotNullAccordingToAPIContract", Justification = "")]
+    private void OnDeserializedMethod(StreamingContext context)
+    {
+        this.ReloadKey ??= new KeybindList(SButton.None);
+    }
 }

BetterRNG/Framework/Weighted.cs

@@ -1,19 +1,21 @@
+using System;
 using System.Linq;
 
 namespace BetterRNG.Framework;
 
 internal static class Weighted
 {
-    public static T Choose<T>(T[] list) where T : IWeighted
+    public static T Choose<T>(T[] list)
+        where T : IWeighted
     {
         if (!list.Any())
-            return default;
+            throw new InvalidOperationException("Can't choose a value because no options were provided.");
 
-        int totalweight = list.Sum(c => c.Weight);
-        int choice = ModEntry.Twister.Next(totalweight);
+        int totalWeight = list.Sum(c => c.Weight);
+        int choice = ModEntry.Twister.Next(totalWeight);
         int sum = 0;
 
-        foreach (var obj in list)
+        foreach (T obj in list)
         {
             for (float i = sum; i < obj.Weight + sum; i++)
             {

BetterRNG/ModEntry.cs

@@ -14,22 +14,21 @@ public class ModEntry : Mod
     ** Properties
     *********/
     /// <summary>The mod configuration.</summary>
-    private ModConfig Config;
+    private ModConfig Config = null!; // set in Entry
 
-    private WeightedGeneric<string>[] Weather;
+    private WeightedGeneric<string>[] Weather = null!; // set in Entry
 
 
     /*********
     ** Accessors
     *********/
-    internal static MersenneTwister Twister { get; private set; }
+    internal static MersenneTwister Twister { get; private set; } = null!; // set in Entry
 
 
     /*********
     ** Public methods
     *********/
-    /// <summary>The mod entry point, called after the mod is first loaded.</summary>
-    /// <param name="helper">Provides simplified APIs for writing mods.</param>
+    /// <inheritdoc />
     public override void Entry(IModHelper helper)
     {
         CommonHelper.RemoveObsoleteFiles(this, "BetterRNG.pdb");
@@ -57,18 +56,14 @@ public override void Entry(IModHelper helper)
     /*********
     ** Private methods
     *********/
-    /// <summary>Raised after the player starts a new day.</summary>
-    /// <param name="sender">The event sender.</param>
-    /// <param name="e">The event arguments.</param>
-    private void OnDayStarted(object sender, DayStartedEventArgs e)
+    /// <inheritdoc cref="IGameLoopEvents.DayStarted" />
+    private void OnDayStarted(object? sender, DayStartedEventArgs e)
     {
         this.DetermineRng();
     }
 
-    /// <inheritdoc cref="IInputEvents.ButtonsChanged"/>
-    /// <param name="sender">The event sender.</param>
-    /// <param name="e">The event arguments.</param>
-    private void OnButtonsChanged(object sender, ButtonsChangedEventArgs e)
+    /// <inheritdoc cref="IInputEvents.ButtonsChanged" />
+    private void OnButtonsChanged(object? sender, ButtonsChangedEventArgs e)
     {
         if (this.Config.ReloadKey.JustPressed())
         {

BetterRNG/release-notes.md

@@ -1,6 +1,14 @@
 [← back to readme](README.md)
 
 ## Release notes
+## 2.9.1
+Released 15 March 2026 for SMAPI 4.1.2 or later. Updated by Pathoschild.
+
+* Better RNG downloads are now created via [automated and attested builds](https://www.patreon.com/posts/automated-builds-148417912).  
+  _This guarantees that the download only contains what's in the public source code and hasn't been tampered with._
+* Fixed error if the `ReloadKey` config option is set to `null`.
+* Internal changes to simplify maintenance.
+
 ## 2.9.0
 Released 11 January 2026 for SMAPI 4.1.2 or later. Updated by Pathoschild.
 

CalendarAnywhere/ModEntry.cs

@@ -13,8 +13,7 @@ public class ModEntry : Mod
     /*********
     ** Public methods
     *********/
-    /// <summary>The mod entry point, called after the mod is first loaded.</summary>
-    /// <param name="helper">Provides simplified APIs for writing mods.</param>
+    /// <inheritdoc />
     public override void Entry(IModHelper helper)
     {
         CommonHelper.RemoveObsoleteFiles(this, "CalendarAnywhere.pdb");
@@ -26,10 +25,8 @@ public override void Entry(IModHelper helper)
     /*********
     ** Private methods
     *********/
-    /// <summary>Raised after the player presses a button on the keyboard, controller, or mouse.</summary>
-    /// <param name="sender">The event sender.</param>
-    /// <param name="e">The event arguments.</param>
-    private void OnButtonPressed(object sender, ButtonPressedEventArgs e)
+    /// <inheritdoc cref="IInputEvents.ButtonPressed" />
+    private void OnButtonPressed(object? sender, ButtonPressedEventArgs e)
     {
         if (Context.IsPlayerFree && e.Button.IsUseToolButton() && this.GetTarget().Contains((int)e.Cursor.ScreenPixels.X, (int)e.Cursor.ScreenPixels.Y))
             Game1.activeClickableMenu = new Billboard();

CalendarAnywhere/release-notes.md

@@ -1,6 +1,13 @@
 [← back to readme](README.md)
 
 ## Release notes
+## 2.9.1
+Released 15 March 2026 for SMAPI 4.1.2 or later. Updated by Pathoschild.
+
+* Calendar Anywhere downloads are now created via [automated and attested builds](https://www.patreon.com/posts/automated-builds-148417912).  
+  _This guarantees that the download only contains what's in the public source code and hasn't been tampered with._
+* Internal changes to simplify maintenance.
+
 ## 2.8.5
 Released 04 November 2024 for SMAPI 4.1.2 or later. Updated by Pathoschild.
 

Directory.Build.props

@@ -5,9 +5,10 @@
     <RepositoryUrl>https://github.com/Zoryn4163/SMAPI-Mods</RepositoryUrl>
     <RepositoryType>git</RepositoryType>
 
-    <Version>2.9.0</Version>
+    <Version>2.9.1</Version>
 
     <TargetFramework>net6.0</TargetFramework>
+    <Nullable>enable</Nullable>
     <AppendTargetFrameworkToOutputPath>false</AppendTargetFrameworkToOutputPath>
     <ModZipPath>$(SolutionDir)\_releases</ModZipPath>
   </PropertyGroup>

DurableFences/ModEntry.cs

@@ -11,8 +11,7 @@ public class ModEntry : Mod
     /*********
     ** Public methods
     *********/
-    /// <summary>The mod entry point, called after the mod is first loaded.</summary>
-    /// <param name="helper">Provides simplified APIs for writing mods.</param>
+    /// <inheritdoc />
     public override void Entry(IModHelper helper)
     {
         CommonHelper.RemoveObsoleteFiles(this, "DurableFences.pdb");
@@ -24,10 +23,8 @@ public override void Entry(IModHelper helper)
     /*********
     ** Private methods
     *********/
-    /// <summary>Raised once per second after the game state is updated.</summary>
-    /// <param name="sender">The event sender.</param>
-    /// <param name="e">The event arguments.</param>
-    private void OnOneSecondUpdateTicked(object sender, OneSecondUpdateTickedEventArgs e)
+    /// <inheritdoc cref="IGameLoopEvents.OneSecondUpdateTicked" />
+    private void OnOneSecondUpdateTicked(object? sender, OneSecondUpdateTickedEventArgs e)
     {
         Utility.ForEachLocation(location =>
         {