Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider Ruff for formatting/linting #2280

Open
keikoro opened this issue Dec 4, 2024 · 1 comment
Open

Consider Ruff for formatting/linting #2280

keikoro opened this issue Dec 4, 2024 · 1 comment
Labels
feature-request Request for a new feature or additional functionality. project-admin Anything to do with the administration & organisation of moviepy. I.e. project "meta". tooling Apps, integrations, workflows, tools... relevant to the maintenance of this project/repo.

Comments

@keikoro
Copy link
Collaborator

keikoro commented Dec 4, 2024

Our formatting/linting workflow currently uses 3 different tools, black, flake8 and isort, which could be replaced by Ruff.

I didn't want to introduce new tools when I reworked the workflow before the v2 release, but would like to suggest this now, also because's there's a pyproject.toml file now which can be used to store tool config.

@keikoro keikoro added feature-request Request for a new feature or additional functionality. project-admin Anything to do with the administration & organisation of moviepy. I.e. project "meta". tooling Apps, integrations, workflows, tools... relevant to the maintenance of this project/repo. labels Dec 4, 2024
@OsaAjani
Copy link
Collaborator

I would be ok with it, but I've never used Ruff, so I can't help on this one. If you want to go forward with it make sure to also update the doc. Using only one tool would indeed be nice, even nicer would be an auto running of the tool as some pre-commit hook ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Request for a new feature or additional functionality. project-admin Anything to do with the administration & organisation of moviepy. I.e. project "meta". tooling Apps, integrations, workflows, tools... relevant to the maintenance of this project/repo.
Projects
None yet
Development

No branches or pull requests

2 participants