Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AudioClip write_audiofile fps setting bug #2330

Open
Implosiv3 opened this issue Jan 17, 2025 · 0 comments
Open

AudioClip write_audiofile fps setting bug #2330

Implosiv3 opened this issue Jan 17, 2025 · 0 comments
Labels
bug Issues that report (apparent) bugs.

Comments

@Implosiv3
Copy link

I think I found a bug in the AudioClip class write_audiofile method. This is the code in the line 241:

if not fps:
    if hasattr(self, "fps"):
        fps = 44100
    else:
        fps = self.fps

And I think it should be this one:

if not fps:
    if hasattr(self, "fps"):
        fps = self.fps
    else:
        fps = 44100
@Implosiv3 Implosiv3 added the bug Issues that report (apparent) bugs. label Jan 17, 2025
Implosiv3 added a commit to Implosiv3/moviepy that referenced this issue Jan 20, 2025
Fixes a bug that is not setting the instance 'fps' value when it has the attribute, but doing it when it doesn't.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issues that report (apparent) bugs.
Projects
None yet
Development

No branches or pull requests

1 participant