Skip to content

Commit 1043d52

Browse files
O-Link06aaccioly
authored andcommitted
Bugfix - quality update beyond 50
1 parent 56207e2 commit 1043d52

File tree

1 file changed

+4
-8
lines changed

1 file changed

+4
-8
lines changed

Java/src/main/java/com/gildedrose/GildedRose.java

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -41,18 +41,14 @@ private void updateItem(Item item) {
4141
item.sellIn--;
4242

4343
if (isAgedBrie(item.name)) {
44-
if (item.quality < 50) {
45-
var qualityDelta = item.sellIn < 0 ? 2 : 1;
46-
item.quality += qualityDelta;
47-
}
44+
var qualityDelta = item.sellIn < 0 ? 2 : 1;
45+
item.quality = Math.min(50, item.quality + qualityDelta);
4846
} else if (isBackStagePass(item.name)) {
4947
if (item.sellIn < 0) {
5048
item.quality = 0;
5149
} else {
52-
if (item.quality < 50) {
53-
var qualityDelta = item.sellIn < 5 ? 3 : item.sellIn < 10 ? 2 : 1;
54-
item.quality += qualityDelta;
55-
}
50+
var qualityDelta = item.sellIn < 5 ? 3 : item.sellIn < 10 ? 2 : 1;
51+
item.quality = Math.min(50, item.quality + qualityDelta);
5652
}
5753
} else { // regular item
5854
var qualityDelta = item.sellIn < 0 ? 2 : 1;

0 commit comments

Comments
 (0)