Skip to content

Commit 49ced26

Browse files
committed
Disables supplementary input checks for Opera and native linux FF; disable stdout logging; try to fix I18nTest.testShouldBeAbleToReturnTheTextInAPage at IE10
1 parent 516616d commit 49ced26

File tree

2 files changed

+8
-3
lines changed

2 files changed

+8
-3
lines changed

Diff for: java/client/test/org/openqa/selenium/I18nTest.java

+7-1
Original file line numberDiff line numberDiff line change
@@ -91,14 +91,19 @@ public void testEnteringHebrewTextFromRightToLeft() {
9191

9292
@Test
9393
@Ignore(
94-
value = {MARIONETTE, CHROME},
94+
value = {MARIONETTE, CHROME, OPERA},
9595
reason = "MAIONETTE: not checked, "
9696
+ "CHROME: ChromeDriver only supports characters in the BMP"
97+
+ "OPERA: doesn't work - see issue 5069"
9798
)
9899
public void testEnteringSupplementaryCharacters() {
99100
assumeFalse("IE: versions less thank 10 have issue 5069",
100101
TestUtilities.isInternetExplorer(driver) &&
101102
TestUtilities.getIEVersion(driver) < 10);
103+
assumeFalse("FF: native events at linux broke it - see issue 5069",
104+
TestUtilities.isFirefox(driver) &&
105+
TestUtilities.isNativeEventsEnabled(driver) &&
106+
TestUtilities.getEffectivePlatform().is(Platform.LINUX));
102107
driver.get(pages.chinesePage);
103108

104109
String input = "";
@@ -114,6 +119,7 @@ public void testEnteringSupplementaryCharacters() {
114119
assertEquals(input, el.getAttribute("value"));
115120
}
116121

122+
@NeedsFreshDriver
117123
@Test
118124
@Ignore(MARIONETTE)
119125
public void testShouldBeAbleToReturnTheTextInAPage() {

Diff for: java/client/test/org/openqa/selenium/TakesScreenshotTest.java

+1-2
Original file line numberDiff line numberDiff line change
@@ -381,10 +381,8 @@ private BufferedImage getImage() {
381381
byte[] imageData = screenshoter.getScreenshotAs(OutputType.BYTES);
382382
assertTrue(imageData != null);
383383
assertTrue(imageData.length > 0);
384-
System.out.println("Length -> " + imageData.length);
385384
image = ImageIO.read(new ByteArrayInputStream(imageData));
386385
assertTrue(image != null);
387-
System.out.println("Sizes -> " + image.getWidth() + "x" + image.getHeight());
388386
} catch (IOException e) {
389387
fail("Image screenshot file is invalid: " + e.getMessage());
390388
}
@@ -517,6 +515,7 @@ private void saveImageToTmpFile(BufferedImage im) {
517515

518516
File outputfile = new File( testName.getMethodName() + "_image.png");
519517
System.out.println("Image file is at " + outputfile.getAbsolutePath());
518+
System.out.println("Sizes -> " + im.getWidth() + "x" + im.getHeight());
520519
try {
521520
ImageIO.write(im, "png", outputfile);
522521
} catch (IOException e) {

0 commit comments

Comments
 (0)