-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Semver support #89
Comments
Is that really ideal? My take on having an explicit version specified in the |
Not sure it's ideal - it could be constrainted maybe. The problem I have is that every time I open a terminal into a project location I run |
Having spent some time digging around the code (I don't use ps-nvm these days, as I pretty much only use WSL2) I'm unconvinced that this change would be easy to implement. It all boils down to https://github.com/aaronpowell/ps-nvm/blob/master/nvm.psm1#L84-L89 Basically, when you try and set a version it'll check if you've specified an exact version or a semver version, so It's simple enough to do a refactor on the I'm worried about doing cascading changes like this to the core functions, instead I think it's a better option to have the semver request made from the |
I would say that I guess I'll give a try. PS: I'm using ps-nvm with Powershell core on Mac so you could possibly use it within WSL ;) |
aapowell@AARONSB2 ~ [08:24]
❯ Get-NodeVersions
v14.3.0
v13.14.0
aapowell@AARONSB2 ~ [08:24]
❯ Get-NodeVersions "14"
v14.3.0
aapowell@AARONSB2 ~ [08:24]
❯ Get-NodeVersions ">12"
v14.3.0
v13.14.0
aapowell@AARONSB2 ~ [08:24]
❯ Get-NodeVersions "~13.15" Thinking about it a bit more, you could leave the bulk of And I do have PowerShell Core on WSL, and Windows, so I could test the changes for |
When running
Set-NodeVersion
, the version seem to be strictly compared, e.g. if.npmrc
has8.9.1
and I have8.17.0
installed, I would expect this newer but compatible version to be used.The text was updated successfully, but these errors were encountered: