Skip to content

Commit 32fe286

Browse files
committed
ci: the installed-Router check guessed the evidence schema
The step asserted `"laya" in data["adapters"]`, but `adapters` is a list of records keyed by `name` — the schema `load_evidence()` itself reads. All four install-and-run legs (ubuntu/macos x 3.9/3.11) went red on the first public CI run while every pytest leg stayed green, because the suite proves this through `load_evidence()` and never runs the workflow's own snippet. Ran the whole job locally against the wheel installed offline, from outside the clone: build, offline install + pip check, --version, doctor/demo/report, the corrected Router assertions, the sdist content check, and install.sh's shim. All pass; doctor reports 6 checks, none failing, and report reads 17 requests / 179,280 billed input tok.
1 parent da79363 commit 32fe286

1 file changed

Lines changed: 5 additions & 1 deletion

File tree

‎.github/workflows/ci.yml‎

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -136,7 +136,11 @@ jobs:
136136
assert path.startswith(pkg + os.sep), "%s is outside the package" % path
137137
data = json.load(open(path))
138138
assert {"heuristic", "adapters"} <= set(data), sorted(data)
139-
assert "laya" in data["adapters"], sorted(data["adapters"])
139+
# `adapters` is a list of records keyed by "name" — the schema load_evidence()
140+
# reads. This used to test `"laya" in data["adapters"]`, a shape guess that was
141+
# never true of the file and reddened all four install legs of the first public
142+
# run: the suite proves this through load_evidence(), so nothing local saw it.
143+
assert "laya" in [a.get("name") for a in data["adapters"]], data["adapters"]
140144
ev = router.load_evidence()
141145
assert {"heuristic", "laya"} <= set(ev), sorted(ev)
142146
print("installed Router ranks on %s" % os.path.relpath(path, pkg))

0 commit comments

Comments
 (0)