Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project README #27

Open
abe-101 opened this issue Jun 28, 2023 · 13 comments
Open

Project README #27

abe-101 opened this issue Jun 28, 2023 · 13 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest help wanted Extra attention is needed

Comments

@abe-101
Copy link
Owner

abe-101 commented Jun 28, 2023

The current README is the defualt from the cookiecutter-django project

Things to include:

  • About the project
  • Credtis to contributors
  • how to set up locally
@abe-101 abe-101 added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Jun 28, 2023
@seabeePraveen
Copy link
Contributor

hello @abe-101 please assign me this issue i will update the README.md very soon
Thank You!

@seabeePraveen
Copy link
Contributor

as mentioned in the above issue "credits to the contributers" do u mean to add their photo in the README.md itself or anything more ?

@abe-101
Copy link
Owner Author

abe-101 commented Oct 12, 2023

Adding their GitHub handle to readme is fine

@seabeePraveen
Copy link
Contributor

@abe-101 i have cloned the repo and i have installed all the packages into my venv but i couldn't found the env files what do u want me to do ? like in the setup docs how do u want me to go with it? if env files are missing?
also provide a brief about the project so i could make this way better even from your side

@seabeePraveen
Copy link
Contributor

these are the modifications that i have made:
image
and also docs for the setup:
image
so if there's any modifications to be done please let me know and also as the env files are missing so i didn't included that part in the setup and this will throw a error tell me what should i have to do

@abe-101
Copy link
Owner Author

abe-101 commented Oct 12, 2023

the .env should look like:

export DATABASE_URL=postgres://<USERNAME>:<PASSWORD>@127.0.0.1:5432/my_hebrew_dates
export CELERY_BROKER_URL=redis://localhost:6379/0

@abe-101
Copy link
Owner Author

abe-101 commented Oct 12, 2023

also for local development it should be:

pip install -r requirements/local.txt

as requirements/local.txt includes whats in requirements/base.txt

@abe-101
Copy link
Owner Author

abe-101 commented Oct 12, 2023

take a look at https://cookiecutter-django.readthedocs.io/en/latest/developing-locally.html

off the top of my mind the steps should be (I may be missing some):

  1. clone the repo
  2. cd into repo
  3. create python env
  4. install dependancys
  5. run pre-commit install
  6. create a new db table with createdb --username=<USERNAME> my_hebrew_dates
  7. create a .env file
  8. python manage.py migrate (No need to run makemigrations unless a change was made)

@seabeePraveen
Copy link
Contributor

hello @abe-101 once check these and let me know if any changes are required :
image

@abe-101
Copy link
Owner Author

abe-101 commented Oct 12, 2023

@seabeePraveen can you make a PR and I'll review the changes?

@seabeePraveen
Copy link
Contributor

yeah okay i will do it now please check it

@seabeePraveen
Copy link
Contributor

PR was send please review it and let me know

@seabeePraveen
Copy link
Contributor

let me know if any changes are required
Thank You!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants