Skip to content
This repository was archived by the owner on Feb 10, 2023. It is now read-only.

drop column is sometimes broken #21

Open
2 tasks
abe-winter opened this issue Nov 14, 2020 · 0 comments
Open
2 tasks

drop column is sometimes broken #21

abe-winter opened this issue Nov 14, 2020 · 0 comments
Labels
bug Something isn't working

Comments

@abe-winter
Copy link
Owner

abe-winter commented Nov 14, 2020

example failure:

psycopg2.errors.SyntaxError: syntax error at or near "bool"
LINE 6: alter table users drop column notify_email bool;

obvious why this is invalid sql and what the change generator is doing, but I think I've also seen drops emit correct sql.

  • make sure this is covered in a test case
  • see if the AST is being used correctly by the diff generator

also test rm enum (both for drop order and syntax error)

@abe-winter abe-winter added the bug Something isn't working label Nov 14, 2020
@abe-winter abe-winter changed the title drop column is broken drop column is sometimes broken Nov 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant