Skip to content

Commit d8a4a1e

Browse files
cupkkhaijie11abetlen
authored
fix(server): show falsey defaults in CLI help (#2355)
* fix(server): show falsey defaults in CLI help * test(server): remove CLI regression test --------- Co-authored-by: haijie11 <haijie11@noreply.gitcode.com> Co-authored-by: abetlen <abetlen@gmail.com>
1 parent 03307d8 commit d8a4a1e

2 files changed

Lines changed: 2 additions & 1 deletion

File tree

‎CHANGELOG.md‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
1010
- feat: update llama.cpp to ggml-org/llama.cpp@4df29be4f
1111
- fix(example): retain recurrent state for server MTP rollback
1212
- feat: update llama.cpp to ggml-org/llama.cpp@adb55e514
13+
- fix(server): show falsey defaults in CLI help by @cupkk in #2355
1314

1415
## [0.3.34]
1516

‎llama_cpp/server/cli.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@ def add_args_from_model(parser: argparse.ArgumentParser, model: Type[BaseModel])
8484

8585
for name, field in model.model_fields.items():
8686
description = field.description
87-
if field.default and description and not field.is_required():
87+
if description and not field.is_required() and field.default is not None:
8888
description += f" (default: {field.default})"
8989
base_type = (
9090
_get_base_type(field.annotation) if field.annotation is not None else str

0 commit comments

Comments
 (0)