Temp fix for a crash faced by client using proxy connection #1493
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Explanation: `ARTSRProxyConnect` object can potentially generate a proxy connection error even after initial success (or more than one error in a raw), which can depend on what proxy type is used, which will create a race condition: `self->_proxyConnect = nil;` deallocates `ARTSRProxyConnect` object on a `_workQueue`, and a subsequent call to `_failWithError:` on a `io.ably.socketrocket.NetworkThread` inside `ARTSRProxyConnect` will cause crash when it'll try to access `self`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Probably closes #1437
Explanation:
ARTSRProxyConnectobject can potentially generate a proxy connection error even after initial success (or more than one error in a raw), which can depend on what proxy type is used, which will create a race condition:self->_proxyConnect = nil;deallocatesARTSRProxyConnectobject on a_workQueue, and a subsequent call to_failWithError:on aio.ably.socketrocket.NetworkThreadinsideARTSRProxyConnectwill cause crash when it'll try to accessself.