-
Notifications
You must be signed in to change notification settings - Fork 43
[ECO-5267] Swift pub/sub getting started #2620
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
``` | ||
|
||
* Install "Xcode":https://developer.apple.com/xcode/ | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe add a step to create a new Swift project before installing the Ably SDK?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed
print("Connection state changed to: \(stateChange.current)") | ||
|
||
if stateChange.current == .connected { | ||
print("Made my first connection!") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On one hand, I think we shouldn't overcomplicate things; on the other hand, printing to the console in a SwiftUI project feels a bit out of place. Maybe we can create simple in-app console (just render list of lines in a text box)? Or maybe create console desktop swift app instead of swift ui?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This worked fine for me :). I did need to look elsewhere for help during the initial file setup in Xcode - - though that’s partly a knowledge issue because I’m not a Swift dev.
.... But I'm happy to approve this doc if we’re all happy with the content -- but with formatting
fixes needed!
I left a comment at the beginning regarding formatting — it applies throughout the doc. I’m also happy to pick this up and give it a quick tidy-up (and add any more setup info) if that’s helpful!!??
|
||
* Open up the "dev console":https://ably.com/accounts/any/apps/any/console of your first app before instantiating your client so that you can see what happens. | ||
|
||
* Add these imports to the top of your Swift file: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Which Swift file, @ContentView.swift@?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add "the following" imports to the top of your Swift file:
<p><strong>Important:</strong> API keys are suitable for development and demo purposes only. For production apps, <a href="/docs/authentication/token-authentication">use token authentication</a> to keep your credentials secure.</p> | ||
</aside> | ||
|
||
h2(#xcode-setup). Running this example in Xcode (SwiftUI) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make this h3
|
||
<aside data-type='note'> | ||
<p>The code examples in this guide include a demo API key. If you wish to interact with the Ably CLI and view outputs within your Ably account, ensure that you replace them with your own API key.</p> | ||
<p><strong>Important:</strong> API keys are suitable for development and demo purposes only. For production apps, <a href="/docs/authentication/token-authentication">use token authentication</a> to keep your credentials secure.</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe separate these :)
|
||
Clients establish a connection with Ably when they instantiate an SDK. This enables them to send and receive messages in realtime across channels. | ||
|
||
* Open up the "dev console":https://ably.com/accounts/any/apps/any/console of your first app before instantiating your client so that you can see what happens. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe just a re-jig with the way we are using bullets
Description
Adds Swift getting started guide for pub/sub
Checklist