Improve Gnus support and update for Emacs 27.1 #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When `ace-link-gnus' is called from the summary buffer, use the currently opened article buffer instead of switching to the selected article (which might be different). Also, do not jump to the next button, as this might lead to unintended scrolling of the article buffer.
kljohann
commented
Sep 12, 2020
| (while (progn (widget-forward 1) | ||
| (> (point) pt)) | ||
| (if (<= 27 emacs-major-version) | ||
| (mapcar #'cdr (ace-link--woman-collect)) |
There was a problem hiding this comment.
Maybe the "collect links in a buffer using button.el" functionality could be extracted and given a more general name.
| (declare-function widget-button-press "wid-edit") | ||
| (cond ((< emacs-major-version 27) | ||
| (widget-button-press (point))) | ||
| ((and (eq mm-text-html-renderer 'shr) |
There was a problem hiding this comment.
This could possibly already be required for Emacs 26.3 to open links in portions of the buffer rendered by shr.
|
Friendly ping @abo-abo, can you have a look at this change? :) |
|
Merged. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #56. In addition I added some ergonomic improvements:
ace-linkfrom the summary bufferforward-buttonwas called, which would scroll the window if the next button after point was out of view)@poulpoulsen Maybe you are interested in giving this a try.
N.B. The last two commits have only been tested with Emacs 27.1, so any feedback from someone still on Emacs 26.3 is appreciated.