fix issues

Author: SirCotare

lombok.config

@@ -1,5 +1,6 @@
 config.stopBubbling = true
 
+# Required for NullAway to work
 lombok.addLombokGeneratedAnnotation = true
 
 # Copy JSpecify annotations to generated code (constructors, getters, setters)

src/main/java/it/aboutbits/springboot/toolbox/exception/ConstraintViolationExceptionBuilder.java

@@ -6,7 +6,7 @@
 import jakarta.validation.metadata.ConstraintDescriptor;
 import org.hibernate.validator.internal.engine.path.PathImpl;
 import org.jspecify.annotations.NullMarked;
-import org.jspecify.annotations.NullUnmarked;
+import org.jspecify.annotations.Nullable;
 
 import java.util.HashSet;
 import java.util.Set;
@@ -54,28 +54,32 @@ public boolean hasCauses() {
         return !constraintViolations.isEmpty();
     }
 
-    @NullUnmarked
-    private record CustomConstraintViolation(String message, Path propertyPath) implements ConstraintViolation<Object> {
+    @NullMarked
+    public record CustomConstraintViolation(String message, Path propertyPath) implements ConstraintViolation<Object> {
         @Override
         public String getMessage() {
             return message;
         }
 
+        @Nullable
         @Override
         public String getMessageTemplate() {
             return null;
         }
 
+        @Nullable
         @Override
         public Object getRootBean() {
             return null;
         }
 
+        @Nullable
         @Override
         public Class<Object> getRootBeanClass() {
             return null;
         }
 
+        @Nullable
         @Override
         public Object getLeafBean() {
             return null;
@@ -86,6 +90,7 @@ public Object[] getExecutableParameters() {
             return new Object[0];
         }
 
+        @Nullable
         @Override
         public Object getExecutableReturnValue() {
             return null;
@@ -96,16 +101,19 @@ public Path getPropertyPath() {
             return propertyPath;
         }
 
+        @Nullable
         @Override
         public Object getInvalidValue() {
             return null;
         }
 
+        @Nullable
         @Override
         public ConstraintDescriptor<?> getConstraintDescriptor() {
             return null;
         }
 
+        @Nullable
         @Override
         public <U> U unwrap(Class<U> type) {
             return null;

src/main/java/it/aboutbits/springboot/toolbox/persistence/converter/UUIDConverter.java

@@ -2,15 +2,17 @@
 
 import jakarta.persistence.AttributeConverter;
 import jakarta.persistence.Converter;
-import org.jspecify.annotations.NullUnmarked;
+import org.jspecify.annotations.NullMarked;
+import org.jspecify.annotations.Nullable;
 
 import java.util.UUID;
 
 @Converter
-@NullUnmarked
+@NullMarked
 public class UUIDConverter implements AttributeConverter<UUID, String> {
     @Override
-    public String convertToDatabaseColumn(UUID attribute) {
+    @Nullable
+    public String convertToDatabaseColumn(@Nullable UUID attribute) {
         if (attribute == null) {
             return null;
         }
@@ -19,7 +21,8 @@ public String convertToDatabaseColumn(UUID attribute) {
     }
 
     @Override
-    public UUID convertToEntityAttribute(String dbData) {
+    @Nullable
+    public UUID convertToEntityAttribute(@Nullable String dbData) {
         if (dbData == null || dbData.isBlank()) {
             return null;
         }

src/main/java/it/aboutbits/springboot/toolbox/swagger/SwaggerMeta.java

@@ -4,21 +4,34 @@
 import com.fasterxml.jackson.annotation.JsonProperty;
 import lombok.Getter;
 import lombok.Setter;
-import org.jspecify.annotations.NullUnmarked;
+import org.jspecify.annotations.NullMarked;
+import org.jspecify.annotations.Nullable;
 
+// JsonProperty on boolean fields is required or it will interpret the name as a getter and remove the "is".
 @Getter
 @Setter
 @JsonInclude(JsonInclude.Include.NON_NULL)
-@NullUnmarked
+@NullMarked
 public class SwaggerMeta {
+    @Nullable
     private String originalTypeFqn = null;
+
+    @Nullable
     @JsonProperty("isIdentity")
     private Boolean isIdentity = null;
+
+    @Nullable
     @JsonProperty("isCustomType")
     private Boolean isCustomType = null;
+
+    @Nullable
     @JsonProperty("isNestedStructure")
     private Boolean isNestedStructure = null;
+
+    @Nullable
     @JsonProperty("isMap")
     private Boolean isMap = null;
+
+    @Nullable
     private String mapKeyTypeFqn = null;
 }

src/main/java/it/aboutbits/springboot/toolbox/type/ScaledBigDecimal.java

@@ -188,7 +188,6 @@ public ScaledBigDecimal roundToScale(int scale) {
     }
 
     @Override
-
     public String toString() {
         return this.value().toString();
     }
@@ -221,7 +220,6 @@ public int compareTo(ScaledBigDecimal o) {
      * This is temporary. We need to avoid changing any rounding logic at the moment.
      */
     @Deprecated
-
     public BigDecimal toCurrency() {
         return this.value().setScale(2, RoundingMode.HALF_UP);
     }
@@ -231,7 +229,6 @@ public BigDecimal toCurrency() {
      * This is temporary. We need to avoid changing any rounding logic at the moment.
      */
     @Deprecated
-
     public ScaledBigDecimal roundToCurrency() {
         return new ScaledBigDecimal(this.value().setScale(2, RoundingMode.HALF_UP));
     }

src/main/java/it/aboutbits/springboot/toolbox/util/NullUtil.java

@@ -42,7 +42,6 @@ class SortParameterResolverTest {
     @InjectMocks
     private SortParameterResolver sut;
 
-    @SuppressWarnings("NullAway.Init")
     @BeforeEach
     void setUp() {
         when(methodParameter.getParameterName()).thenReturn("sort");