Skip to content

Commit 72c0978

Browse files
committed
Implement CRC32_u64 and V128_Low64 for x86 builds
`_mm_cvtsi128_si64` and `_mm_crc32_u64` intrinsics are available only when building for x64. In order not to disable crc32 optimizations for 32-bit builds, equivalent code is implemented using intrinsics that are available when targeting 32-bit builds.
1 parent fa57bfc commit 72c0978

File tree

1 file changed

+19
-7
lines changed

1 file changed

+19
-7
lines changed

absl/crc/internal/crc32_x86_arm_combined_simd.h

+19-7
Original file line numberDiff line numberDiff line change
@@ -25,16 +25,14 @@
2525
// We define a translation layer for both x86 and ARM for the ease of use and
2626
// most performance gains.
2727

28-
// This implementation requires 64-bit CRC instructions (part of SSE 4.2) and
29-
// PCLMULQDQ instructions. 32-bit builds with SSE 4.2 do exist, so the
30-
// __x86_64__ condition is necessary.
31-
#if defined(__x86_64__) && defined(__SSE4_2__) && defined(__PCLMUL__)
28+
// This implementation requires CRC instructions (part of SSE 4.2) and
29+
// PCLMULQDQ instructions.
30+
#if defined(__SSE4_2__) && defined(__PCLMUL__)
3231

3332
#include <x86intrin.h>
3433
#define ABSL_CRC_INTERNAL_HAVE_X86_SIMD
3534

36-
#elif defined(_MSC_VER) && !defined(__clang__) && defined(__AVX__) && \
37-
defined(_M_AMD64)
35+
#elif defined(_MSC_VER) && !defined(__clang__) && defined(__AVX__)
3836

3937
// MSVC AVX (/arch:AVX) implies SSE 4.2 and PCLMULQDQ.
4038
#include <intrin.h>
@@ -143,7 +141,13 @@ inline uint32_t CRC32_u32(uint32_t crc, uint32_t v) {
143141
}
144142

145143
inline uint32_t CRC32_u64(uint32_t crc, uint64_t v) {
144+
#if defined(__x86_64__) || defined(_M_X64)
146145
return static_cast<uint32_t>(_mm_crc32_u64(crc, v));
146+
#else
147+
uint32_t v_lo = static_cast<uint32_t>(v);
148+
uint32_t v_hi = static_cast<uint32_t>(v >> 32);
149+
return _mm_crc32_u32(_mm_crc32_u32(crc, v_lo), v_hi);
150+
#endif
147151
}
148152

149153
inline V128 V128_Load(const V128* src) { return _mm_load_si128(src); }
@@ -191,7 +195,15 @@ inline uint64_t V128_Extract64(const V128 l) {
191195
return static_cast<uint64_t>(_mm_extract_epi64(l, imm));
192196
}
193197

194-
inline int64_t V128_Low64(const V128 l) { return _mm_cvtsi128_si64(l); }
198+
inline int64_t V128_Low64(const V128 l) {
199+
#if defined(__x86_64__) || defined(_M_X64)
200+
return _mm_cvtsi128_si64(l);
201+
#else
202+
uint32_t r_lo = static_cast<uint32_t>(_mm_extract_epi32(l, 0));
203+
uint32_t r_hi = static_cast<uint32_t>(_mm_extract_epi32(l, 1));
204+
return static_cast<int64_t>((static_cast<uint64_t>(r_hi) << 32) | r_lo);
205+
#endif
206+
}
195207

196208
inline V128 V128_ShiftLeft64(const V128 l, const V128 r) {
197209
return _mm_sll_epi64(l, r);

0 commit comments

Comments
 (0)