Skip to content

Commit 6256a76

Browse files
committed
Merge branch 'master' into 2.0
2 parents f0ae858 + 18410ba commit 6256a76

File tree

3 files changed

+7
-14
lines changed

3 files changed

+7
-14
lines changed

CHANGELOG.md

+5
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,8 @@
1+
## Release 2.1.2
2+
3+
- Remove IntrospectionProcessor from default to make logs less noisy [[0a80de4]](http://github.com/elasticsearch/elasticsearch-php/commit/0a80de4)
4+
- Remove redundant logging on failure [[f31a211]](http://github.com/elasticsearch/elasticsearch-php/commit/f31a211)
5+
16
## Release 2.1.1
27

38
- More robust error logging during connection failure / retries [[0069fd6]](http://github.com/elasticsearch/elasticsearch-php/commit/0069fd6)

src/Elasticsearch/ClientBuilder.php

-2
Original file line numberDiff line numberDiff line change
@@ -180,9 +180,7 @@ public static function defaultLogger($path, $level = Logger::WARNING)
180180
{
181181
$log = new Logger('log');
182182
$handler = new StreamHandler($path, $level);
183-
$processor = new IntrospectionProcessor();
184183
$log->pushHandler($handler);
185-
$log->pushProcessor($processor);
186184

187185
return $log;
188186
}

src/Elasticsearch/Connections/Connection.php

+2-12
Original file line numberDiff line numberDiff line change
@@ -203,8 +203,9 @@ private function wrapHandler(callable $handler, LoggerInterface $logger, LoggerI
203203

204204
$neverRetry = isset($request['client']['never_retry']) ? $request['client']['never_retry'] : false;
205205
$shouldRetry = $transport->shouldRetry($request);
206+
$shouldRetryText = ($shouldRetry) ? 'true' : 'false';
206207

207-
$this->log->warning("Retries left? ". ($shouldRetry) ? 'true' : 'false');
208+
$this->log->warning("Retries left? $shouldRetryText");
208209
if ($shouldRetry && !$neverRetry) {
209210
return $transport->performRequest(
210211
$request['http_method'],
@@ -488,17 +489,6 @@ protected function getCurlRetryException($request, $response)
488489
break;
489490
}
490491

491-
$this->logRequestFail(
492-
$request['http_method'],
493-
$response['effective_url'],
494-
$request['body'],
495-
$request['headers'],
496-
$response['status'],
497-
$response['body'],
498-
$response['transfer_stats']['total_time'],
499-
$exception
500-
);
501-
502492
return $exception;
503493
}
504494

0 commit comments

Comments
 (0)