Server Fails to Start if RCON Password is Not Set

[azgaviperr]

Description:

When attempting to launch the Arma Reforger dedicated server without setting an RCON password (e.g., by omitting the RCON_PASSWORD environment variable), the server fails to start.
The issue appears to be caused by the launch.py script and docker_default.json file combining to pass an invalid password value to the server, which results in a startup error. The server log indicates that a space or an invalid character is being received for the password field, even though no password was intended to be set.

Steps to Reproduce:

• Use a clean acemod/docker-reforger setup.
• Ensure the RCON_PASSWORD environment variable is not set.
• Execute the launch.py script to start the server.
• Monitor the server startup logs.

Expected Behavior:

The server should start successfully with RCON disabled by default. It should not require a password to be set for the server to function.

Actual Behavior:

The server fails to start and exits. The logs show a validation error related to the RCON password, for example:
Error space not accepted in password

This indicates that the server is receiving an invalid RCON password from the configuration generated by the script, even when a password was not provided by the user.

Proposed Solution:

The launch.py script should be updated to handle the rcon section conditionally. If the RCON_PASSWORD environment variable is not set, the launch.py script should:

• Either completely omit the rcon section from the final configuration JSON that is passed to the server.
• Or remove the value of the default_docker.json

This would prevent the server from attempting to validate a non-existent or invalid password string, allowing it to start correctly with RCON disabled.