[Build/Meta] Make make smarter about installing dependencies (#10004)

This makes the `make` command smarter about when to run `composer
install` or `npm ci` instead of constantly doing it every single time
you build.

`composer install --no-dev` will only be run if the vendor directory is
missing or the composer.lock has changed. `composer install` will only
be run if the needed tool (phpunit or phan) from dev is required for the
target being run and either he composer.lock has been changed or the
tool is missing (because `composer install --no-dev` generated the
vendor directory.)

Similarly, `npm ci` will now only be run if the node_modules directory
is missing or the package-lock.json file has been modified.

There were a few .PHONY rules which were either no longer used
meta-targets relevant or never were used that are removed as a result of
these changes. (phpdev, fastdev, jsdev)

Co-authored-by: Dave MacFarlane <[email protected]>

Author: driusan

Makefile

@@ -1,23 +1,25 @@
-.PHONY: clean dev all check checkstatic unittests phpdev jslatest testdata fastdev jsdev locales
+.PHONY: clean dev all check checkstatic unittests jslatest testdata locales
 
-all: locales VERSION
-	composer install --no-dev
-	npm ci
+all: node_modules locales VERSION vendor
 	npm run build
 
 # If anything changes, re-generate the VERSION file
 VERSION: .
 	tools/gen-version.sh
 
-phpdev:
+vendor/bin/phan: composer.lock
 	composer install
 
-dev: jsdev locales phpdev fastdev
+vendor/bin/phpunit: composer.lock
+	composer install
+
+vendor: composer.lock
+	composer install --no-dev
 
-jsdev:
+node_modules: package-lock.json
 	npm ci
 
-fastdev: VERSION
+dev: node_modules locales vendor/bin/phan VERSION vendor
 	npm run compile
 
 jslatest: clean
@@ -35,7 +37,7 @@ clean:
 	rm -f modules/*/locale/*/LC_MESSAGES/*.mo
 
 # Perform static analysis checks
-checkstatic: phpdev
+checkstatic: vendor/bin/phan dev
 	npm run lint:php
 	vendor/bin/phan
 	npm run lint:js
@@ -48,7 +50,7 @@ checkstatic: phpdev
 make checklanguage:
 	npx alex --quiet --why --diff
 
-unittests: phpdev
+unittests: vendor/bin/phpunit
 	vendor/bin/phpunit --configuration test/phpunit.xml
 
 # Perform all tests that don't require an install.